From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBAE928B4E2 for ; Sun, 1 Mar 2026 21:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772401711; cv=none; b=MMqe8RjSn28G1b3p6Bt+N10W7GRLTtVHuxnicRzlFjxQTo0Nn6+g4v080nY3+O5EDfN/TNMRdhLjDEEmO2RoMXJSFRvpYJk28E1qO/zpClOL9wKjWDlEjKZHf+/FrBXMRUZchIX845VxAeMKfw89FjyiApoFuhh3FwAtXXmMDd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772401711; c=relaxed/simple; bh=uV6SXSw0MfWVMfNUuFGGsqwMAghKj394Vh1glXZgdYo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DE0RWX40tL15DflLxyJ7Ztx+g/IkZmIGbESkOns8NdSbhDSgjHC8jI3N8DpzPDG5qpdyhL8IAZdg3z4W1DQpKkAGaJTiBxV5IVG3x8Ov1IqKQokjqYMcYvWN0QEaDNTpyvBYrmZGmjtzEGCvoesZX1zCi3jSWO9TqdTnKVR5OTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g++agZ3o; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g++agZ3o" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8cb3825b0fbso375021885a.0 for ; Sun, 01 Mar 2026 13:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772401707; x=1773006507; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T2a4CYTNrZFLepOLrTsLDlAjY/UqwcgUk97CHAjW/Q0=; b=g++agZ3oEbs7v2d0+zVqJiCE8W+z0i7S0Vc6WevprblhSKPFYf5r2C0jeFcXj10c68 Jpi9J3+5h7Pa8RW9wPH1Je2q1Zh285neo2EvR1UZo2Fe/sESs9tux5LkdRtGPPAWKz8J ggOVyzg/rAlU+0GAVrO01Arj9CR4fGQ8EVEG6/zhPi/0lpJ4q40LhMrHLybaBkGp3LJl /4S4SRLXff5rzNRC17ZaW9N44wp1eFtXGJ7yR5qFZIqTMDQc7jeZ14Lm0BIE654pLdav 6JZeHRlBoDt2p4JAwvkBP1oX0TCaP32DA0D4AhN00sGAlSSkuUJ95J7MTIv9dVMGZo5y xyjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772401707; x=1773006507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T2a4CYTNrZFLepOLrTsLDlAjY/UqwcgUk97CHAjW/Q0=; b=wDgETLIlAoONZfP26o5wSuPc0y+e8vS4x4xwFYko2T2UR9y7Hni5AqqIbdLV5poPRV ZXIAdoyTkncCWmWZhcpJr5hp7knbJeWM2oPG1I3gWgA1yPkj3fYTy+lHw36mlu+5MbEX 7Q66Ja1FRhq5JZ7UvvLh6vycoI3wpWBRoODQMGyCVpyIvmtrsoJ7n9oQUXCMckuaakRX SEn6tFOmf7q07yxvdijJ8z0T/wfamcmMQwol5VfLP+NnLy2Wf/eeR5KnbrLLlCOY9SeT lBj+1OXE3GSQuTn0meqsJQ+m3zM0oKckBsLdBT57HkubplZuhcDm4rZdjn1rsleb2npW J56Q== X-Forwarded-Encrypted: i=1; AJvYcCVpabQs9H3JDM/pw69Y4T3yB0d5oRKKNTTvFJG6DCE5aekEAVrP40DXuy63KjobF1+rpk3fIvcNDabOHBk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxd/B5ccCA5glwo0y+AhShb631KjrAqZ7GU93PmQDSHNdxRYgNY GjDIxj6wzENcL3MvR89iYCyWPhwQxGciDNMGERc5sKchlyyBqvMv1Vis X-Gm-Gg: ATEYQzx6mWzJZlRk9YvKsNNfQdmPzldDS0WEetTXa/amvKIxbAGPbgOUAI6SnRnHsh3 E4MU/JZ9hY8I8r7R6SSPuj5OLV7+FDOyr3yiZFGbumQ7sa8RexsCPhESNMi2rEFy+O9UO9MX8Gc W2PB/0zW3tN64+27kABtGB9c6NLtNo9grKdBybZRNp8v2CQi1GwR9b/28VPgYejKdBfdbki5Qg5 26czWqOfvpRfM1L67IDEjjVV6pbfpPYJc7fjU/gG4ZF72GYs3gVhX4T0M9ZzNYsnMPU76jAVx1D JxTRPGSCpOMiE4y+SXpSekHqI4cB6AnlNTlK9F4Xvn88GHBc9ARxdBd+3eWsj1OvbD0SpJQ1Z0n vR3DMntqWXp4Bz50C5eYiaj6P6vnrd7PFxyZxFLEQwGFhrAg2NopXqkxvUuIqH+TIqYQy/h2S7h HiTNP2vEkhljTdpY2Psj+bHrsjR/25EhyWESOPPO5Jn0+Cbrwoxi5dlNoPj8fOkn8XNjeQWLDzu ZWw X-Received: by 2002:a05:620a:4590:b0:8b2:e9d2:9c69 with SMTP id af79cd13be357-8cbc8d7b815mr1331987985a.22.1772401706797; Sun, 01 Mar 2026 13:48:26 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf6f948dsm1006700085a.30.2026.03.01.13.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 13:48:25 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Greg Kroah-Hartman , Ovidiu Panait Cc: Gabriel Shahrouzi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH v2 05/10] staging: axis-fifo: improve IRQ handler Date: Sun, 1 Mar 2026 21:48:10 +0000 Message-ID: <20260301214815.2628942-5-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301214815.2628942-1-objecting@objecting.org> References: <20260301214815.2628942-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Josh Law Return IRQ_NONE when no interrupts were triggered to avoid spurious interrupt storms, and only clear the active interrupts instead of blindly clearing all interrupts by writing 'intr' to the ISR instead of XLLF_INT_CLEAR_ALL. Signed-off-by: Josh Law --- drivers/staging/axis-fifo/axis-fifo.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index 28268881cda2..aad2206b481a 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -302,6 +302,9 @@ static irqreturn_t axis_fifo_irq(int irq, void *dw) isr = ioread32(fifo->base_addr + XLLF_ISR_OFFSET); intr = ier & isr; + if (!intr) + return IRQ_NONE; + if (intr & XLLF_INT_RC_MASK) wake_up(&fifo->read_queue); @@ -324,7 +327,7 @@ static irqreturn_t axis_fifo_irq(int irq, void *dw) dev_err(fifo->dt_device, "transmit length mismatch error interrupt\n"); - iowrite32(XLLF_INT_CLEAR_ALL, fifo->base_addr + XLLF_ISR_OFFSET); + iowrite32(intr, fifo->base_addr + XLLF_ISR_OFFSET); return IRQ_HANDLED; } -- 2.43.0