From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04B7129E114 for ; Sun, 1 Mar 2026 22:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772402716; cv=none; b=XaCZvFx7zvsVzszO34oLtj6ITHLxmqROfOSNER5hzWOsFSxRTsEq39BFnVeZjY6tkge6IMIMsfdKusqPUQ2sdycHzbHKN+hXVUvAOBZAEHXwFKgu5dWYoWbErSnXD+j/C7Qb6pIazRn7lqDywQUfal99c1WLh56f5j4Lc3BgLjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772402716; c=relaxed/simple; bh=BQIvoVSJDYNycWbS6yomIK774a4sW6fFhXvE2Q8s9R8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IV+Xmt2ZT7MOafAqucFsJeN761Of7BgfWlQPaj7wloLC3x1glIgvURzKSCUJops0DEC5kW7bFBaD5YhYQ1AbRJlQ6td8t2ngd54989gma6j6IWB19OT0MAfNLTP3amZvR2vf/gbgVHaL554JBkTRoagpk955y7H3aHBm6lax/B8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kdGwyAan; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kdGwyAan" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4833115090dso38439765e9.3 for ; Sun, 01 Mar 2026 14:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772402713; x=1773007513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pyjoB/kRbGY4XDMa0IyKer9xQQnWmnovjSoUMcAR3pk=; b=kdGwyAanDKDOdb8FWuinY1ORzmdnhzivzrldBUi5/b32zKzywkZg0N1wTKUrdIUVaz r0kfauHZgDXhO+vB2cl5Q48y7G4rR3ps6wyHbj2BuchGP5funjL3b3gxoLHAoSQ3rFe9 V1BfRWK5yO6YlqgGhfkJV229Pqq0Bp9mJTtasrbMdG7zhDY7ecwwL/M4MlS1P+5FKQxK Ry6pS0pMkBJtB7p0RHaO9BOdQTUPFrYd2A+Nhn+cwCh/oqjDbrHJ/Vfyzx/g0E2Enr3y wEJQTPbPM/I33Jymcq4q/MpROZidSVF5HtuFomDV6uZcs1J7jokovnhngclHz/amP6+B Q5Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772402713; x=1773007513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pyjoB/kRbGY4XDMa0IyKer9xQQnWmnovjSoUMcAR3pk=; b=qbC7TtZQRL5JJWrL/5iVhbb9pRvQvnc3jx+9sNhCthIQmQggravHaK3OfuxEIweoef 8aB8ZXzKPKgTeYUwZCif6yaI7/e38LRrgmFYS+D63eSepK0ObEeHLGNpxMS24iFUqIEI ANppY5H3ePW2gtXATgmUBZN1kNeKyI10OuF3WsZdeyU1j+fkEpWF/LMWzeDivJk2kKJX c+gni1ZrWscOFE8CQUGq+bxs0Kcd++oJ7zD+q4cz1Opgwwz++cp44rfaAkODdQb2neXj SGh2Mgea1OCdgnds9BufMOAivg7cLZmf4XQ91Myk6bLTpr5n6Bg8tgLc4yAjvqFeU+Fz UImA== X-Forwarded-Encrypted: i=1; AJvYcCVtJgfy9XYW4lbuBM/kC/i+h3dhCb1p5Y25Gih3WF5XNr8VuqQSqdMfT/17tj8JWoC495AYvfwYzhdyqNs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqxk85EiBOOKQ55tntt9QG+FUrU41Y6tNvFWnCe39ocpiLLezu hBFGsINft6/yoq8AXiXbTxzypbwAGtGAyZOSfcoer6Pin7Z5CYTqcC8j X-Gm-Gg: ATEYQzwUvnufwtIitzbhB0IyAbG8hOvWXqJPfCDY97sNLCT8rqba8p2c8yjc3vOgt6a pG+wXotvs5YyFmwdaNfiQb7vvEeXBqyIEP97sJdzeXbCXv8BRwPYD0PnfpwQmb2/2l+txlENA5k JszBkldeDidfQSeBqRTX/oK1Vk8IkTNBv/fTZpeip9xb3Rg3SIkK0gqhdOFgDIdSKd0Qy1pdH79 JfMIogEwlLHResbXaceXmZAE1/bmHYt1sMgwbxB9ZKR+h8sE9a44MXaenvqD3sxLodpNTyL+mLK TrvQCSoiN6SOT1QavDzZ4SOT0Hs40pZDAzPivKlBSQj9IWTSkj8jxtdWHW/Zp0Imox6UCXyZW0c zIX2nMAjomQ1cARR6huPp7gMEgYGU0h/SQsCanqHQYka791C2U/wXakoTRv1aezF03+19b5vnDY m72GkWoSyJwP7Mkt48SPbNG6kLfbMn8BwJF44XRn31fv+WSYjcu9W/UdtPLugThh1t X-Received: by 2002:a05:600c:314a:b0:477:58:7cf4 with SMTP id 5b1f17b1804b1-483c9ba7e58mr166421175e9.4.1772402713326; Sun, 01 Mar 2026 14:05:13 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd702e7bsm407677485e9.5.2026.03.01.14.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 14:05:13 -0800 (PST) Date: Sun, 1 Mar 2026 22:05:12 +0000 From: David Laight To: Andrew Morton Cc: Josh Law , linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Message-ID: <20260301220512.35d0bc24@pumpkin> In-Reply-To: <20260301112542.0d915c2388febccf0294b880@linux-foundation.org> References: <20260301152143.2572137-1-objecting@objecting.org> <20260301152143.2572137-2-objecting@objecting.org> <20260301112542.0d915c2388febccf0294b880@linux-foundation.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 1 Mar 2026 11:25:42 -0800 Andrew Morton wrote: > On Sun, 1 Mar 2026 15:21:42 +0000 Josh Law wrote: > > > Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools. > > > > Fair enough. It might even generate better code. Compilers have been known to generate 'really crap code(tm)' for boolean arithmetic. David > > > --- a/lib/glob.c > > +++ b/lib/glob.c > > @@ -96,7 +96,8 @@ bool __pure glob_match(char const *pat, char const *str) > > class += 2; > > /* Any special action if a > b? */ > > } > > - match |= (a <= c && c <= b); > > + if (a <= c && c <= b) > > + match = true; > > } while ((a = *class++) != ']'); > > > > if (match == inverted) > > But if we're concerned about bool abuse, what's this? > > bool match = false, inverted = (*pat == '!'); > char const *class = pat + inverted; > >