[PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_cmd.c

[PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_cmd.c

[Oskar Ray-Frayssinet]

Replace msleep(10) with usleep_range(10000, 11000) as msleep < 20ms
can sleep for up to 20ms and usleep_range is preferred for short
sleep durations.

Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index abb84f8aecbe..f6293f049c75 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -214,7 +214,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
 {
 	_cancel_workitem_sync(&pevtpriv->c2h_wk);
 	while (pevtpriv->c2h_wk_alive)
-		msleep(10);
+		usleep_range(10000, 11000);
 
 	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
 		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_cmd.c

[Ethan Tidmore]

On Sun Mar 1, 2026 at 5:03 PM CST, Oskar Ray-Frayssinet wrote:
> Replace msleep(10) with usleep_range(10000, 11000) as msleep < 20ms
> can sleep for up to 20ms and usleep_range is preferred for short
> sleep durations.
>
> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---

This has already came up before and Greg decided to drop it. [1]

Thanks,

ET

[1] https://lore.kernel.org/linux-staging/20260214173139.49094-1-ofekalm100@gmail.com/

[PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_cmd.c

[Haroen Tmimi]

checkpatch.pl issued a warning about msleep(10) not being at least 20ms.
However, 10ms might not be precise enough.

usleep_range(10000, 11000) is a better choice.
It allows for a little flexibility in scheduling.

Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index ef2d92b55..97c923015 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -215,7 +215,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
 {
 	_cancel_workitem_sync(&pevtpriv->c2h_wk);
 	while (pevtpriv->c2h_wk_alive)
-		msleep(10);
+		usleep_range(10000, 11000);
 
 	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
 		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
-- 
2.52.0

Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_cmd.c

[Ethan Tidmore]

On Wed Feb 4, 2026 at 7:44 AM CST, Haroen Tmimi wrote:
> checkpatch.pl issued a warning about msleep(10) not being at least 20ms.
> However, 10ms might not be precise enough.
>
> usleep_range(10000, 11000) is a better choice.
> It allows for a little flexibility in scheduling.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>

Looks good to me.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

ET

Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_cmd.c

[Greg KH]

On Wed, Feb 04, 2026 at 02:44:47PM +0100, Haroen Tmimi wrote:
> checkpatch.pl issued a warning about msleep(10) not being at least 20ms.
> However, 10ms might not be precise enough.
> 
> usleep_range(10000, 11000) is a better choice.
> It allows for a little flexibility in scheduling.
> 
> Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index ef2d92b55..97c923015 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -215,7 +215,7 @@ void _rtw_free_evt_priv(struct	evt_priv *pevtpriv)
>  {
>  	_cancel_workitem_sync(&pevtpriv->c2h_wk);
>  	while (pevtpriv->c2h_wk_alive)
> -		msleep(10);
> +		usleep_range(10000, 11000);
>  
>  	while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
>  		void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
> -- 
> 2.52.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You sent a patch that has been sent multiple times in the past, and is
  identical to ones that has been recently rejected.  Please always look
  at the mailing list traffic to determine if you are duplicating other
  people's work.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot