From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2E233B8BD3 for ; Mon, 2 Mar 2026 13:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772459239; cv=none; b=Q+boVCrCuhnKEROSeiiMn2wA/FyB6yMnz1gTQFYnTz4w/XBd3autrR4aSJKuZd1hXmldkxFQZycCj1deCyVXWU4MIhHsHQqJApGozy0mS3YAFbTwr1Kh3I5s8p2ePYaYUm6SXIvsAXP1Jab4DvSs8EWxj5PaRwx2iG3dGTxVdck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772459239; c=relaxed/simple; bh=xCJrwcDDyo8LLH18A68PDQVaRjBZZCLL4CceXSPjnU4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=fluW5fruX6rZjyPHcQF4PDBWLP6m3QNcYWZzI5XdlmFaS5Wt8BcINtOi4NXuJvLsPdw5BKUexC2pdwZlSuGcCW32tnWseKTHlqZ0bY5esknodq/gtGp413/57YThon10eziknF6Tf8+JEL+OnDZkdDSspw5akix6eFnEa7aUnqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U4Zsj7bn; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U4Zsj7bn" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2addb31945aso33450595ad.1 for ; Mon, 02 Mar 2026 05:47:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772459238; x=1773064038; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=19etRSJE9t4MqtgRfKOwWBsjZmOQTD0TaU9pT3V0aNA=; b=U4Zsj7bnMCtkthDj91l7MaW2gOYi/FEE5F1yOpmWggl1c/Uw2oRYs8lnVbGHssiNx/ dAMAfCZgNq9jVKpzDsiyChBiDI4xdHe+4g5wj5pDMQqGfUzE94qs74OATPMZLOcuVyZq SE5zGC3gZ0lHcUV/Kc4v9ink+ae4JgYBgANcGIOdqhXwqdxGyZBTr7ba2DjwMEz36Pgs 0SodbdmgPprmz5qMvX5SzUWBbSdyaJj0MrYXMn6SdbAmIonOJRd+eiPplU802amcQmhC FjEwHZW5qdFylMsMv+a/AQVA0EafwX7RhiqzyoV3Up9QHEWkaIrXg8eknaTnu3dW4l2k SfLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772459238; x=1773064038; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=19etRSJE9t4MqtgRfKOwWBsjZmOQTD0TaU9pT3V0aNA=; b=YhgXN579VzS6sislMoR3cz/pDpDVMLq91Z7ftMeflLYwyzJ58QgWk9SG2JfkW0fySf ZIiQU7xy+xZ+zJ/rS+BLcV6nBm+XSTogTHqF4UfOenSvC7znJcIi+DwkFPUky0Pv2ZQo O9nZCSQtiOPyqe97qy11NJEjrmreVokQ4fVlscZTnRQRNNVRj1XKLkFBqso7ioLiTaBL j2KE+bZVg7BVK6QlnCPZWD2l9m5KVqqRQNZoqlAAbnP0USVXySPcEp90FaO2+g8MpvIB oKYzoOqIwvd96HqSSZM8s7ltj9nLpO1eJUBDXPUGH/ba9WW5IiCToUG2r7NvBAb19cVt Wb2g== X-Forwarded-Encrypted: i=1; AJvYcCUCHNS3duG0rrkUElYJW2RIP/Z3Hw4ZUYovjHQbV3h/3RnYk0JFK8QpeakfYlwwxQeCFPwqqQ944iUChAk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1q4Ge9jLTX0R4hfaukP9+uvio1j+hKbOVVxP0grK5oAAzhWrI Ex3wLMyVbFsKyvqn//2poGe6+oJrEVcgA7U+YN8RnOqYO7L/m4nBXxuj X-Gm-Gg: ATEYQzxvgqyMtdo2KINOpgnn9IbWp2UQDxlLpB4sY3T5TPwRJOJ+Rr3QlChz6jeXtQW StPcipUbROrdDUKUWTCki+1MTpiyK/LFWdgiwTxqTsg30EtTmsg91pdjKCX01WvoyptKFA8akvC MzlGcUqTVa4xio68AT9NhDlFuxYLDbUNLmH6byRSjwiUSgipe4FZHnCVkeZPSpyitAu/sn+TEvj yQQP6qWWlJ0ydkwL4rnBSwB9VfQJq2u9g9urc/N8yi8yle+KfUQn/f8kfD5PC9u77vux5KLih0U dzLRwU0I+wB/9FlcjUNZ+bvQzo3TC6ZTy1xIWaB3h/IsOkSgwsfUoMJb3BbTocIUVFYtouipaRR gDH+TlMIHvJnlS+37F4tVRq4SqdE7gFWVbPlupZH7aBXiJGeYzImn+8Q0C8aXJDdXzgMoAOyPkK G44I9UbzxBMKKyH0FoL+iu92fKFNNC6ODduTsA X-Received: by 2002:a17:902:e550:b0:2aa:d287:693d with SMTP id d9443c01a7336-2ae2e402022mr117574295ad.20.1772459237982; Mon, 02 Mar 2026 05:47:17 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:4c92:fc5c:54e5:712e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae4e571b90sm37553965ad.62.2026.03.02.05.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 05:47:17 -0800 (PST) From: Felix Gu Date: Mon, 02 Mar 2026 21:47:12 +0800 Subject: [PATCH v2] mmc: sdhci-of-bst: Fix memory leak in sdhci_bst_alloc_bounce_buffer() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260302-bst-v2-1-c7bfbed68d10@gmail.com> X-B4-Tracking: v=1; b=H4sIAN+UpWkC/1WMywqDMBBFf0Vm3ZQ8IMGu+h/FhUmmOlBNyUiwS P69qbsuz+WecwBjJmS4dQdkLMSU1gb60kGYx3VCQbExaKmtNFIJz5tw1nsXbHS9UdCe74xP2s/ KY2g8E28pf85oUb/13y9KKBGjD1pjMBj7+7SM9LqGtMBQa/0CSp/Zc5YAAAA= X-Change-ID: 20260301-bst-76bb7c6d7931 To: Adrian Hunter , Ge Gordon , BST Linux Kernel Upstream Group , Ulf Hansson , Albert Yang , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772459234; l=1415; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=xCJrwcDDyo8LLH18A68PDQVaRjBZZCLL4CceXSPjnU4=; b=0DCQ9xxPJewQ/HpTkeeyfaNTm8Jm/WD7oQHkoQgp71kyn27fZMrrkq0Hz3P8CN4TuwKvRyLY2 llzB6hbF953D69a6QL+fnDpluz9AFWpdUnI1NVDVlFYcTMwFNtxh5S6 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In sdhci_bst_alloc_bounce_buffer(), if dma_alloc_coherent() fails, the function immediately returns -ENOMEM without releasing the reserved memory, which results in a memory leak. Add the missing of_reserved_mem_device_release() call before returning -ENOMEM to properly clean up the reserved memory. Fixes: 695824f45629 ("mmc: sdhci: add Black Sesame Technologies BST C1200 controller driver") Signed-off-by: Felix Gu --- Changes in v2: - Fix Adrian's comment. - Link to v1: https://lore.kernel.org/r/20260301-bst-v1-1-ddbc22ec3ed9@gmail.com --- drivers/mmc/host/sdhci-of-bst.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-bst.c b/drivers/mmc/host/sdhci-of-bst.c index c124990a64f4..f8d3df715e1a 100644 --- a/drivers/mmc/host/sdhci-of-bst.c +++ b/drivers/mmc/host/sdhci-of-bst.c @@ -425,8 +425,10 @@ static int sdhci_bst_alloc_bounce_buffer(struct sdhci_host *host) host->bounce_buffer = dma_alloc_coherent(mmc_dev(mmc), bounce_size, &host->bounce_addr, GFP_KERNEL); - if (!host->bounce_buffer) + if (!host->bounce_buffer) { + of_reserved_mem_device_release(mmc_dev(mmc)); return -ENOMEM; + } host->bounce_buffer_size = bounce_size; --- base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 change-id: 20260301-bst-76bb7c6d7931 Best regards, -- Felix Gu