[PATCH] power: sequencing: pcie-m2: Fix device node reference leak in probe

[PATCH] power: sequencing: pcie-m2: Fix device node reference leak in probe

[Felix Gu]

In pwrseq_pcie_m2_probe(), ctx->of_node acquires an explicit reference
to the device node using of_node_get(), but there is no corresponding
of_node_put() in the driver's error handling paths or removal.

Since the ctx is tied to the lifecycle of the platform device, there
is no need to hold an additional reference to the device's own of_node.

Fixes: 52e7b5bd62ba ("power: sequencing: Add the Power Sequencing driver for the PCIe M.2 connectors")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
 drivers/power/sequencing/pwrseq-pcie-m2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c
index d31a7dd8b35c..dadb4aad9d5d 100644
--- a/drivers/power/sequencing/pwrseq-pcie-m2.c
+++ b/drivers/power/sequencing/pwrseq-pcie-m2.c
@@ -109,7 +109,7 @@ static int pwrseq_pcie_m2_probe(struct platform_device *pdev)
 	if (!ctx)
 		return -ENOMEM;
 
-	ctx->of_node = of_node_get(dev->of_node);
+	ctx->of_node = dev_of_node(dev);
 	ctx->pdata = device_get_match_data(dev);
 	if (!ctx->pdata)
 		return dev_err_probe(dev, -ENODEV,

---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260302-m2-f638d393632e

Best regards,
-- 
Felix Gu <ustc.gu@gmail.com>

Re: [PATCH] power: sequencing: pcie-m2: Fix device node reference leak in probe

[Bartosz Golaszewski]

On Mon, 02 Mar 2026 22:31:44 +0800, Felix Gu wrote:
> In pwrseq_pcie_m2_probe(), ctx->of_node acquires an explicit reference
> to the device node using of_node_get(), but there is no corresponding
> of_node_put() in the driver's error handling paths or removal.
> 
> Since the ctx is tied to the lifecycle of the platform device, there
> is no need to hold an additional reference to the device's own of_node.
> 
> [...]

Applied, thanks!

[1/1] power: sequencing: pcie-m2: Fix device node reference leak in probe
      https://git.kernel.org/brgl/c/5c3daa5301693d2e5364483a3405649a0fdaed98

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>