From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 140043FFAC5 for ; Mon, 2 Mar 2026 14:31:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461911; cv=none; b=E4loFG9v3x6+cTD4GG2xZY2CsfYoCiyCofBbBBrotLHrbzn9YvB4t82UbUHh1Z+IW4QkJc98MZtmgs6G6b6sTflr4aGQ0w5H0hGBSzD5+4GICFZXSiXgPq2MY1VaXiZnGxiPj2vOrfLjllBm5dDHjR51QxPsyS5Fn3EWkDtKz9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461911; c=relaxed/simple; bh=86Ziz7ZkTNiHbyzLt91Sb1neXW3jX6vu7nzwQeYV+l4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=IhH+C+Py9sznEfef+ZBI2/r+JcWAC24MR00NL3W3SLR/tT6IkTdBIsqSkL1ByxHt+Hharx+NnS+hKjJcjTqLbTlXfXzZMfctAL6TetObjbetKhHFG6aAwxake8oyzKT8vymkQNWKOxyD7OIvSfsxpsUX2oHHgEFhz5W4LuM8B2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZgTBPLvv; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZgTBPLvv" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-826c49b7628so2897282b3a.0 for ; Mon, 02 Mar 2026 06:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772461909; x=1773066709; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=4oQHoRaGFMus9JOapZuHMAdkvhHYxbOgXj0ogty6xog=; b=ZgTBPLvvB/E9c/wpakGx4G4URcVUumaJiCvZ9YuKgOKfTu1TX4kX5G00u21q5n3J6I MgA3/vH7b9ye/FtYcVenFiyokLQYKFi40u0WD86vX8aDT4hulxFqcpcKzS9HatNOPzBX jlM9Xxvnuu8DREThmS/mejHNucOV2KehcgBvj9rISnMdYn/IqqViR0+G49z+fyLLjrCW CUtYUFInX4eQxLWDVuMZUBNO2NCJINLkpnBSa8UDJQeUH35ZJuCKhtgmEhkUgSHE+j3X i03jSDLV0xAPjX7aydn7RsJjrYiJ2CTn9CMKMbM0N0RqW8299LG1Amrst8jdEQpT/5Aj p8ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772461909; x=1773066709; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4oQHoRaGFMus9JOapZuHMAdkvhHYxbOgXj0ogty6xog=; b=mE4IHCEuzFb0+bSfSXqCH04KHrwJKcU7cCngRSBhOCM5rKmwnL4q5v3/Q8zbBW/JGW B0zlWzqXikze3hEwe5TSXd8cB47NYwZj2LPr3yU3ZNvQDugLI2u6R4ANns+3+rbLzMKS //y/ocqgoANFbiKCvfw0nBd+Epkw3gnAnw01zmmMf4244jAcvCFUhtfIb1j5IfjEbm9p Bt+hMa299UotmZTApNau96G5WXS5Ax0fqZLvSw4+x0j9e/eTjBGaLwTfbxyCXJuXE8Fm 3r7Env2+zMUnBSKhPbZS+w2cR27Y9xJ1wnwsgwZ3VxPI4moAGh0ldIM/2qbdWskHzmtc OqhA== X-Forwarded-Encrypted: i=1; AJvYcCUFq5oY7DGFTPp9bd7kviUudHcaufeGx+kcN1TZ4LO31iIw8a7iI6t20pXSxxCiTsaK03iByy+m+WsD/gs=@vger.kernel.org X-Gm-Message-State: AOJu0YwGd00jnP8xdoIqsOqBXMT6adJ2L/ZLQZkNnek9U3AzTIXBKaVO Rv6N0vyp5AqpUVw6FhWmOYUp9pEscjxtvrunc+xoslY1ivb8aBi6E+r9 X-Gm-Gg: ATEYQzx99oL/HdRFd04mqKY08eK53YMfKkbkmJAibA3BPswk5CObmZtxqJKELcOGfx4 TRVK+9FANt+7MdKRP0GdV2gLYfQYtLhQ/AliftX8V7rR2DHD+bLwl0eSTjG7hbNrSHoyBt7HxSz /Gn55UAnLXUpwHeArohhX/w5vi8roEyvVDz+je1QRTYB2I+yxLbNTHB75uHRoRtceoLZ2eCRati lb6UkfE2knuIKqRQeikmXKbo00Ulpm+H2ZRfNOI5ax8YMBKLMjwwgjWA1tkMVCTczwdtrwvsGcB b5oab5g6mNk3Vn/icPOIYMpbr8bytrn4sUJX6ZvBU3Esi8/HuxD5W957l2IExcdmicaRkHOy4Al JUul6bQyM9HXvGdKj99U/lKbGjTsu2MiIyCBtwbhwaUlFx7yEhHoI+e3n+mQATKtl/KdNju8n4H DDs6BGoj6vDosWa5NpSlsxSBOagkKmxfLB7gZ89YQp8lSofHw= X-Received: by 2002:a17:90b:3d4e:b0:359:989f:ab3a with SMTP id 98e67ed59e1d1-359989faddfmr407907a91.30.1772461909339; Mon, 02 Mar 2026 06:31:49 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:4c92:fc5c:54e5:712e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359135ef1d7sm11412355a91.5.2026.03.02.06.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 06:31:48 -0800 (PST) From: Felix Gu Date: Mon, 02 Mar 2026 22:31:44 +0800 Subject: [PATCH] power: sequencing: pcie-m2: Fix device node reference leak in probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260302-m2-v1-1-a6533e18aa69@gmail.com> X-B4-Tracking: v=1; b=H4sIAE+fpWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYwMj3Vwj3TQzY4sUY0tjM2OjVCWgwoKi1LTMCrAh0bG1tQDBAh8mVAA AAA== X-Change-ID: 20260302-m2-f638d393632e To: Manivannan Sadhasivam , Bartosz Golaszewski Cc: Bartosz Golaszewski , Manivannan Sadhasivam , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772461906; l=1302; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=86Ziz7ZkTNiHbyzLt91Sb1neXW3jX6vu7nzwQeYV+l4=; b=zuLSZMTF9biur1Ulrt5Rti0GuKMmowGC/J6f/52NSyh3skq6WPI+2GW69V/u3cI//WyCJp2NS KiLsaD4jwbvAMhDBpynEtND8VlhqB3euXEe0XrCsBc2JJvdAmiDKrU8 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In pwrseq_pcie_m2_probe(), ctx->of_node acquires an explicit reference to the device node using of_node_get(), but there is no corresponding of_node_put() in the driver's error handling paths or removal. Since the ctx is tied to the lifecycle of the platform device, there is no need to hold an additional reference to the device's own of_node. Fixes: 52e7b5bd62ba ("power: sequencing: Add the Power Sequencing driver for the PCIe M.2 connectors") Signed-off-by: Felix Gu --- drivers/power/sequencing/pwrseq-pcie-m2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c index d31a7dd8b35c..dadb4aad9d5d 100644 --- a/drivers/power/sequencing/pwrseq-pcie-m2.c +++ b/drivers/power/sequencing/pwrseq-pcie-m2.c @@ -109,7 +109,7 @@ static int pwrseq_pcie_m2_probe(struct platform_device *pdev) if (!ctx) return -ENOMEM; - ctx->of_node = of_node_get(dev->of_node); + ctx->of_node = dev_of_node(dev); ctx->pdata = device_get_match_data(dev); if (!ctx->pdata) return dev_err_probe(dev, -ENODEV, --- base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 change-id: 20260302-m2-f638d393632e Best regards, -- Felix Gu