* [PATCH] pinctrl: microchip-mssio: Fix missing return in probe
@ 2026-03-02 18:13 Felix Gu
2026-03-02 22:08 ` Conor Dooley
2026-03-03 7:34 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Felix Gu @ 2026-03-02 18:13 UTC (permalink / raw)
To: Conor Dooley, Daire McNamara, Linus Walleij
Cc: linux-riscv, linux-gpio, linux-kernel, Felix Gu
In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an
error message without return, which could lead serious errors.
Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c b/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c
index 3d5ffd6cb14b..15d73ea1028c 100644
--- a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c
+++ b/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c
@@ -686,7 +686,7 @@ static int mpfs_pinctrl_probe(struct platform_device *pdev)
pctrl->regmap = device_node_to_regmap(pdev->dev.parent->of_node);
if (IS_ERR(pctrl->regmap))
- dev_err_probe(dev, PTR_ERR(pctrl->regmap), "Failed to find syscon regmap\n");
+ return dev_err_probe(dev, PTR_ERR(pctrl->regmap), "Failed to find syscon regmap\n");
pctrl->sysreg_regmap = syscon_regmap_lookup_by_compatible("microchip,mpfs-sysreg-scb");
if (IS_ERR(pctrl->sysreg_regmap))
---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260303-mssio-7343495a184f
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: microchip-mssio: Fix missing return in probe
2026-03-02 18:13 [PATCH] pinctrl: microchip-mssio: Fix missing return in probe Felix Gu
@ 2026-03-02 22:08 ` Conor Dooley
2026-03-03 7:34 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2026-03-02 22:08 UTC (permalink / raw)
To: Felix Gu
Cc: Conor Dooley, Daire McNamara, Linus Walleij, linux-riscv,
linux-gpio, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
On Tue, Mar 03, 2026 at 02:13:17AM +0800, Felix Gu wrote:
> In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an
> error message without return, which could lead serious errors.
>
> Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: microchip-mssio: Fix missing return in probe
2026-03-02 18:13 [PATCH] pinctrl: microchip-mssio: Fix missing return in probe Felix Gu
2026-03-02 22:08 ` Conor Dooley
@ 2026-03-03 7:34 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2026-03-03 7:34 UTC (permalink / raw)
To: Felix Gu
Cc: Conor Dooley, Daire McNamara, linux-riscv, linux-gpio,
linux-kernel
On Mon, Mar 2, 2026 at 7:13 PM Felix Gu <ustc.gu@gmail.com> wrote:
> In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an
> error message without return, which could lead serious errors.
>
> Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Patch applied as nonurgent fix.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-03 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-02 18:13 [PATCH] pinctrl: microchip-mssio: Fix missing return in probe Felix Gu
2026-03-02 22:08 ` Conor Dooley
2026-03-03 7:34 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox