From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6119336C9C0; Mon, 2 Mar 2026 12:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772454295; cv=none; b=TD9pabN5H9t/N6Xwhx/ROn+PhQN+IRiLbhgHGrJlj4050xQctgoHiHlPL2raltdVG/G65/UPyD3HYTaCAyry+gyPjCTuwIFpss8Y777jLfBYIqF6fXK2AUuIZUOfd2OEmE92URRAMXKtPbYN5alnOthdAz6JjtnbFwkqDX/pwak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772454295; c=relaxed/simple; bh=x7t/iAkWcnd9QyYdAw+6vUuJizpL9ieaOGsdRW/mZTI=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Plzmmjwo/rkdSWqDPiCNpKpq5/enW0sgvoeIhjIAs7uRGmj+ntrdJ3RQOvGPSzV2978iyH1zEEAU/RbAWWCysC/zy9BY90O90H6Tccr+QCg8Uoy19NOFASmyWuYwT0BZctuCsCmS2T3CxDoan6wo/7MAs+7uSzZXkNPsBRk2ktc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.224.107]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4fPdQT1L9qzHnH7x; Mon, 2 Mar 2026 20:24:01 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id E1AB340584; Mon, 2 Mar 2026 20:24:52 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 2 Mar 2026 12:24:50 +0000 Date: Mon, 2 Mar 2026 12:24:49 +0000 From: Jonathan Cameron To: Herve Codina CC: Andrew Lunn , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , "Geert Uytterhoeven" , Kalle Niemi , Matti Vaittinen , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Frank Li , "Sascha Hauer" , Pengutronix Kernel Team , Fabio Estevam , "Michael Turquette" , Stephen Boyd , "Andi Shyti" , Wolfram Sang , Peter Rosin , "Arnd Bergmann" , Saravana Kannan , "Bjorn Helgaas" , Charles Keepax , Richard Fitzgerald , David Rhodes , "Linus Walleij" , Ulf Hansson , "Mark Brown" , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Davidlohr Bueso , "Dave Jiang" , Alison Schofield , Vishal Verma , "Ira Weiny" , Dan Williams , "Shawn Guo" , Wolfram Sang , , , , , , , , , , , , , , , , Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v5 11/28] cxl/test: Use fw_devlink_set_device() Message-ID: <20260302122449.00006c77@huawei.com> In-Reply-To: <20260227135428.783983-12-herve.codina@bootlin.com> References: <20260227135428.783983-1-herve.codina@bootlin.com> <20260227135428.783983-12-herve.codina@bootlin.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml100009.china.huawei.com (7.191.174.83) To dubpeml500005.china.huawei.com (7.214.145.207) On Fri, 27 Feb 2026 14:54:08 +0100 Herve Codina wrote: > The code set directly fwnode.dev field. >=20 > Use the dedicated fw_devlink_set_device() helper to perform this > operation. >=20 > Signed-off-by: Herve Codina > Reviewed-by: Dave Jiang Reviewed-by: Jonathan Cameron =46rom practical point of view, what path do you expect this to take? Is there urgency to make the change, or does it make more sense to add the helper this cycle and cleanup up the various places it can be used next? > --- > tools/testing/cxl/test/cxl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c > index 3d9107b2661c..7f232a869389 100644 > --- a/tools/testing/cxl/test/cxl.c > +++ b/tools/testing/cxl/test/cxl.c > @@ -1137,7 +1137,7 @@ static void mock_companion(struct acpi_device *adev= , struct device *dev) > device_initialize(&adev->dev); > fwnode_init(&adev->fwnode, NULL); > device_set_node(dev, &adev->fwnode); > - adev->fwnode.dev =3D dev; > + fw_devlink_set_device(&adev->fwnode, dev); > } > =20 > #ifndef SZ_64G