From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 568F636C9D0 for ; Mon, 2 Mar 2026 13:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772459679; cv=none; b=u4QtDScpTOD9E41ozgpa1yoCZOzXCBv1qcjDXQh0kn7Hv6MbyFw1JvKSwGOG8H0S1tgH8OYYwY7rbSJ4+klcrZIZPpHqnoK92eBCq++c0DK6GOoLAhOZlm/ZUJpnKHhf3m3wtkLtX6zf5Qjy6DDREzxEPZpyV7oV56YJzjK0hqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772459679; c=relaxed/simple; bh=Y15bhtnequFOgEIOrSB9q1YZEbvA7e7DAIudtDO6UjU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LyUygaFA4mHj5PzbRWiwy9jglgTC3NoplJ9MsUe6b2LBRVQWswRp78QDuNhT/frSQU24/JB1qU5JW1JBVOby96Tzfbh95Nrt5OAWKCxNOWRWYDgilfAuKL/02xMo/qf9y23WxwPQamJbWRL0JPxcuS5RKwzeyKDJD5NydRqK7yk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Gk+2x/Yb; arc=none smtp.client-ip=95.215.58.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Gk+2x/Yb" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772459676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vbzznQJw+MumjnOEIi239aA3SOQZp6OHaZBJz5H5l7s=; b=Gk+2x/YbaSdnapP+rVQC0V1gd+Zlx4NMaspECFepYJkEHJuexQnC47pjQ7jOLNPZuwq6Ha FkyiRE4PSO7KkFGjsxdysPMollyKFSPMk0vF2+KOojHWuDMt6sA8aiWVQ9vsefGmBoTdHs G5zajNAmAPSREQpPwhcSRLTQFR1yGOc= From: Thorsten Blum To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Thomas Huth Cc: Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH v2] x86/mtrr: Use kstrtoul() in parse_mtrr_spare_reg() Date: Mon, 2 Mar 2026 14:53:40 +0100 Message-ID: <20260302135341.3473-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Replace the deprecated simple_strtoul() [1] with kstrtoul() for parsing the early boot parameter 'mtrr_spare_reg_nr'. simple_strtoul() silently sets 'nr_mtrr_spare_reg = 0' for invalid input instead of rejecting it and keeping the default value. Return kstrtoul() directly to propagate parsing failures instead of treating them as success. Also return -EINVAL when '=' is missing from the boot parameter and 'arg' is NULL. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull [1] Signed-off-by: Thorsten Blum --- Changes in v2: - Return -EINVAL when 'arg' is NULL - Update patch subject and description after feedback from Boris - Link to v1: https://lore.kernel.org/lkml/20251218101026.225019-1-thorsten.blum@linux.dev/ --- arch/x86/kernel/cpu/mtrr/cleanup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/cleanup.c b/arch/x86/kernel/cpu/mtrr/cleanup.c index 763534d77f59..81fc5f109f8e 100644 --- a/arch/x86/kernel/cpu/mtrr/cleanup.c +++ b/arch/x86/kernel/cpu/mtrr/cleanup.c @@ -437,9 +437,9 @@ static unsigned long nr_mtrr_spare_reg __initdata = static int __init parse_mtrr_spare_reg(char *arg) { - if (arg) - nr_mtrr_spare_reg = simple_strtoul(arg, NULL, 0); - return 0; + if (!arg) + return -EINVAL; + return kstrtoul(arg, 0, &nr_mtrr_spare_reg); } early_param("mtrr_spare_reg_nr", parse_mtrr_spare_reg); -- Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4