From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 554293E557A for ; Mon, 2 Mar 2026 14:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461787; cv=none; b=FsLqpp1cZW2zNNq8E1Kco3dGosiwp0fMRbq2UrraG0L6a/YsRAQR4EPbBdZAGr7C+me8MGIELqbppYZFmVaBMj85R4aSlQUX7CIMgCCOuQkH0i0IU4hR2cq+/SpDzO6vPJjXkl6hiW2Livn5CKAlGscbFJ1AGoePtWpYfJb8M0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461787; c=relaxed/simple; bh=eqdCcUzztg9dkFVpWVnXbBGIb5ze2YX8fLD1r9Emzz8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QRKDv+zNR0L6Ah4Zjm6GWdAciibuXcEQ5HqkMp2GR5xthHVEDA8mR8iJ8rhb3s2Sx+36hDK9WVh/SV0bFTLyjYAc8BLjl0IQLzWKXu7qUF2PURfND5wLDyfnwphl8UiNi8O/426lJPRuhVdLLvZ2TeZvaSh42n7C35+YFnFS5WM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YQ09nBsB; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YQ09nBsB" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c70378ddaafso3119727a12.3 for ; Mon, 02 Mar 2026 06:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772461786; x=1773066586; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HXRhGulAtt197gYnJyd1BzBdmELAPmcsmWWQm7dKai8=; b=YQ09nBsBnsqHj4+iBuUXZ8RvqYXXm90wO3RFXS8GECmyJ3ZPih6fqyugk0Oba5cGW2 JxABJkppu+51fsG+WMV2YXuB2Jb9yXqPTtY2uwFKcXtf7srwLC74XbSCos/8Yo0fNU5a H8M8XuSKZ099ZoW/GyRItZLCFEFrqKLKuj2Z+gyjqjT8owOd06izGBU1ORrTj8piDGYE hWExg4rkvChH2LqmlHxe04CI+3ryZ7sHfmeHwoCIuVaYyiCtz9RCfMU0CA+Ie1RZon8I o8CoZwMX4sRjoe3uMgW9FbEzqJ5K6NhPjbQl1MAlFfe3Kh6D4IJ/PFrjj/olpQQsMYi4 Rpng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772461786; x=1773066586; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HXRhGulAtt197gYnJyd1BzBdmELAPmcsmWWQm7dKai8=; b=DqVIP9DQBWysr+1lC8Zfm0ut1vbECZFS7R+mBle6Z80E82UPhi42famnh3RLjaTPoe hl4guhglxW5rn8tkvNjtCaqQ6P0NgoAj8vS/uCsESA2j3GWzIc6QTSqAJTYrOOJ5crm9 n9eUwlxxUVAIKpr6nnzeiBnzznE/WAk8cqYbDh3OJFbeBTN4Vnswvr1VuAgn0OuDWpEh sSEkBSk7Iv3g9ee+6LIPM7PQN/kwzEL5mKDOlriEkUG6VJCTVKo3xMsgolXELHh9llh+ IhF+6ywZscn5LfcBP/2dgsJuMI8XS1aUZoeAB1vOATpIVLyhAOEVJ/lD5zClGOVIl7ix Bgfw== X-Forwarded-Encrypted: i=1; AJvYcCWubdTCHr43gZtH4BYPZoLZqp0juw3u8OMnbB50f8YKzHlm39W+gPKCmjU5ZbQVkBa60s1YoACrTw0nqKk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyif4uwqisWRZKWOo47p9Ar3dz5chzCFzaKEqgMRyr3/vWt+XUm AWDHJyODvOZSSSETT8d15UgTQmALDODWAe8nvTkIQGaMAUQ2UdvPOIJ+ X-Gm-Gg: ATEYQzzM4cpt7WuHFGiKDhIqhEMRyq1m2OU51M6o+urR+k0yuGIWpUNTH4agACIUuUK WVqEXSMt/Q2SO2VLCe+kAdhE9YMJC4McQJokuEbzcdSRBsjnFaaCRX2I2ceGfy8at+F7tbVGj7G 5nuqwBzVdh4BJMJeGC4JqP98vT/zBocZBGZJDuaBrnOcjghD8sn0+qPdGa7w3QOrKz4bvdhTklw eq1+U/59ItZhZ5jSqEVUYSJrheipSNNxco569mN2xIUxJwJnTnzVbW/sEjW56Mfrmb/MAjwZHjd pAELkLQbeqG4uIbqzi0ELcp6YHGVd0j2mo4viACdtYcclno9xjAzSwc6yQKv8vRA36s9+ScjWuS gVCXjwSha1fk4x2F/ggM98FmqNZzNa9NGS8UQbFdN9F2tv2eQ2nIHTpkGyYXmSTAZOAedD921hy dgJdSh0S9a1PIwwYRbISPRXezaGSk7b2sGuVaVMvV58vykq5j/UZDRuSxOHzhyZ8jQ9mPT X-Received: by 2002:a17:90b:2fce:b0:359:8c21:ef51 with SMTP id 98e67ed59e1d1-3598c21f1dfmr3561329a91.4.1772461785578; Mon, 02 Mar 2026 06:29:45 -0800 (PST) Received: from sean-All-Series.. (1-160-230-14.dynamic-ip.hinet.net. [1.160.230.14]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35912fbc363sm11341251a91.2.2026.03.02.06.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 06:29:45 -0800 (PST) From: Sean Chang To: Andy Shevchenko , Andrew Lunn , Nicolas Ferre , Claudiu Beznea Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH] net: macb: use ethtool_sprintf to fill ethtool stats strings Date: Mon, 2 Mar 2026 22:29:31 +0800 Message-Id: <20260302142931.49108-1-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RISC-V toolchain triggers a stringop-truncation warning when using snprintf() with a fixed ETH_GSTRING_LEN (32 bytes) buffer. Convert the driver to use the modern ethtool_sprintf() API from linux/ethtool.h. This removes the need for manual snprintf() and memcpy() calls, handles the 32-byte padding automatically, and simplifies the logic by removing manual pointer arithmetic. Suggested-by: Andrew Lunn Reviewed-by: Andrew Lunn Reviewed-by: Andy Shevchenko Signed-off-by: Sean Chang --- his patch was previously part of a SUNRPC/NFSD series [1], but is now sent as a standalone cleanup as suggested by Andy Shevchenko to avoid cross-subsystem dependencies. [1] https://lore.kernel.org/all/20260301161709.1365975-1-seanwascoding@gmail.com/ drivers/net/ethernet/cadence/macb_main.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 5bc35f651ebd..dadfedd6d799 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3145,7 +3145,6 @@ static int gem_get_sset_count(struct net_device *dev, int sset) static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *p) { - char stat_string[ETH_GSTRING_LEN]; struct macb *bp = netdev_priv(dev); struct macb_queue *queue; unsigned int i; @@ -3158,11 +3157,8 @@ static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *p) ETH_GSTRING_LEN); for (q = 0, queue = bp->queues; q < bp->num_queues; ++q, ++queue) { - for (i = 0; i < QUEUE_STATS_LEN; i++, p += ETH_GSTRING_LEN) { - snprintf(stat_string, ETH_GSTRING_LEN, "q%d_%s", - q, queue_statistics[i].stat_string); - memcpy(p, stat_string, ETH_GSTRING_LEN); - } + for (i = 0; i < QUEUE_STATS_LEN; i++) + ethtool_sprintf(&p, "q%u_%s", q, queue_statistics[i].stat_string); } break; } -- 2.34.1