From: Andrew Davis <afd@ti.com>
To: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, "Andrew Davis" <afd@ti.com>
Subject: [PATCH 2/3] remoteproc: da8xx: Remove unused local struct data
Date: Mon, 2 Mar 2026 13:56:15 -0600 [thread overview]
Message-ID: <20260302195616.312378-2-afd@ti.com> (raw)
In-Reply-To: <20260302195616.312378-1-afd@ti.com>
The member irq is never used and ack_fxn is unneeded as it
is already a part of another member irq_data. Drop those
and their struct docs. While touching the struct docs add
one for dsp_reset which was previously missing.
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/remoteproc/da8xx_remoteproc.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
index 41744f3f0252f..f44bee303eb5e 100644
--- a/drivers/remoteproc/da8xx_remoteproc.c
+++ b/drivers/remoteproc/da8xx_remoteproc.c
@@ -57,11 +57,10 @@ struct da8xx_rproc_mem {
* @mem: internal memory regions data
* @num_mems: number of internal memory regions
* @dsp_clk: placeholder for platform's DSP clk
- * @ack_fxn: chip-specific ack function for ack'ing irq
+ * @dsp_reset: control for local reset
* @irq_data: ack_fxn function parameter
* @chipsig: virt ptr to DSP interrupt registers (CHIPSIG & CHIPSIG_CLR)
* @bootreg: virt ptr to DSP boot address register (HOST1CFG)
- * @irq: irq # used by this instance
*/
struct da8xx_rproc {
struct rproc *rproc;
@@ -69,11 +68,9 @@ struct da8xx_rproc {
int num_mems;
struct clk *dsp_clk;
struct reset_control *dsp_reset;
- void (*ack_fxn)(struct irq_data *data);
struct irq_data *irq_data;
void __iomem *chipsig;
void __iomem *bootreg;
- int irq;
};
/**
@@ -122,7 +119,7 @@ static irqreturn_t da8xx_rproc_callback(int irq, void *p)
* we need to ack it after taking down the level else we'll
* be called again immediately after returning.
*/
- drproc->ack_fxn(drproc->irq_data);
+ drproc->irq_data->chip->irq_ack(drproc->irq_data);
return IRQ_WAKE_THREAD;
}
@@ -320,9 +317,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
drproc->chipsig = chipsig;
drproc->bootreg = bootreg;
- drproc->ack_fxn = irq_data->chip->irq_ack;
drproc->irq_data = irq_data;
- drproc->irq = irq;
ret = devm_rproc_add(dev, rproc);
if (ret)
--
2.39.2
next prev parent reply other threads:[~2026-03-02 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 19:56 [PATCH 1/3] remoteproc: da8xx: Use dev_err_probe() Andrew Davis
2026-03-02 19:56 ` Andrew Davis [this message]
2026-03-02 19:56 ` [PATCH 3/3] remoteproc: da8xx: Reorder resource fetching in probe() Andrew Davis
2026-03-06 17:34 ` [PATCH 1/3] remoteproc: da8xx: Use dev_err_probe() Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302195616.312378-2-afd@ti.com \
--to=afd@ti.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox