From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F6533B951; Mon, 2 Mar 2026 12:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772455870; cv=none; b=HgC2yyrrVSefyfBwtpMztWPpfIvScE3ENszCChuUGcsdhVosYABZ4vDvIKSaCUZo553l6PoAUxopzw6sjmmnoljwjzAK6tUiuR0vWCNEoKTUrbGICWQFuNoeg2r4QMTdr2q9bHunRHdtyhTd/scXDeaTU4cPlReX+Rpks9xQ1Ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772455870; c=relaxed/simple; bh=2V7ncjs7ZIIj3qy+QMQ0qfNSeRmhGsWTDBQ8Fwneykc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Iw4ylJJeZsG9E+7csC7yRSDC+zh+rxq/nqo8+xxBRJN7TwkVJ7gjuBLoneCCa18MwClhJJ3/XoUtXldgT9JLb9kR5WHtS9BMy8DT88119jKy0btPrPNiQCqlzETWY4E+rtiwdusFpbW4SBvAPS7tFM9eV4R6Aili0ULqEEY6Wro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DRUuup/X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DRUuup/X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F32FC19423; Mon, 2 Mar 2026 12:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1772455869; bh=2V7ncjs7ZIIj3qy+QMQ0qfNSeRmhGsWTDBQ8Fwneykc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRUuup/XKK7Qo0QEdlXK8hzxaLV3JQTi7mAIRbQtLGGNwBNahZY235u28xPh0WyrW Dl7Pk3jYM5xjbgl81bzOhCbcoKY9AeGy7J0tUwrU4C6TvmysMcWkAKBYsHTu2zf8Xs F+8HvNReXyIw7nobICJWpJKt/CLdl8RS30jA2g1Y= Date: Mon, 2 Mar 2026 07:50:58 -0500 From: Greg Kroah-Hartman To: Marc Kleine-Budde Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Mailhol , stable Subject: Re: [PATCH] can: usb: etas_es58x: correctly anchor the urb in the read bulk callback Message-ID: <2026030234-sheet-countless-fd2f@gregkh> References: <2026022320-poser-stiffly-9d84@gregkh> <20260302-festive-crane-of-fortitude-d135bc-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302-festive-crane-of-fortitude-d135bc-mkl@pengutronix.de> On Mon, Mar 02, 2026 at 11:01:48AM +0100, Marc Kleine-Budde wrote: > On 23.02.2026 17:39:20, Greg Kroah-Hartman wrote: > > When submitting an urb, that is using the anchor pattern, it needs to be > > anchored before submitting it otherwise it could be leaked if > > usb_kill_anchored_urbs() is called. This logic is correctly done > > elsewhere in the driver, except in the read bulk callback so do that > > here also. > > > > Cc: Vincent Mailhol > > Cc: Marc Kleine-Budde > > Cc: stable > > FYI: checkpatch suggests: > Invalid email format for stable: 'stable ', prefer 'stable@kernel.org' Checkpatch is wrong here, either is just fine. thanks, greg k-h