public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hyunchul Lee <hyc.lee@gmail.com>
To: Viacheslav Dubeyko <slava@dubeyko.com>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Yangtao Li <frank.li@vivo.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	cheol.lee@lge.com
Subject: [PATCH] hfsplus: limit sb_maxbytes to partition size
Date: Tue,  3 Mar 2026 17:28:07 +0900	[thread overview]
Message-ID: <20260303082807.750679-1-hyc.lee@gmail.com> (raw)

s_maxbytes currently is set to MAX_LFS_FILESIZE,
which allows writes beyond the partition size. As a result,
large-offset writes on small partitions can fail late
with ENOSPC.

Set s_maxbytes to the partition size.

With this change, the large-offset writes are rejected
early by `generic_write_check_limit()` with EFBIG.

This patch also fixes generic/268.

Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
---
 fs/hfsplus/super.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
index 7229a8ae89f9..18350abc659b 100644
--- a/fs/hfsplus/super.c
+++ b/fs/hfsplus/super.c
@@ -500,7 +500,8 @@ static int hfsplus_fill_super(struct super_block *sb, struct fs_context *fc)
 
 	/* Set up operations so we can load metadata */
 	sb->s_op = &hfsplus_sops;
-	sb->s_maxbytes = MAX_LFS_FILESIZE;
+	sb->s_maxbytes = (loff_t)min(MAX_LFS_FILESIZE,
+				     (u64)sbi->total_blocks << sbi->alloc_blksz_shift);
 
 	if (!(vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_UNMNT))) {
 		pr_warn("Filesystem was not cleanly unmounted, running fsck.hfsplus is recommended.  mounting read-only.\n");
-- 
2.43.0


             reply	other threads:[~2026-03-03  8:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  8:28 Hyunchul Lee [this message]
2026-03-04 13:08 ` [PATCH] hfsplus: limit sb_maxbytes to partition size Christoph Hellwig
2026-03-04 20:04   ` Viacheslav Dubeyko
2026-03-05  0:29     ` Hyunchul Lee
2026-03-05  0:46       ` Viacheslav Dubeyko
2026-03-05  1:52         ` Hyunchul Lee
2026-03-05 23:21           ` Viacheslav Dubeyko
2026-03-06  0:57             ` Hyunchul Lee
2026-03-06  1:23               ` Viacheslav Dubeyko
2026-03-06  2:05                 ` Hyunchul Lee
2026-03-06 20:08                   ` Viacheslav Dubeyko
2026-03-09  0:52                     ` Hyunchul Lee
2026-03-09 19:47                       ` Viacheslav Dubeyko
2026-03-09 23:25                         ` Hyunchul Lee
2026-03-05 14:27       ` hch
2026-03-06  0:40         ` Hyunchul Lee
2026-03-04 23:49   ` Hyunchul Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260303082807.750679-1-hyc.lee@gmail.com \
    --to=hyc.lee@gmail.com \
    --cc=cheol.lee@lge.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox