From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0CEB48033D for ; Tue, 3 Mar 2026 11:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772537281; cv=none; b=Txf/7kUa/+YR5WSwZ4SB+YKy22gTC0THnhKm45uPfwNy4qeUkYdciYInBHbIFVPaGcQoMEBrXF485I8Him9mUOquJo4JYkIQpHrlWacGIYwr3mvK/DhkYavJYlgZtkUrrKfrAp84Qy1eLFow+IS838kKx/1g/sRb7BXLrxIppk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772537281; c=relaxed/simple; bh=Z7wo6V9kU8iNoyeWICZnYBGx6CgJO1IAkVLA1EldMnk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LH0QTRtlpNTI3+l1ah4QWYjpU3jTe++qG7nfUyiduVOn7FJl05dqR2r/BiBJUA8wwzdFiwNvXufzjTqwF+RjJ7Ae2jjR5aj+VBpBEm2dbgpjC+ezb1SyCGN/vwCCiYr8gHglg3FZ+R/AkTu90Aaj64diYvnp+0tvNxWOSbItj6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e89h1Ted; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e89h1Ted" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4833115090dso57296335e9.3 for ; Tue, 03 Mar 2026 03:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772537276; x=1773142076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bnm1A86ZE9NwpPvFAzmesLCd98LCt5htyJUYGbVOzOI=; b=e89h1TedqS01u/CqV2thI9o7b9xBjDmf3lPODZR4UlLAJoNWdC0q6Rokbz3vdHygL1 eZz+Akn+Pg1O2ffzRkL0vvZKr0Y0mPObzLUZBJG1SqxsseeC5TF/Vi0jcaMsrGxg3/Ct fhtph88fIQyRGq/LwM4UO2lb3vwIRxQ11G8+Ky+ksC3CHuuIIOyiro29MUgWqUAFYUxo 4xh3K9rXcjyxA/kU5yvxLuxAVuuzYhTQGk1HqfHpyj0zL+OFi3wPwn3/W0guxvoL27v/ 2MAzzvwLzKS/Ef8B8UGvYaGAxnoGmshWt2lfWecUbn8RSv3Pl4e0NXRqWi+6+ZE0kjfz DH6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772537276; x=1773142076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Bnm1A86ZE9NwpPvFAzmesLCd98LCt5htyJUYGbVOzOI=; b=Yd5+rj6320b3kxAXbN9q2jyimDc4EcmFS5RiypOYQ8YHLRDRqB8RCB0IR9uv2/YQMp pLL3j57/kCQWhTDgr6Wlo4bUJ0R7BN8EgnL9CIkdIX07rxQ96gfit4Q7zVpG8bdEksRo 2eKWtuauWvUgOYq48Qsns94YxLj+akm0izaPiyzay8pi3JQ0Gx1Unooyf6NYQxvEPCsE O9khDBKlKTJRtmplgrRwDsuvJ5e5i2EOZOLS4yTYTYaUc3FgeiydKl0IlNtcq0NCibZ/ Zjkwipl4MgxFFMbZg1SEFuuJWc2cOSMEwT8h2ikJ1mAipIo0aYYfvc16uKv+/KHi0TRO qLSA== X-Forwarded-Encrypted: i=1; AJvYcCWkjjbrOb3v6zIWKYbgiH5KgYl/4estkdDmAD3fLi7//Atf4YenT74zf9HWO3cF1boWCnozUZoSz/aV/s8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo73verCyYu+Izbev/spZRWol9eN1CS9BJqG+IrJENr9oa7zdX e2au3qnyk2ewzqnzt/y0V8BjqDbblpFQWnyRNyiaSZc+mK++dTWIyFkN X-Gm-Gg: ATEYQzyTbl+4OqvO7GB4xoLa9lhhWgIUD3BZE91kqBbmh72KhQc4WwULGtUwaGVmiIK VJXQ+JM0fyUBro2O3WL2v6M45Xh4Go6/ywNf7YE9PgaiHA+M+2yKEJfQCi79lx7YbmmI/FQnJ8M gySRz0sk/qpfSQDGkWrhprKKzKpZ6Hy3XuHCGZEXLeq/AYrTNtrD8G5Df6qD3Kbscv6OdGxkSbs ed6bNnRIExStY1taGHVs7ICvwIFQ9qlDwCh5r8GwJEJnhwxbVEENSSEy6wDpe63CSFlyDQG0qbS CgpS1XN1ud7wRBxVSZ+IZBE8XvqUFWoFqANWR6zj+IRrZLZ+9LGzQi1T1dUKO4tAG1oGpV0iqDL tQ/EZtNO9GjtAYyaU7nR7SW/9N3P1ViwG6RQ9K5AVWpgk7bPcygY+Ot+z08MGHHfPZLvfpolzdA == X-Received: by 2002:a05:600c:8b12:b0:483:71f7:2794 with SMTP id 5b1f17b1804b1-483c9bbbe39mr288394345e9.15.1772537275524; Tue, 03 Mar 2026 03:27:55 -0800 (PST) Received: from kimsufi.. ([2001:41d0:303:6f54::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851262ee4asm22629685e9.1.2026.03.03.03.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 03:27:54 -0800 (PST) From: Ruslan Valiyev To: syzbot+1f5bcc7c919ec578777a@syzkaller.appspotmail.com, "Daniel W . S . Almeida" , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzkaller-bugs@googlegroups.com, Ruslan Valiyev Subject: [PATCH] media: vidtv: fix NULL pointer dereference in vidtv_channel_pmt_match_sections Date: Tue, 3 Mar 2026 11:27:54 +0000 Message-ID: <20260303112754.340155-1-linuxoid@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <69539037.050a0220.329c0f.052f.GAE@google.com> References: <69539037.050a0220.329c0f.052f.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit syzbot reported a general protection fault in vidtv_psi_desc_assign [1]. vidtv_psi_pmt_stream_init() can return NULL on memory allocation failure, but vidtv_channel_pmt_match_sections() does not check for this. When tail is NULL, the subsequent call to vidtv_psi_desc_assign(&tail->descriptor, desc) dereferences a NULL pointer offset, causing a general protection fault. Add a NULL check after vidtv_psi_pmt_stream_init(). On failure, clean up the already-allocated stream chain and return. [1] Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN PTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] RIP: 0010:vidtv_psi_desc_assign+0x24/0x90 drivers/media/test-drivers/vidtv/vidtv_psi.c:629 Call Trace: vidtv_channel_pmt_match_sections drivers/media/test-drivers/vidtv/vidtv_channel.c:349 [inline] vidtv_channel_si_init+0x1445/0x1a50 drivers/media/test-drivers/vidtv/vidtv_channel.c:479 vidtv_mux_init+0x526/0xbe0 drivers/media/test-drivers/vidtv/vidtv_mux.c:519 vidtv_start_streaming drivers/media/test-drivers/vidtv/vidtv_bridge.c:194 [inline] vidtv_start_feed+0x33e/0x4d0 drivers/media/test-drivers/vidtv/vidtv_bridge.c:239 Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver") Cc: stable@vger.kernel.org Reported-by: syzbot+1f5bcc7c919ec578777a@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=1f5bcc7c919ec578777a Signed-off-by: Ruslan Valiyev --- drivers/media/test-drivers/vidtv/vidtv_channel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/test-drivers/vidtv/vidtv_channel.c b/drivers/media/test-drivers/vidtv/vidtv_channel.c index da20657adc747..5f8c3af871711 100644 --- a/drivers/media/test-drivers/vidtv/vidtv_channel.c +++ b/drivers/media/test-drivers/vidtv/vidtv_channel.c @@ -341,6 +341,10 @@ vidtv_channel_pmt_match_sections(struct vidtv_channel *channels, tail = vidtv_psi_pmt_stream_init(tail, s->type, e_pid); + if (!tail) { + vidtv_psi_pmt_stream_destroy(head); + return; + } if (!head) head = tail; -- 2.43.0