From: Simon Horman <horms@kernel.org>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] net: dsa: yt921x: Return early for failed MIB read
Date: Tue, 3 Mar 2026 11:34:56 +0000 [thread overview]
Message-ID: <20260303113456.GB71509@kernel.org> (raw)
In-Reply-To: <20260227135057.2730254-2-mmyangfl@gmail.com>
On Fri, Feb 27, 2026 at 09:50:53PM +0800, David Yang wrote:
> This is a prerequisite for another patch. It does not change the
> behavior on the success path.
I think that you need to discuss what change this introduces
on the error path. And the AI generated review did too.
Looking a bit more, it seems that Jakub offered feedback on
this in his review of v1 [1]. I do see that the commit message
has been updated. And is strictly correct. But I think the intention
of Jakub's feedback was that the behaviour is changed should be described.
[1] https://lore.kernel.org/netdev/20260205050813.2421675-1-kuba@kernel.org/
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
--
pw-bot: changes-requested.
next prev parent reply other threads:[~2026-03-03 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 13:50 [PATCH net-next v3 0/2] net: dsa: yt921x: Use u64_stats_t for MIB stats David Yang
2026-02-27 13:50 ` [PATCH net-next v3 1/2] net: dsa: yt921x: Return early for failed MIB read David Yang
2026-03-03 11:34 ` Simon Horman [this message]
2026-02-27 13:50 ` [PATCH net-next v3 2/2] net: dsa: yt921x: Use u64_stats_t for MIB stats David Yang
2026-03-03 11:31 ` Simon Horman
2026-03-03 11:40 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303113456.GB71509@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox