From: Thomas Gleixner <tglx@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Dmitry Ilvokhin <d@ilvokhin.com>,
Neil Horman <nhorman@tuxdriver.com>
Subject: [patch 13/14] [RFC] genirq/proc: Provide architecture specific binary statistics
Date: Wed, 04 Mar 2026 19:56:24 +0100 [thread overview]
Message-ID: <20260303154548.840416557@kernel.org> (raw)
In-Reply-To: 20260303150539.513068586@kernel.org
Provide a binary statistics interface similar to the per device and per CPU
interfaces to access the architecture specific interrupt statistics.
The architecture has to select it in Kconfig and provide an accessor to the
per CPU interrupt information and the number of architecture specific
entries.
The entries are ordered by a numerical index starting from 0, which
corresponds to the ordering of those interrupts in /proc/interrupt. The
output format is the same as for the per device and per CPU interfaces and
only contains entries which have an interrupt count > 0.
Reading the architecture specific counters of a 256 CPU x86 system takes
36us kernel time for 6 interrupts with non-zero counts and produces about
10k of data.
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
---
kernel/irq/Kconfig | 3 ++
kernel/irq/proc.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 59 insertions(+)
--- a/kernel/irq/Kconfig
+++ b/kernel/irq/Kconfig
@@ -18,6 +18,9 @@ config GENERIC_IRQ_SHOW
config GENERIC_IRQ_SHOW_LEVEL
bool
+config GENERIC_IRQ_STATS_ARCH
+ bool
+
config GENERIC_IRQ_STATS_PERCPU
bool
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -945,6 +945,61 @@ static __init void irq_pcp_stats_init(vo
static inline void irq_pcp_stats_init(void) { }
#endif /* !CONFIG_GENERIC_IRQ_STATS_PERCPU */
+#ifdef CONFIG_GENERIC_IRQ_STATS_ARCH
+static inline void arch_stat_update_one(struct irq_proc_stat *s)
+{
+ struct irq_proc_stat_data *d = s->data;
+ unsigned int cpu, idx = s->irqnr;
+
+ for_each_online_cpu(cpu) {
+ struct irq_proc_stat_cpu pcpu = {
+ .cpu = cpu,
+ .cnt = arch_get_irq_stat(cpu, idx),
+ };
+
+ if (pcpu.cnt)
+ d->pcpu[d->entries++] = pcpu;
+ }
+
+ if (d->entries) {
+ d->irqnr = idx;
+ s->count = sizeof(*d) + d->entries * sizeof(*d->pcpu);
+ }
+}
+
+static __always_inline bool arch_stat_next_data(struct irq_proc_stat *s)
+{
+ if (unlikely(s->first)) {
+ s->irqnr = 0;
+ s->first = false;
+ }
+
+ for(; !s->count && s->irqnr < ARCH_IRQ_STATS_NUM_IRQS; s->irqnr++)
+ arch_stat_update_one(s);
+ return !!s->count;
+}
+
+static ssize_t irq_arch_stats_read(struct kiocb *iocb, struct iov_iter *iter)
+{
+ return __irq_stats_read(iocb, iter, arch_stat_next_data);
+}
+
+static const struct proc_ops irq_arch_stat_ops = {
+ .proc_flags = PROC_ENTRY_PERMANENT,
+ .proc_open = irq_stats_open,
+ .proc_release = irq_stats_release,
+ .proc_read_iter = irq_arch_stats_read,
+ .proc_lseek = irq_stats_llseek,
+};
+
+static __init void irq_arch_stats_init(void)
+{
+ proc_create("arch_stats", 0, root_irq_dir, &irq_arch_stat_ops);
+}
+#else /* CONFIG_GENERIC_IRQ_STATS_ARCH */
+static inline void irq_arch_stats_init(void) { }
+#endif /* !CONFIG_GENERIC_IRQ_STATS_ARCH */
+
static int __init irq_proc_init(void)
{
proc_create_seq("interrupts", 0, NULL, &irq_seq_ops);
@@ -953,6 +1008,7 @@ static int __init irq_proc_init(void)
proc_create("device_stats", 0, root_irq_dir, &irq_dev_stat_ops);
irq_pcp_stats_init();
+ irq_arch_stats_init();
return 0;
}
fs_initcall(irq_proc_init);
next prev parent reply other threads:[~2026-03-04 18:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 18:55 [patch 00/14] genirq: Improve /proc/interrupts for real and add a binary interface Thomas Gleixner
2026-03-04 18:55 ` [patch 01/14] x86/irq: Optimize interrupts decimals printing Thomas Gleixner
2026-03-04 18:55 ` [patch 02/14] genirq/proc: Avoid formatting zero counts in /proc/interrupts Thomas Gleixner
2026-03-09 15:59 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 03/14] genirq/proc: Utilize irq_desc::tot_count to avoid evaluation Thomas Gleixner
2026-03-09 16:04 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 04/14] x86/irq: Make irqstats array based Thomas Gleixner
2026-03-04 22:18 ` Michael Kelley
2026-03-05 15:52 ` Thomas Gleixner
2026-03-09 18:12 ` Dmitry Ilvokhin
2026-03-10 10:15 ` Thomas Gleixner
2026-03-04 18:55 ` [patch 05/14] genirq: Expose nr_irqs in core code Thomas Gleixner
2026-03-09 18:26 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 06/14] genirq: Cache the condition for /proc/interrupts exposure Thomas Gleixner
2026-03-16 18:46 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 07/14] genirq: Calculate precision only when required Thomas Gleixner
2026-03-16 18:57 ` Dmitry Ilvokhin
2026-03-04 18:56 ` [patch 08/14] genirq: Add rcuref count to struct irq_desc Thomas Gleixner
2026-03-04 18:56 ` [patch 09/14] genirq: Expose irq_find_desc_at_or_after() in core code Thomas Gleixner
2026-03-04 18:56 ` [patch 10/14] genirq/proc: Speed up /proc/interrupts iteration Thomas Gleixner
2026-03-04 18:56 ` [patch 11/14] [RFC] genirq: Cache target CPU for single CPU affinities Thomas Gleixner
2026-03-04 18:56 ` [patch 12/14] [RFC] genirq/proc: Provide binary statistic interface Thomas Gleixner
2026-03-04 18:56 ` Thomas Gleixner [this message]
2026-03-04 18:56 ` [patch 14/14] [RFC] x86/irq: Hook up architecture specific stats Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303154548.840416557@kernel.org \
--to=tglx@kernel.org \
--cc=d@ilvokhin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox