From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27A1376499 for ; Wed, 4 Mar 2026 04:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772597945; cv=none; b=eRXxZdU9plFOm+7ZYMTnc4Att8tyPJO4kjAyjJQKtgYMLR6vBq3rPHJGoNsSX20CwlyUUD5LI7Y24h8LbK15S474TuBgwPRXIb/heMuctJIT5wp2bVe/qBeEMgpHLbIbKoqdp2gl/WYQ/hstaJb/nZsMdqgDqKjzkzep202kctM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772597945; c=relaxed/simple; bh=tVuA+tPAo4/bBKbHQc+OgPhHzgNXg3xW2vrAE9dGuds=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GBixhmsw/6vDS81R6177BG6Qx8DzgDTPQo48blB0RXoE3s5vkzX+wFwK59AYswAIOAvQ9x1K1JKxc6seX9NNJiQtGtoM49fXcR14YcOtgLmVjAQAU9wDJEJC39J/4A/1J5iUJUuVVLSzNtjrL/4cb2780HyMa2srnDsrBEh7Uc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FaZwWQbi; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FaZwWQbi" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-79801df3e21so59774057b3.2 for ; Tue, 03 Mar 2026 20:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772597943; x=1773202743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e3J4SJFkd0Yz/4xyMUebZW0UW2z89TjGNLD0gGCcfR0=; b=FaZwWQbiXYNSzfL9GwVbIOVE5i5m/vYBIFDNNioFVqImerGd4aBH0WSXQOVg4zfF1V INTzN20Z/geuyK5Hr6sEHNaLTmECZoOI2rkTM0MaKyKHUPbdjfrTVmiNow/kUqRzGMMg KsWk/FgNeWmAXKkg/QLiQihIojzG+FqR/a5w5pQC2pqsIzuww/kkM/Peh4VgvnBxGOOJ 1cwriay8HO91y6yRkHYSDCW1C8rblXUrhgG1engzNQknz0cYWAE7xiWeZJby55Xmrqli vXCJwMM8LtLCM/nHZ5CQNdo6dAyqEYOdLxVp5JPDkzcTQRTC8m2NA5vNGUyOQ08Tk+Kq 560g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772597943; x=1773202743; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e3J4SJFkd0Yz/4xyMUebZW0UW2z89TjGNLD0gGCcfR0=; b=ZqBzQPlPYe261+TPPof78pBmu5fvazgs+nEqNhoZXwg40DUDPnOOMLb8YAkwjMmz7h eEX1Sf+awM4YffGUrW9r+8up1nv4DjkToqBLEh4qrzTlJKa3Mje4THLfpnJW1hp7VyVu letKSJiE5VmQZs50KKXVLd9AK4wyt7EvhwHGD+0UriGCMV63MEOELsxcFs6vX+ZyXplX EbITAcmlmXGRq5yn3e01iDIqXumCqgtP+BxQSQiSPw4yROKY/uvotkriNksbQKhqTsAG 62W+1O4EbLQPGmGiro8kU0xMT8fLD715WpQ3GE0+CU0z+a0GJ1Gn0UrT7SRpjwd3a7Mf fqqQ== X-Forwarded-Encrypted: i=1; AJvYcCWc25KtDlBIZFhDNgmru81fS3dsXZe79XpIM9C8tDeJFStAPc+5WN21ij2PvP34SHFQuccEhE+f8XWR35Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxgkKwfYX0dyNsqMyfG03HrZz+7B7J28Ed2qH20wAgAdYiX8jB9 tS5pAF7sgUbXLqswGtRvdlZilEhdCIp+u2H+RQVpawYC+lOv6+P103yM X-Gm-Gg: ATEYQzx0GtHQdMRlCZ6ECxqfA+JWdVlXSj4VIkG8DEzbf4siaFQkQxsnhD9xaIz5O13 nlRtHNO4zzrHNcOfgnn5Y9HKw+jz0qQNJS4fmDUg2oKfu7eW0SrOGzh2Mh/5b2lOisaXqgQmp3R 1Gwxbu0p0hyK2Yjp6NWRXLp0E0rvn/BDxl4fDe8Lavmw1axPZwpPOtNHT9xu0LBAHsUZUNeWBs4 LMIQNYhZ2XxviE57lj4NJu/WXcsUMfI9Ric0/Qthpi8MaxRC5pTTKR/eCG9MDOWyhBiwcUguHpq SwmB/WmTRuePUsOu0rggeKvFzfN5ti0g0SFmTmQufrrPqFdh3nK93M5Q+GNdXGFE5N9w9qtJw8v 2LBDTTSR45arAQnZYY5hvq2SE1AL2vluNcy3EEwVXBv54ZfTSTdp6ImfvEM/87kfe1ZDUpi+qy+ HFYB6vA2m3UvJ5ONi1HBgvOJAPgD3bgYe5om+Lu1NaOiJcjxi26oTtkI+B4NQk5z5Z X-Received: by 2002:a05:690c:c513:b0:796:3236:7e2d with SMTP id 00721157ae682-798c6be0a5emr6473207b3.15.1772597942730; Tue, 03 Mar 2026 20:19:02 -0800 (PST) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876a8db33sm71465357b3.4.2026.03.03.20.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 20:19:02 -0800 (PST) From: Rosen Penev To: linux-iio@vger.kernel.org Cc: Eugen Hristev , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Microchip (AT91) SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] iio: adc: at91-sama5d2_adc: no devm for nvmem_cell_get Date: Tue, 3 Mar 2026 20:18:43 -0800 Message-ID: <20260304041843.7709-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is absolutely no reason to pospone cleanup of this post driver removal. Just do it immediately. Signed-off-by: Rosen Penev --- drivers/iio/adc/at91-sama5d2_adc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 69bb49434f90..255970b2e747 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -2259,7 +2259,7 @@ static int at91_adc_temp_sensor_init(struct at91_adc_state *st, return 0; /* Get the calibration data from NVMEM. */ - temp_calib = devm_nvmem_cell_get(dev, "temperature_calib"); + temp_calib = nvmem_cell_get(dev, "temperature_calib"); if (IS_ERR(temp_calib)) { ret = PTR_ERR(temp_calib); if (ret != -ENOENT) @@ -2268,6 +2268,7 @@ static int at91_adc_temp_sensor_init(struct at91_adc_state *st, } buf = nvmem_cell_read(temp_calib, &len); + nvmem_cell_put(temp_calib); if (IS_ERR(buf)) { dev_err(dev, "Failed to read calibration data!\n"); return PTR_ERR(buf); -- 2.53.0