From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D96E539478D for ; Wed, 4 Mar 2026 08:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613975; cv=none; b=bzIoeQFKy4eAIjkc2Puq/jL+h4FgllGf1WGaHwcm7r0+S4IxmvKFduBUMOlmgAZI5wD+rdESSJTroVUtVpWpYGSSjrahrYyqGJm26ynewXdaYaDIDvQv6JlrjrnB5VI3TL4KvTV8VU5gD/DCioxYTvRhP4njYyk06UrC3NcmssE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613975; c=relaxed/simple; bh=ch9Bjf3rYYQFZ3B+gWt24r/KcnGxHyK/TdO8+vbOhlU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZY2ChjbM+z5ePjpuaeGFoRFd8bj83MGIHzi8/WKQ/pVDi+kBB7xZA6iRWzu1MnWOlfF6AknVQnByyPRP+AjnR0bQCr9C40kcXJrtwCNWuGO1RjDXJPxgvkQZ+zUn6XRnKVKtuAqgb0uhch0P82G+lwAHhL1bUzcfMvmpHmwSEIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dRsAwE/B; arc=none smtp.client-ip=209.85.215.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dRsAwE/B" Received: by mail-pg1-f196.google.com with SMTP id 41be03b00d2f7-c73770b3f15so116729a12.2 for ; Wed, 04 Mar 2026 00:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772613972; x=1773218772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ntj2ZFCjKKBGx8d4Pk8uGSO7QWDo31vg+Q85kRhTYF4=; b=dRsAwE/Bu+CHc9Ff6N87USgYCEVQ/4pkRF16NWK+TojYpCQ+LBzuVF/sZbDV7No5Hl n6fmy/p8MxB9TymrbFJ/+jJnJTmAWnZ144556plJQJn1EyLTOzlbsdsDdlnqoL/qU6u8 2KqzgVjJkzqvC4UNa9YGGWf4qW3DK/jt3PciQ9ZWi2OqOdrRyi0S2bTNlTQ9IsUourJf tSCfnphAr3q/3IzG7Zzh3dgWGM0+eooCN8DmWyQWEmDB77xI+hkRtooGHoLTseY+60Tx 29SHWGFhjjS/V/ZmBTGD2V5L0Zr2t6ut06ZR77QY6SRu8V1wtvkgZcGKBGGk/ZJ+RnWB hAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772613972; x=1773218772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ntj2ZFCjKKBGx8d4Pk8uGSO7QWDo31vg+Q85kRhTYF4=; b=XBK/ZTdY4Ip9qahLKghDFRQdUIKdCGMgpSXzd2+5M1xzXvLaPmMsBJauM5obhYc0w7 YiCTpMGksZmctI1smbsP8XBda3qqvgwaNbtTIUiRyWgEeDSunjyZtXxfjUwmqoj44vAV jyvhIONT3lGPjp6tTUSAryqPF8BFK/tg1fgU/Z0zClMrp9RaYOajkWERmQPpWvG/IBPv ZcwZqY2hwFblAxkyDobJXQ3E1SoVMt9zs9lI4TddS/lPBbv/86wjCtvQtWRfzOnJaSdN t6X4085/M9IN8CiLy89yTenX9lwaoLlxOe9V5O8Y6O/Pf7/Ct+1OOSFXnQq+4PlEmJAv hqVA== X-Forwarded-Encrypted: i=1; AJvYcCUczWDMs26k6dYouJnU50n9PIVVPlpK6kSH6jMWd9Vgqn6PiDilT1wv43clr5G8AaWHujbXhr9/i4eT5aM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2z8TRLPQp8ga12sa2+7XYcxLYf4/91S0GMbylXoAzstfrZ209 AeAKppoaGloNwbVbRTHagyCoyOZHT116cE3Jlotg1YjeTfbN2unL3rBe X-Gm-Gg: ATEYQzy9xwSF7NE42c8VLBSWEhwGTDUbZ8zTGpc0wTl/QP0KoAqNxCzUWsgqNMi88jZ nvRrqPWckHrSGomYTNN9vOTB9Q+7q0LPc6Y0jnrxw2uN5DZugpehL4r1m87c2QqM5UQsQlU7iOW 6x+uaAVVtXOCIzRrg0rvu1bbjimPOvw3Xgpv5a3LX8yF80xl7TnpeLDsTKahyHeEaTTT1p0x9BQ GWfUdzTgU1zkRbEGLof9x4LfeJUJH+PBkoAaF+hjadz2fLBxzH5YqoFlSn7Ty3QWjnz/Ocllm1O faXwO8CMigWEV48lcOBW7UNU7ZUIb5l0xu/RJjYwvhd6dvV/4V+ThtHR5NX6nc73XiFhSos2owD rWKd7RodKlltt8LNt2o4TG4X+0lNCxmNrrYCAcRScyACSghErGOcO0H5b4dmBpbSH1BtVje79ZR YdjDLkHR+nEca6FwvbzQ584DV2GZiWU6wrhrWx7a5CAaq3jB0Ga1/0+QUCyImH6blrxMU6PTdI0 MyjGb9wr6yujPc= X-Received: by 2002:a17:902:d50f:b0:2ae:59e0:5127 with SMTP id d9443c01a7336-2ae6ab51eeamr11142715ad.3.1772613972063; Wed, 04 Mar 2026 00:46:12 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c5esm122010285ad.6.2026.03.04.00.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:46:11 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 4/6] staging: sm750fb: sm750_hw_imageblit: propagate de_wait() error Date: Wed, 4 Mar 2026 14:15:43 +0530 Message-Id: <20260304084545.156170-5-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304084545.156170-1-officialsohamkute@gmail.com> References: <20260304084545.156170-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Propagate the error from accel->de_wait() instead of returning -1. The caller treats all non-zero return values as failure. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/sm750_accel.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index f2fde011e7ca..7d11810864ae 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -325,15 +325,16 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, unsigned int ulBytesRemain; unsigned int de_ctrl = 0; unsigned char ajRemain[4]; - int i, j; + int i, j, ret; startBit &= 7; /* Just make sure the start bit is within legal range */ ulBytesPerScan = (width + startBit + 7) / 8; ul4BytesPerScan = ulBytesPerScan & ~3; ulBytesRemain = ulBytesPerScan & 3; - if (accel->de_wait() != 0) - return -1; + ret = accel->de_wait(); + if (ret) + return ret; /* * 2D Source Base. -- 2.34.1