From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5ABD388399 for ; Wed, 4 Mar 2026 08:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613982; cv=none; b=QULHRHL/XZ0DANg3mqxffLK9ujprgIJx5bIuWBkz748zwvPFh2sqHW6bbeaUVOxBvg9UAqzsoxyLWBgN44h1wtYhweLwOZY3+S1vx89+dX8FF8jey/9toqmlDsdMosQeBz3aZJBTHXVZiQHDc7+cmGwpS/YPH65f54G3R6MS3Gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613982; c=relaxed/simple; bh=NjIHanfcZCN7Q8bPlLToej7iNBvOlqyNwUhyWxKm2yQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FVNfoMLuNbrSf1oS7/WjzyPRkKczgWycKRHPsIrJ8K3tp42G73urM9MvHjonhLX+aZmdnn06zkRkpeBYBdMq+XFZGuZTaMZNawR0G+KEf8z5u6WYKn8JtgQUpLy3PXQd2ON5cLlzN0hBtcN24/h3C4RBaz45RVPEamtjAkEy4uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GD+X9K0I; arc=none smtp.client-ip=209.85.215.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GD+X9K0I" Received: by mail-pg1-f193.google.com with SMTP id 41be03b00d2f7-c7382963b67so25687a12.0 for ; Wed, 04 Mar 2026 00:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772613981; x=1773218781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q4Tsr0TiaAL9EgCXS3kDx+w3w2NKKVy8Enr91haZmsQ=; b=GD+X9K0I6Sv8qPDaWsAwEtRUJQx3PtLe0zojOAcXxC/EBcJR6gWO6pGKt2q7p+pRVc ViFtBPkkRypkiRy0LEb77kvjt36tZ6TWFAM3GA9Hwgg8znj/kuZOGIRVn0FzXqmakbEK P2pFxysOHTZ6sbh+YXCfaGCBTyRWse5gXzYLyT1od8R499zU/IBUgiuUir+XhpMG63Kw GcfSCawUPiMMLUQ9H8uRfIyg+cc8lpU9vdBi8E8cfcP6QY5yq0Dhi1/QKm4kfgmAfinO t7zlQph5KmXDp87AYG/SmesI5rjmb0wqX3qtQBobhaD9c9ZeNkx8ClJcmXpvEm+/sgPu txpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772613981; x=1773218781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q4Tsr0TiaAL9EgCXS3kDx+w3w2NKKVy8Enr91haZmsQ=; b=Pmri8HthU5QWpxR98sQDA0w1FtFUFQ9foQHS5K9MdQq9iclAiMIJq4DMSfrTEuDGsf DVShE0KsLP5WfAA2cdf0FC57hQ+s55zXKBeIq2T8D2X8awopOkC0Zj3ohTMmgyakcQk6 Zf5D96J0geVhJ/KPP6h8Z0rYCmp4elF/Codt/Yy0hxb097XjGkWClk3ChULqBKKwLDI5 mGXM24+OssDGLpgpWgr7kTpXOD5htEc8i4LMcNoqK1HveE2eZKpCQTymA8WyEU9M3UY9 +DaXbcXYO+PxAOKNLOPvrVPjREQtgmv4fdyxas+AuPv0BE+eg6IlfIvF5/A0jg7keaHq QEjA== X-Forwarded-Encrypted: i=1; AJvYcCUn1x3pwQHjAdwiAlt6QuR9zCOT8HSfyGksrUc4QE6yUjVxSL3YlkGj1i+g4+/OtuVTVwXPu171ZYJeETI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7ER6Ww7HSUHd6ptn4dGpCFn8o0ESOHBx7fH9wfXmuPqAUD2tj tskE5x2H6hWxp7TGslP4KDZAGoiXO5DDyymm8uKcgWleZ3eWE1W1s4l3 X-Gm-Gg: ATEYQzytkJDl0gC3+A3EuI3VvEflwO1igNcgyDccMQr1LiVBsm2aPFI/ePaPzu2VCsG +Fu2p+ZWoz9tNYmXo+nD0lprpz+6pXKA2JufFAJ3Jgo5bFwpoRtqMmcUhuhfyhFhPB5n7b0GEn4 /4N3RJWa1Q2yKHtQRFliJQdHvCuZj4pwVP0NyvFVdyrC5Hnpp5hh9Qb6TkbPFj3llNdQv4P/Qyi P0YX8ICFcDgehLALZ6kyRjzlm/LRhVWEZZU4m4YSps/9G0/jqwnwSTupW7FvqKQ+J/2KxF1V3vO mHpnwGjo32FONPYppsmqy8S1jjxIpeneu7jhLunLQV3BDqlgLLJiM+4F3vQUCJsAephD9m6TXup jlQVyn351ocDSsnsQ76ijLpyanMunbxLT48lHiY6g43mawkTcwpItyUsY0+akwmDuJ5GmUrS/NE Kr38Ryhbeyt/bBwUCvbSLYbv1AzASWfvmVRMb6NgNSsrCHWGmdcYVJeuUjSvLD+TN89BGd7hNGz 5ksFJ6+KlaVRsk= X-Received: by 2002:a17:903:2c50:b0:2a9:5b48:2b1f with SMTP id d9443c01a7336-2ae6a89797fmr10736535ad.0.1772613981282; Wed, 04 Mar 2026 00:46:21 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c5esm122010285ad.6.2026.03.04.00.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:46:21 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 6/6] staging: sm750fb: sm750_sw_i2c_init: return -EINVAL for invalid GPIO Date: Wed, 4 Mar 2026 14:15:45 +0530 Message-Id: <20260304084545.156170-7-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304084545.156170-1-officialsohamkute@gmail.com> References: <20260304084545.156170-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Return -EINVAL instead of -1 when the GPIO pin number is out of range. The caller checks for non-zero return value as failure. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/ddk750_swi2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c index a17f758dda6c..d90a93ab8fdc 100644 --- a/drivers/staging/sm750fb/ddk750_swi2c.c +++ b/drivers/staging/sm750fb/ddk750_swi2c.c @@ -394,7 +394,7 @@ long sm750_sw_i2c_init(unsigned char clk_gpio, unsigned char data_gpio) * range is only from [0..63] */ if ((clk_gpio > 31) || (data_gpio > 31)) - return -1; + return -EINVAL; if (sm750_get_chip_type() == SM750LE) return sm750le_i2c_init(clk_gpio, data_gpio); -- 2.34.1