Re: [PATCH v3] usb: core: remove unnecessary goto in usb_create_newid_files()

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Mar 04, 2026 at 07:58:12AM -0800, Mark Adamenko wrote:
> The goto to 'exit' only returns the already initialized variable
> 'error', which would be 0. At that point it could not yet be anything
> else. Replacing with an early return 0 removes the
> need for the label entirely.

Odd text wrapping :(

> 
> Signed-off-by: Mark Adamenko <marusik.adamenko@gmail.com>
> ---
> v3: fix missing return statement at end of function
> ---

You forgot the other versions listed here :(

>  drivers/usb/core/driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

But first, why?  There's no real need for this change, why make it at
all?  It follows the "standard" way of jumping to the end of the
function to exit.  What tool asked you to make this change?

thanks,

greg k-h