From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FB543C6A30 for ; Wed, 4 Mar 2026 17:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772645742; cv=none; b=qipgPVm+gbp47PT8Q44Poie88RaP0N4AMpCW7gAopC4NuY8kZRp+JhAuqBdyKKdO38Z2hU2NI+J2L6szaDUzWg6rFRXhdPydEbZKKpZccj7EbekZbL+9+cdK8AsWTN9uky2ZZAJWX3XwwQLuQWXhAu/QFE1Az26VFh0T9X03mNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772645742; c=relaxed/simple; bh=26HnA6jr8Gpj2ARL5WF/0FOSAJ8I03Q+Uhhb0MqsB6w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kKaNu7V9oePtsvMBWHLrAkMQemCSlAeFKsqq+1cbomHFQwcWouL9M8GuRAX7QE6AUpZ+GPyi/j3GO7XfphdaYKXrwh8SVSBSqNmnPF1qjnax7/Ygs1aGrHAxTriEjCKHtiH9uHsfG9oXI0qjEUm9lcBTu96QcTOHBPR+uEigNtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i5oQiTIN; arc=none smtp.client-ip=209.85.215.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i5oQiTIN" Received: by mail-pg1-f194.google.com with SMTP id 41be03b00d2f7-c6de5ea6879so207506a12.0 for ; Wed, 04 Mar 2026 09:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772645741; x=1773250541; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q74EyZl/rBv7dMbdQMZD34TxKD7igp3TSZElWe8rZoE=; b=i5oQiTINKEbMkOdaj8tUz1X+afjmWrhxEUNBvYDC+5dCnjNsne4VI8qyFbxISLlkpn EBgQdj24CWSywyxjHWLWRzaEGQUQfhHE/CbGD2bHt/TOCXs0HUe/9YmTWS+/jbhnyhj8 XI/NNdq0TiyX3PyCaU5iQFj/fkKxtFLkTK4HNQFcX3IlMQanUZKYs6ZLFp5bIy70TDKQ Fhgp2vkwo96FJijv2GzQeXqt5oKngOT/DU1mHetgQ0Z7n3xz8Y6SbMl+4TnqkDzp9haE TnPg/OP2RfJrP2PP1Dv76qpSfAANu0Tl+szDBzTTSBhwe55sOx2J1A8Un7opDJVDn5Ur e++Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772645741; x=1773250541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q74EyZl/rBv7dMbdQMZD34TxKD7igp3TSZElWe8rZoE=; b=kOjd+fTcRKtSNqPSPk8XBOFGlXsCy4BbPtxo+5pOnDY4UcmtTCQr/jvMh4Ap5z3rMC Hu9QZhcI3ZVJ852pHm31wUoG82Wxx7yvWgIvwQr0hk8emKz6tVLNoJG1i8eHLu6JffSE W54y5FlsmtUAIN+J2YvJHnMP6hg0po2huQqRbwZpHP4QpQ6nr8ffFogEXL7syjX9THxa cgPEpykbu8VR/wDue8JfHOoh52sx0Q+Ybq82Mx61NERsWYt7+8nFYgakadXgfESXHIYA fNyt4pplwjZHVvVSYu8AfovoWcDNFrrzYyMct+luFkWpPIqIAzRK8dGNAJ6J+GO1N+WB uGRA== X-Forwarded-Encrypted: i=1; AJvYcCUJAspw4280FcoJh347yXsD5mvDkTQKlzQQ2OmDeN/Bd/vZwN1zqz4rwPOrU0hHuJqj1TV9nXBNhgNQpLQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxIujW43UShD/6tgLBUbnVkR64H65PMzriVSWKSDflp7vc8BL9k qys4s0VE6Q3z8koxwObkAXTswq3NbWk/naumIZFqBXKFCvjppDHlMtQL X-Gm-Gg: ATEYQzwoO58BiZ2PB/lA0UJ2BhQuMD5nDLsXD7xBugBPoWpP+TrPDoSLaqyGdq+YCV1 bz/50NlvbgNVuheRHzrVEpr1GNxpm5oSGWS30Zo2LOZQS8VLIUdO6mPgUby8zgWtwXC2DoC13PA qPhmIVvPSSL9zazmq1p0J3KoD8wZpsDNZCS0HXLADFcqAWH4H1J3DsdCuGKkULKFHRP1O4rIpvM MJ3m18Hi/QhPfxeUx/1+TLutpmc6AToG0cKHr6EzmJXFbjBGBQkis7hNK980AZBCDjBIv7N4OgO /+vfT71DnRlG3UjOf1dtd80cv+KM/LJ6q96XMrVWvmY01GJldDcO9Zx3Gbn8TwxS0l3bEsCSbOp zyRAmkwb0kS4c45vjTiP8yipBHSe2jOQTQd9kCY8CZNwz/3rZuXxKgflGwrBO0kKNjPtwiPTfkg rPKk8BuXYHIcSxLpX3feccn/Anqiw0/fVRhPtagZATLC0hHDWWMhWqSOKDstDcM6ptZgSh1yveB 2styw74uJDjZ3A= X-Received: by 2002:a17:903:2443:b0:2ae:5127:3d55 with SMTP id d9443c01a7336-2ae6ab18e06mr18985915ad.5.1772645740630; Wed, 04 Mar 2026 09:35:40 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae4bbdec99sm136901955ad.64.2026.03.04.09.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 09:35:40 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 2/6] staging: sm750fb: sm750_hw_fillrect: propagate de_wait() error Date: Wed, 4 Mar 2026 23:05:25 +0530 Message-Id: <20260304173529.192067-2-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304173529.192067-1-officialsohamkute@gmail.com> References: <20260304173529.192067-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Propagate the error from accel->de_wait() instead of returning -1. The caller treats all non-zero return values as failure. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/sm750_accel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 046b9282b24a..1bd0502db039 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -90,14 +90,12 @@ int sm750_hw_fillrect(struct lynx_accel *accel, u32 color, u32 rop) { u32 de_ctrl; + int ret; - if (accel->de_wait() != 0) { - /* - * int time wait and always busy,seems hardware - * got something error - */ + ret = accel->de_wait(); + if (ret) { pr_debug("De engine always busy\n"); - return -1; + return ret; } write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ -- 2.34.1