From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67683C6A57 for ; Wed, 4 Mar 2026 17:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772645747; cv=none; b=F/YgxTwuOM3fWdANTQviJg4vhmjZFRDl7lp6jiVXUUdGSktYtugEvtl9es3/bwH6qFd2RCAgiiwkfFzY/Klj0F5mOMXMOQat6g7XVP6/y9I0qID/S/pmIkhlJx9qLTyvdLP9DcM8OriB9T04ccJEvEAl3roTJXS8pKn36Mk3U6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772645747; c=relaxed/simple; bh=eaqazZEu6AIkOZfqaVPRfpOH5D/Sw2xabAJId3jlXWQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Y4lpq8HkQGY86IuVTsw06Xhjg5gjJIUL1+6jSa0eNyDLPNkc6OKf0l22/YefcZs4Ig0my9Sg4NG0DZDAr6kLCuqFL95W+8Vdwqfe8R96ctlwmpLniV2EKY4rAk4k+I+KEGj3YZNx6aTVcG0xeoY4ml7fvWOWfDnTay6wqkXJM9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jXB47+BL; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jXB47+BL" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-2a9633ef0d6so9229965ad.0 for ; Wed, 04 Mar 2026 09:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772645745; x=1773250545; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T7JS5lz1a9Kx2ju5Yxda3ptoEB7aeLh91gAm/wQ+ud4=; b=jXB47+BLFvCvw3ITFjxiwEqe49TlKICQ/D1Wgvd7UPXf36juzOBUnZrw4e8sK0pvzi IcX1IzFADrKWynw1QVF55qyXY4UYlHSlz3ldo/VLC2BIK+56LOG1QYkrkdLazqFzF4dA lCZ1wCF+kURk3yxoFasMsbQsk3tiESrp2jyOlIy8gRAhXLxkmBI6pbTECc7LxpIFANUY KrY+JOX55xHzvMCisg6JzDuojMxflDf0IW87cdcBkIUYa9TrbMaNEbLXgA+tj1ovLv34 BZn7Y8bphQEhrCBOZa0HabPGIPEPvqzmCB3Bvccw3Q7HtcS+7kXO54myZaZ1dpgrYXEM vNGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772645745; x=1773250545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T7JS5lz1a9Kx2ju5Yxda3ptoEB7aeLh91gAm/wQ+ud4=; b=Qkx/l/yM8t8mekxDRidb1NC8ftfniuaMDo0+XdO1eOIAiALZDsfKTUXCTokQHQOQlm PDBcT3pBXO8zPUHkqe8M5U7xL0cNxHUopiUPXCBZE3zGycE4zaYE1JhWDDpzKga1We7i iyVpUEx2xbVFsIfPizJowsj7s29ObuL62KWFePNpLmuZZZ6ZmVF4Dlz6QYtP5I+RvROc KAHKMNCky5K+g/XAh+/k6Cap8EGRMwivF8qxzk/cV16u8wWjt1fReuqQ5Epg1KVCA5DD dMi4/MsZn0zgpjYwz8m7nBgSarY8N+GJSDij/krXdZR7brh3S2Gc2OwfwQIkN1izeyFQ NIHw== X-Forwarded-Encrypted: i=1; AJvYcCUPf9JyGyxD83H6/1H52BSzwC8Oi+lOdC06b48YiMlOaZehIAsI3Q9SNZtL0cogQn5mAy41dpg0v60XJmY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5c9XZGypyW1XiyJ/wP+QqZrpWJYwz5jvgWK7lSREzGHGmcrca 0srxST42vEZhDmnnqQlgmdCk6tqSxfZqYT4tOOR/iZJHq/6vKUewxugF7UMPk4POUJE= X-Gm-Gg: ATEYQzxD6MyUKm58E5W4f7aEldk0e9HKoIwYcqNSUKwIt/fPBJ8LS2sL8ICwr/TL7KY ZHN8NmMACE2ngPVZurmdvxZnjeofXQNG0xS3LeVHqGWr7KwaKJQ7Ucp9v/J/QgkolK4iFxkW005 Vtmu7EsbOkd1gQTll+x/zguF9Se2cQbhysFXrmsUeuk8AsBTBs5Z0YMTQkI3rVIK/yPHQsQhoT7 gQ0Jsrfd2khMKyz3IXwZNjPfnArBBOAN4zse1rnj64Ej898oCdCyBwrkB05PEb2l7LfS7myZeNn yY059lV5VU6ywi0Rk+Ji/PUWXXSXNJ0GZNZkNw5meokjOdvOdvyDqbhQ9qFAusm4AboU8xwd1NX J6wnBJgsloTyLHMKpzNlBNvffKTbh3Se57uzMuMUxkdMJA86yCnH86+1zVPKW+EkMYNpXoNPZIV YfuDN81L31SrGk9d9J+1DNiQlSXkmSE3n11dMRjTjZxqK7EMqM3isWcC1UcjcCOKF7YtPAUXvq1 JiPXpXBC7YO/Bk= X-Received: by 2002:a17:903:2c47:b0:2ae:3c43:b9ef with SMTP id d9443c01a7336-2ae6a9daa93mr17831215ad.2.1772645745110; Wed, 04 Mar 2026 09:35:45 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae4bbdec99sm136901955ad.64.2026.03.04.09.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 09:35:44 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 3/6] staging: sm750fb: sm750_hw_copyarea: propagate de_wait() error Date: Wed, 4 Mar 2026 23:05:26 +0530 Message-Id: <20260304173529.192067-3-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304173529.192067-1-officialsohamkute@gmail.com> References: <20260304173529.192067-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Propagate the error from accel->de_wait() instead of returning -1. The caller ignores the return value. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/sm750_accel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 1bd0502db039..f2fde011e7ca 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -152,6 +152,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int rop2) { unsigned int nDirection, de_ctrl; + int ret; nDirection = LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 = Left to Right, (-1) = Right to Left */ @@ -261,8 +262,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, DE_WINDOW_WIDTH_DST_MASK) | (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ - if (accel->de_wait() != 0) - return -1; + ret = accel->de_wait(); + if (ret) + return ret; write_dpr(accel, DE_SOURCE, ((sx << DE_SOURCE_X_K1_SHIFT) & DE_SOURCE_X_K1_MASK) | -- 2.34.1