From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D50A3CB2ED for ; Wed, 4 Mar 2026 17:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772645752; cv=none; b=XYrTfsAXEF/HCBzYOaynk0BSKj671H76zJv1M0H1ThbG3yd0+a6akEtbD/6/y+6U34ON1csMOO1Z4Nfpb8I9K3LjbhGQFJwEht8Hge6rKw7ZoPURG6m2hSelaGdbtG/6Iv3tz33mlVegU/RMiVmJ1cb8cYwEzM+oEqnERr+JEe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772645752; c=relaxed/simple; bh=ZPfxzik31T03EgSdWiRyC5YG5TXWyYF8Ds6MnhvfdYE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PDU0htoKQM5L83vcP2bNFbn8WqfITBpUBszpZGPVHOsX0tP5LUx1NAlZG4evYpiy4TmoD1DEYXeN2/73dWWSf+2uOD2LHwSXQ9g01FlQ3w4wYwfZGiL6cp98Op4fXeMLD2VgPC70/pLie/lH2wBSLY+eRN6zmjnfJhsjXYJBohI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aeIV7yg1; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aeIV7yg1" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-824b621ef8aso393908b3a.1 for ; Wed, 04 Mar 2026 09:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772645750; x=1773250550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9FKWt4Ue46a5Jtl3J8WxKsJ5o7nZVt2UhiVFWoT7/Ts=; b=aeIV7yg1QefRSo3KRn2DKFLPwT15f/0qP3iM7Rvb+P2qGVL+EZ+yhLLNtebG/kjzxd qUW3bKJIP3jRMt/IWTbXeMhwoCnEOAtVW/lGysFnwgfH4z+1FvWrQfBzXiQQcAjan5vf 61Iewl55EXNSjKvjUolr6tQc2XGb1DHZ20y3SjvNuR7eOIWnAd1fuvyKVfLQisnA/J6w FIAYvSH/TXFIKV26lLHgSS3bEok9v0SNm12V5O4oxoCm54yIFQjk8OV0JTN3O+Y+bebt PJt6tkOQz+FONX/nR49eXSDlX2ROj36f54HfLZ8fZOeAXFZNVMmMcPrvmYJWmm2PGYx3 3fHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772645750; x=1773250550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9FKWt4Ue46a5Jtl3J8WxKsJ5o7nZVt2UhiVFWoT7/Ts=; b=BwAFhbA/zc+ZmIiuPjxRZHaMmCSmARId3EsSAKTeb5M0f9e0ldkYwyf99DsjOwapDa Nk2AFl9Q1GWTFWSXV/2UjUNlY7zt1hL/E8grMl3rw9k2oscNe9uHjXtz2JDqblNPNRy3 DlySz/SeaTPa8VciIdrYG/dPENoEeugQ2/G/K3OaaGysDL6fyzeR4sDugZs2iodKd40P 8SoZcPk2NKdd1RCOvUuL41OafJipAWxVlYrDbUIzl3mi/OQA2Gu+zDSJl/Mitb1pHb5m 7Skd6VkF9+N7eqFDPP9t671nE0aDHGgHf0S54WzN6gSJo/RR5FvLKed/AfwjMxYtTVU+ vWVQ== X-Forwarded-Encrypted: i=1; AJvYcCULXGu5qitFwFX09is581cxczrGjUrlhsGaIN3D9fwuKcCAFJrnsrDLes8sR0t/eUPqe9AkGp6qzfeSsCA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1w1QCL6/gwq5jZh5PDXUzfAvh8CF9ZX1df8KYMScSJly8ypEI SQb/00qe3KbPlCP4TdG5j1cat60vWLFTjVjkPxFDNU5sJrtXhM4IEMWu X-Gm-Gg: ATEYQzwZVkfERhSqk/brDfaqd/GrxXW4r1KOYA0kqGJkHfwvaMmPGJRT6/xYrA81gsu 193RfzM3gYJ6w1rNlAnQmy3bqF5Adndgf9Wj1aWwEwwF12kGUkbOOMyiCt1eRaZ7/xRmHOnEWG0 KDJbCMkSeOMHH+dpmR3tEtdf/hGJZUiPhuH9vluLP3eq5DvFmzVGrKlqz3gj818WI2bibtASDlN BIsG7aZ1nSfSoT3zLA9W/T4belYaMDlcrCv+bFvXX8u2nkuhUzMqHdyPNidLFIbONIEJlDhGWpS 2AVHPJDNT0RWoHtPZX3ozYJXK4rwaissbPuykbk+ZOVVcA0fn145mDWdcdcKkySAeEEumHB5u0U mFJWmZ7lURaaCLz1ZJVHgDA8MNnorCUYrxHZKLAhUj02HcIRCJ8fmp/24/ADfq7SabM6d4zDp56 lWtRNtatO3KpJ9kW04EcmB4o1XaZIqqbyTJ/JstQPrTz2hXCqEdWOBvQaI4wZfdR052mUsut8/T 1jx0znr70QUtQE= X-Received: by 2002:a17:903:38c8:b0:2ae:4cfa:7e3 with SMTP id d9443c01a7336-2ae6a9ed66bmr22732905ad.1.1772645749686; Wed, 04 Mar 2026 09:35:49 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae4bbdec99sm136901955ad.64.2026.03.04.09.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 09:35:49 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 4/6] staging: sm750fb: sm750_hw_imageblit: propagate de_wait() error Date: Wed, 4 Mar 2026 23:05:27 +0530 Message-Id: <20260304173529.192067-4-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304173529.192067-1-officialsohamkute@gmail.com> References: <20260304173529.192067-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Propagate the error from accel->de_wait() instead of returning -1. The caller ignores the return value. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/sm750_accel.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index f2fde011e7ca..7d11810864ae 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -325,15 +325,16 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, unsigned int ulBytesRemain; unsigned int de_ctrl = 0; unsigned char ajRemain[4]; - int i, j; + int i, j, ret; startBit &= 7; /* Just make sure the start bit is within legal range */ ulBytesPerScan = (width + startBit + 7) / 8; ul4BytesPerScan = ulBytesPerScan & ~3; ulBytesRemain = ulBytesPerScan & 3; - if (accel->de_wait() != 0) - return -1; + ret = accel->de_wait(); + if (ret) + return ret; /* * 2D Source Base. -- 2.34.1