From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 531CF3CB2F2 for ; Wed, 4 Mar 2026 17:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772645757; cv=none; b=LVU2jUcAFkhtCdImifNsu050X7M5CSMHL1rRznNo9c3JwswGsXxTWrTWSF8dtzYJBYpRrUdB/hqJjIAqOgBJxcuETtQVwII9fKtsRHbvEF94TgypixjNgLdmgKLtU/MnJDh+sY8a4VmzyVpEYeIhEIvshLWBXLyRa8pUhwW6/cM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772645757; c=relaxed/simple; bh=NrewVoy+CeJ4LUS2omlQWrWteEd+0dreb3Su0BiNHn0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qip3i6qCsXsizKorKLGwaJmPZpBdVNr6nQtZpoobyRvaBGhJdgTUZjVAtbALeZVyTQdrGfFVSZKNF3lUBq3GN+ubfsWZeqwXsgiX8jH5e7Vdyd1Js9scBfMkljcmanXlkpoOxJfk4auNSHI8abjdZ78voVZbOSHm75/ZXWBnMd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cOyLHzC8; arc=none smtp.client-ip=209.85.216.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cOyLHzC8" Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-3597a2fc2beso254339a91.1 for ; Wed, 04 Mar 2026 09:35:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772645753; x=1773250553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5kueakoTFarHtmRefKHO97IsjKUAic56lekSnI1LQXA=; b=cOyLHzC8JKnqPJFSc5ROSFpLI4jLKktnN8Uhd+WBrWUp1BPDp2+3UqLKb+SxhCH3RU O7x4r+JwCiY8o6OK0BAl/A7OhY77xW/Ju4Evley10EdeuCSV2FNwKpl9exzqbqFhNm8U sEMZGyIBt2IPmQ1C8abH+OdJWfO1uJVLXgnYPMvTCGfCUaIea+5yvE5oUIy5l0VrRgzp dUI8IMPTBUF1DWayBAasH20A/+7Pmtmi2alycu9kBwRuwCxOcmoWBv62q//VmzwvqrUT XsgIDevgVwgm78V4ecYHgpGggBA5HhV0VmNzXTK9OD2vvZ74fKHROPkjVu1zYfY6KZQl 9g1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772645753; x=1773250553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5kueakoTFarHtmRefKHO97IsjKUAic56lekSnI1LQXA=; b=JKF78Q98nD+yoh7g4dt9vfEuodgEXL1vCIzJLaHjc2BjSqis4sjqJYkLCfEIWsNUKr kRB68TOub3NfASuy+wT53M3/ZENq+FzkjpgELa3znvDWdyiOTo7cKD0S9R7h6DLbPZuv ih+IY2FhsZRhetcoxMeTPdwv1srxWGh10tSizDjq5sW0LO8DpXKE0Gi2LddfL8VqFPIQ +f+f6L1H2HSisTsl37U1sFzauYdYbBSyLzIFebEnZB2swCMP3uj3HVjRISW5vZ+UkAdc tRxVcGzXYqrIas5+SFZL1h//0pbolGOaluPGBmulf+iwnTGLjbg4jfEmJQmfsO5tcUm0 mDaw== X-Forwarded-Encrypted: i=1; AJvYcCVg6mgSKBbTysfV2TJe93tgJljqCX+oshSy0Ie5lxSbf2m0qUC8yDl7Ex+bp2KIf8y4KRzuJh971YlN8ok=@vger.kernel.org X-Gm-Message-State: AOJu0YwO7ApG5uf+fGMwVzf8Hak2LypZshYeBrc6znhoROYoAE+JG/3G ztWWX8/WTRHFA3Cw5E5oauyPHSQpfe94+uwqxD3V9bntvL/Fzb0Il8gT X-Gm-Gg: ATEYQzzqypmt5GUhUcj7GQI7OJ9utfedJF+hzsOXgoQa5XemesevIeBG2SEEyQi9dVc TZ+jVu420dltfB1XJGeIekBNYEWsjkrpzYa8I6pkgKv/h5OKfzcMJ/8tLKvONcAVFSrqKgWup2C B3IhyafvdwTKic15yF3WGGt9QphsbxGNNGISNdeJRyu0EYAT+wi2LrfXml/Zg+oGeDJK+d9STg3 PEYZDljk1ZZea0BZDOz6M9YnLTLdN/vnbKDqUCO3JH8OvMZIyblcZgDOQYEpRHVyQr7jifN3S9O z3/3rrvZqXUhV8hJpy3SpQ40vg0sw8QltM+rh6vyHu+jgVXfndj1asDAzI6b2tjKWJN9O5bPi52 uZ1VOxtiIXOxM0p3dso8qVuT2IQTtZHRaZkIuR52TRrl6NbFvZtQuq6+xfaXw+loVxmRa4h8PDp IWNyScCXadMONdzuxmQfmrbi3OBlGElMrKCM9Q5u6yuYVhY0jeMox4xHJjEXh9+Dm6XqigUuoq2 arD5H9h5BFf60tGmeAZ4wmJgQ== X-Received: by 2002:a17:90b:3fcd:b0:359:7b9a:2cf2 with SMTP id 98e67ed59e1d1-359a688f6femr1869151a91.0.1772645753531; Wed, 04 Mar 2026 09:35:53 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae4bbdec99sm136901955ad.64.2026.03.04.09.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 09:35:53 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 5/6] staging: sm750fb: sw_i2c_write_byte: return -EIO on failure Date: Wed, 4 Mar 2026 23:05:28 +0530 Message-Id: <20260304173529.192067-5-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304173529.192067-1-officialsohamkute@gmail.com> References: <20260304173529.192067-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Return -EIO instead of -1 when the I2C byte write fails. The caller ignores the return value. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/ddk750_swi2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c index 0ef8d4ff2ef9..c73943341f66 100644 --- a/drivers/staging/sm750fb/ddk750_swi2c.c +++ b/drivers/staging/sm750fb/ddk750_swi2c.c @@ -239,7 +239,7 @@ static void sw_i2c_stop(void) * * Return Value: * 0 - Success - * -1 - Fail to write byte + * -EIO - Fail to write byte */ static long sw_i2c_write_byte(unsigned char data) { @@ -294,7 +294,7 @@ static long sw_i2c_write_byte(unsigned char data) if (i < 0xff) return 0; else - return -1; + return -EIO; } /* -- 2.34.1