From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: mani@kernel.org, kwilczynski@kernel.org
Cc: kishon@kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: [PATCH 1/2] PCI: endpoint: Print the EPF name in the error log of pci_epf_make()
Date: Thu, 5 Mar 2026 12:42:34 +0530 [thread overview]
Message-ID: <20260305071236.23792-1-mani@kernel.org> (raw)
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Merely printing the error log without the actual EPF name will not give
much clue to the users about the failure. Hence, print the EPF name also.
Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
drivers/pci/endpoint/pci-ep-cfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index 076d115db02b..a19db22b7991 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -625,7 +625,8 @@ static struct config_group *pci_epf_make(struct config_group *group,
epf = pci_epf_create(epf_name);
if (IS_ERR(epf)) {
err = PTR_ERR(epf);
- pr_err("failed to create endpoint function device: %d\n", err);
+ pr_err("failed to create endpoint function device (%s): %d\n",
+ epf_name, err);
goto free_name;
}
--
2.51.0
next reply other threads:[~2026-03-05 7:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 7:12 Manivannan Sadhasivam [this message]
2026-03-05 7:12 ` [PATCH 2/2] PCI: endpoint: Improve error messages Manivannan Sadhasivam
2026-03-06 11:55 ` ALOK TIWARI
2026-03-26 17:08 ` Manivannan Sadhasivam
2026-03-26 17:04 ` [PATCH 1/2] PCI: endpoint: Print the EPF name in the error log of pci_epf_make() Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305071236.23792-1-mani@kernel.org \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox