From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: mani@kernel.org, kwilczynski@kernel.org
Cc: kishon@kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Subject: [PATCH 2/2] PCI: endpoint: Improve error messages
Date: Thu, 5 Mar 2026 12:42:35 +0530 [thread overview]
Message-ID: <20260305071236.23792-2-mani@kernel.org> (raw)
In-Reply-To: <20260305071236.23792-1-mani@kernel.org>
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Include errno in the error prints and also use dev_err() where applicable.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
drivers/pci/endpoint/pci-ep-cfs.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index a19db22b7991..2d2efd444b02 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -565,7 +565,8 @@ static void pci_ep_cfs_add_type_group(struct pci_epf_group *epf_group)
if (IS_ERR(group)) {
dev_err(&epf_group->epf->dev,
- "failed to create epf type specific attributes\n");
+ "failed to create epf type specific attributes: %d\n",
+ (int)PTR_ERR(group));
return;
}
@@ -578,13 +579,17 @@ static void pci_epf_cfs_add_sub_groups(struct pci_epf_group *epf_group)
group = pci_ep_cfs_add_primary_group(epf_group);
if (IS_ERR(group)) {
- pr_err("failed to create 'primary' EPC interface\n");
+ dev_err(&epf_group->epf->dev,
+ "failed to create 'primary' EPC interface: %d\n",
+ (int)PTR_ERR(group));
return;
}
group = pci_ep_cfs_add_secondary_group(epf_group);
if (IS_ERR(group)) {
- pr_err("failed to create 'secondary' EPC interface\n");
+ dev_err(&epf_group->epf->dev,
+ "failed to create 'secondary' EPC interface: %d\n",
+ (int)PTR_ERR(group));
return;
}
@@ -675,8 +680,8 @@ struct config_group *pci_ep_cfs_add_epf_group(const char *name)
group = configfs_register_default_group(functions_group, name,
&pci_epf_group_type);
if (IS_ERR(group))
- pr_err("failed to register configfs group for %s function\n",
- name);
+ pr_err("failed to register configfs group for %s function: %d\n",
+ name, (int)PTR_ERR(group));
return group;
}
--
2.51.0
next prev parent reply other threads:[~2026-03-05 7:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 7:12 [PATCH 1/2] PCI: endpoint: Print the EPF name in the error log of pci_epf_make() Manivannan Sadhasivam
2026-03-05 7:12 ` Manivannan Sadhasivam [this message]
2026-03-06 11:55 ` [PATCH 2/2] PCI: endpoint: Improve error messages ALOK TIWARI
2026-03-26 17:08 ` Manivannan Sadhasivam
2026-03-26 17:04 ` [PATCH 1/2] PCI: endpoint: Print the EPF name in the error log of pci_epf_make() Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305071236.23792-2-mani@kernel.org \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox