From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5161237F018 for ; Thu, 5 Mar 2026 10:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772705968; cv=none; b=g5EA4NV8PWezSCFgbYKDeIM/2i8QDW66/WQQ/aQQHXy7AfFGJxGQqJ88tXmXEfHVZNAryulDsm7Ewyj/n3guMnvQe8FdQtsKAC9khMe8QOaMNouxasuYQjOcbgUozE2XXbw0DUcPbVU9nwBnikg95lUHXl8xj7dx+FSFnHE5NK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772705968; c=relaxed/simple; bh=3BgC+3tspTPcNiUbBhv+YYUPNouNOqfwkVDg6AxXl9w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=siGMRE3i9xPu8FiyVRNY5eMIDaDflK4Xycuvuq9oz0JaS/uJv4vlQzEJyll6Fa+lCvT60tldQyQO8sCHf1AFzPNwC/O1bs+ztx3uQlsKgIppSogaUkUjFCczMxf7/n9xYM7IRjo+jvMZZ1oix+iaUC/HMA/ZZuHW2t1pZv/dEZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hkHcxDFW; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hkHcxDFW" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4830f029407so14304615e9.2 for ; Thu, 05 Mar 2026 02:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772705966; x=1773310766; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MEt2GXYapCF4HiN9XPn9MG/e3QqGItA80CPWlLUgqns=; b=hkHcxDFWL2nOjL+vG92Y32u2AW0LcGgcbNI6kFvXyX0KOn7z0hYrt3GH7R56EvyXJw TOlnNrYebE02rRNAPGUb2EAxr3KiheKp++wF33A77Uhf81EPJvq+lNQuM3PhyG2rm6lK EiexH2IV6afsYpOql2D81WZloZkM/0HEvE8XFYvbJlj2s1zsNm/dRGOUX0QS2izdDGZ7 5XYTDqVpEFmke0x+zLkcGOumZDH/b74HkBeVsnHmzjb4qvx0AgEWOUnZRxtc4W0ETE7U LgKPcdLvMvXZMvMSkppkfG5a82BvTr+SCAQT9/iuf5MmOl1gyltcpVl7CukmzPG8x3dW FjWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772705966; x=1773310766; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MEt2GXYapCF4HiN9XPn9MG/e3QqGItA80CPWlLUgqns=; b=Uy9sC52ywlqFIhgPjpnKrgnRe2cJXINeQiNGN3VKd3GuSn+fEZJpyx57qGFoymV21D /O0Pdx20/DRc8aEnd3ldR1woYWsrtoMtbS+24hc7MzHgdkyK+5j5gntISAKVa16M4h8X JaL6kApSYQFXu29n8mxWikbI3zJ3bR4SzFbe+16qB4wPZD2+qLLPEegwxIl0NypYCxYf vPYOmQpPd3jsR5qlXAw8+oM5kSTTXdC6HO0Xan3mSt0OivaowqO23ato4mV3xJ4Qh210 H4Lon/OY6LRpmzAf4bD7AXocX+Tf30T7HYe5oPlN8AeG/c2mECgq4s0xeVM8JqxFXlz8 Ic4g== X-Forwarded-Encrypted: i=1; AJvYcCWDmOovLpN9K+6wa6QDDdjDj/aBfyW4cShBQSIaelv1gp9dbqKJgRlQfhgW6/TT6IWiDS5qbLgAXt4YFZ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyypy2Esf//DRWlPMoSpUowAB46zO/989yvf1Py2WWgPJ6dxT7v xoxPQbOvFTtutCIQ+0bEb/j6o6pwTAyQQdwYI0g43CRCdkHvMb9K2msE X-Gm-Gg: ATEYQzzwcfqKaopkqdfyxqyqC+0uSdAM6kDiKIjuUsmJN761Pnq+uVfKOIjbmcRa6qE boM/YEHYsWltnW0GywO2TV1QSoTKR7Lj2SRLQDOJXnj3N2zzYoQhKu+9OE9gJuBY2Y9MI7NS3QD n1aF+tTTdyWGxEhgqRwdhx0V5e7iljaMLM9tAZRzLObeKtwl5oFQGtJWz+X2Lc2Bd1gghbgWvdr 6hrsX59rNGjuIFr+mCC8ML+7f+iWF/0tqQOTv8x7FINOzcDV30dQJJOYkQBlxAGU+TKmWbrT9t9 h7QB42MhIVfEmq5BFHEc+f/PYldipKLGqQB4I8Qt4cBHv3heEznzsMlSJVj3aj6L+9hvXsGoYnR ClXvblGF+759Xkh5pgBQm2cBSilXciN8QnIzCdxU9AOalFU8Il2tGa1rF7FycBS5SCRA4dVqxUH 6YCtJ5qavcO7hC6Kg= X-Received: by 2002:a05:600c:8b32:b0:483:7d93:9f8a with SMTP id 5b1f17b1804b1-4851982c755mr53275245e9.1.1772705965528; Thu, 05 Mar 2026 02:19:25 -0800 (PST) Received: from skbuf ([2a02:2f04:d00e:3600:16aa:c9ad:4288:9dcc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fa87e56sm32969995e9.0.2026.03.05.02.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 02:19:24 -0800 (PST) Date: Thu, 5 Mar 2026 12:19:22 +0200 From: Vladimir Oltean To: "Bastien Curutchet (Schneider Electric)" Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Simon Horman , Pascal Eberhard , =?utf-8?Q?Miqu=C3=A8l?= Raynal , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v6 4/9] net: dsa: microchip: Add support for KSZ8463's PTP interrupts Message-ID: <20260305101922.lmkbooqfoeeg3axy@skbuf> References: <20260304-ksz8463-ptp-v6-0-3f4c47954c71@bootlin.com> <20260304-ksz8463-ptp-v6-0-3f4c47954c71@bootlin.com> <20260304-ksz8463-ptp-v6-4-3f4c47954c71@bootlin.com> <20260304-ksz8463-ptp-v6-4-3f4c47954c71@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260304-ksz8463-ptp-v6-4-3f4c47954c71@bootlin.com> <20260304-ksz8463-ptp-v6-4-3f4c47954c71@bootlin.com> On Wed, Mar 04, 2026 at 11:18:55AM +0100, Bastien Curutchet (Schneider Electric) wrote: > +void ksz8463_ptp_irq_free(struct dsa_switch *ds) > +{ > + struct ksz_device *dev = ds->priv; > + struct ksz_port *port1 = &dev->ports[0]; > + struct ksz_port *port2 = &dev->ports[1]; > + struct ksz_irq *ptpirq = &port1->ptpirq; > + > + ksz8463_ptp_port_irq_teardown(port1); > + ksz8463_ptp_port_irq_teardown(port2); > + free_irq(ptpirq->irq_num, ptpirq); > + irq_domain_remove(ptpirq->domain); > +} Teardown in the exact reverse order of ksz8463_ptp_irq_setup(), please (port1 vs port2). Place them next to each other so it's more obvious.