From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B45D9346FA5 for ; Thu, 5 Mar 2026 11:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772709411; cv=none; b=E5X8V7rZHl4uT1tKRmjvgqOIqPnXX0LAurSY6pLLaDfcNahHXJ9Im9rpNSRo+UDz7xLgD8jEHU9QcrQHpRjA+XccTHk5oU1BJDTsxJ2kYWkd0A7VN2R7Jq6p8AgYSkLam52NfCNfseTSxzICPDErXy1qfqCbGNzCMsAxmnAIxFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772709411; c=relaxed/simple; bh=SxP7crwwGTtW/8qtKVpftcEDIYnL0dyl19NqcE4qgXQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CavYPTKLXVxtLBlRAZPeIb6bLZw4MoBwAmadYw/FKjR1B6dRMDL8as+gYARZoyCGXFmMp2zQCQC7t2g3QH5VKBw6OQ584VU0NzAwXS2XAaqR73udAhEuW9+yVVrd9v0p4QwSfEpxXGj/+RmEPne/ZxGl9l0+MWizrFzYedJ0LY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aR+0ZmUP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aR+0ZmUP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E225C116C6; Thu, 5 Mar 2026 11:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772709411; bh=SxP7crwwGTtW/8qtKVpftcEDIYnL0dyl19NqcE4qgXQ=; h=From:To:Cc:Subject:Date:From; b=aR+0ZmUP2H/u46JJ4JN8IxdOkHMdwqAmZsBoHYOFATwSh11VyjSSSDmzAlIEw9Xgs IQWwzAKpX/ZWVJqLaMEjDG6p4GbQYGirWLjNsB7KLquKj/VOcjvmnNh4IPMn+uxA7E eGbXRGYQz4iiVIGN9T/TfFbv5tSl74gnsjz4JMkcQ682hSVfXJZZeIDqylAa4TzIaG 86LnkIQPg+nTgZYt0ZNns+QBJ5su098WsY4vB+3hVdbhf255F60HsgkmzphFGxJSsC 02oSGMCgEQnp2O2vOtB1KgrDxwaiq1/qgAQ3RONujfrQzhimjbIJnMTuPHz6AxmUF7 hhMb+D0ZQOuyg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vy6hE-000000004pq-3gBv; Thu, 05 Mar 2026 12:16:48 +0100 From: Johan Hovold To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] w1: ds2490: drop redundant device reference Date: Thu, 5 Mar 2026 12:16:13 +0100 Message-ID: <20260305111613.18546-1-johan@kernel.org> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/w1/masters/ds2490.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c index 35e75d07ef5d..aa1f57f74397 100644 --- a/drivers/w1/masters/ds2490.c +++ b/drivers/w1/masters/ds2490.c @@ -1022,11 +1022,8 @@ static int ds_probe(struct usb_interface *intf, if (!dev) return -ENOMEM; - dev->udev = usb_get_dev(udev); - if (!dev->udev) { - err = -ENOMEM; - goto err_out_free; - } + dev->udev = udev; + memset(dev->ep, 0, sizeof(dev->ep)); usb_set_intfdata(intf, dev); @@ -1085,9 +1082,8 @@ static int ds_probe(struct usb_interface *intf, err_out_clear: usb_set_intfdata(intf, NULL); - usb_put_dev(dev->udev); -err_out_free: kfree(dev); + return err; } @@ -1107,7 +1103,6 @@ static void ds_disconnect(struct usb_interface *intf) usb_set_intfdata(intf, NULL); - usb_put_dev(dev->udev); kfree(dev); } -- 2.52.0