From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD6A384248 for ; Thu, 5 Mar 2026 11:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772709096; cv=none; b=sCbRBwMCmIZBy1DzYIsW6SYs4FrakKH8PgwgZrX2kDGWbrdz1GGcmDCPCSkHgilzP4y4JRSlX3iQOBYCPy/gtD/aoqlTjc0WQOs38tP0M3QccBgs0ecvpaJc/ux8o9j6CnYAsLRFzn+ITv/z2rmCBRro7by3qOFdsPIxxYoyRK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772709096; c=relaxed/simple; bh=dLrn9ltYdYrd8MsAd6moKicuYz2yrptmBuQgQKvRwgc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JFtCKotsF00njO52DO5wMWAo1PPba1Vgz/8D80C4pb6XAG5q5MUAFmH8zhoqUb0wFne2jOwhHur9icflvGtNnMKwxJp+cZuupGo4vT7l5RNT7QsHipz9QSAlG4jpi95pHeUW7GvkVOO0JIwvD74G5kDHwCHz9mhoHkp5mrqTlSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=aCxXFrXi; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="aCxXFrXi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1772709092; bh=dLrn9ltYdYrd8MsAd6moKicuYz2yrptmBuQgQKvRwgc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aCxXFrXinZBBCtVGxXWjTY0aMCFdvzfrG51WoKmkJ03ev4BEYovx42t+XIqDoyDJe iiZizu3uVAKofyogaG+WGferRjRQ3esrf0atqnZznA30ptBjKr8XBdP+VTy+mL7S4k bpvCH1bs8SEdSmT0zlX6fuH+rDYma0NCEkSASM84ZWgJQx4Bpel6CeTm/1LTXzO18K nXcofatp48yBqm9XS4hwT4QM8Qji7WEsg1MXDyAIdVRFgd82+rcwYzcMbYkBekJuSz ifYOiMKeeiSTfwXKSvUKCtIM6LdO5ZFxE6X3WNUlcjstsNLibN/7++ayFQOTMBCCpm 55XHuD4p/Qadw== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7562617E0071; Thu, 5 Mar 2026 12:11:32 +0100 (CET) Date: Thu, 5 Mar 2026 12:11:28 +0100 From: Boris Brezillon To: Akash Goel Cc: liviu.dudau@arm.com, steven.price@arm.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, nd@arm.com Subject: Re: [PATCH] drm/panthor: Correct the order of arguments passed to gem_sync Message-ID: <20260305121128.7c507580@fedora> In-Reply-To: <20260305110723.2871733-1-akash.goel@arm.com> References: <20260305110723.2871733-1-akash.goel@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 5 Mar 2026 11:07:23 +0000 Akash Goel wrote: > This commit corrects the order of arguments passed to panthor_gem_sync() > function, called when the SYNC_WAIT condition has to be evaluated for a > blocked GPU queue. > > Fixes: cd2c9c3015e6 (drm/panthor: Add flag to map GEM object Write-Back Cacheable) > Signed-off-by: Akash Goel Oops, good catch! Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panthor/panthor_sched.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index bd703a2904a1..a70f1db0764e 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -893,14 +893,15 @@ panthor_queue_get_syncwait_obj(struct panthor_group *group, struct panthor_queue > > out_sync: > /* Make sure the CPU caches are invalidated before the seqno is read. > - * drm_gem_shmem_sync() is a NOP if map_wc=true, so no need to check > + * panthor_gem_sync() is a NOP if map_wc=true, so no need to check > * it here. > */ > - panthor_gem_sync(&bo->base.base, queue->syncwait.offset, > + panthor_gem_sync(&bo->base.base, > + DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE, > + queue->syncwait.offset, > queue->syncwait.sync64 ? > sizeof(struct panthor_syncobj_64b) : > - sizeof(struct panthor_syncobj_32b), > - DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE); > + sizeof(struct panthor_syncobj_32b)); > > return queue->syncwait.kmap + queue->syncwait.offset; >