From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D698D378821 for ; Thu, 5 Mar 2026 13:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772715842; cv=none; b=sYVISe4H2IdSgkN0cE56aZ+5hcTDK9jW+3Use+aQvTl2Na6VrgKDtxHQNr0o0XwND9NxASIx3SY+2+BRs3i3HGQy68oyFWT9ZxaqVoVovhJa8bK+zMAOkmicXZZhTUiY774jy1tiRf33FSRsDF8zNDyq91plX7NFPL0X94mu6U0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772715842; c=relaxed/simple; bh=v8zYiNxdDNKISdThn2BFDxjpJVGy5LQl81CygbAWl9g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gHUdVDp1mwy5T63ZMiZXu+5hRCPnoNgRWwBMTlWxSqoBe+7D299Tq1p6UnJac8ba3DqWmiur+IGHD9/JNM9u+RKcUv3lUg2MpKUO3O2D1M7Y4OHAEByjAZ8ebAor3ujXEr3s8C2gcmYrvT6gHe2PfA246jz4nv3X3Y/bBjhwetY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l1aEmjsr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l1aEmjsr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 798CDC116C6; Thu, 5 Mar 2026 13:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772715842; bh=v8zYiNxdDNKISdThn2BFDxjpJVGy5LQl81CygbAWl9g=; h=From:To:Cc:Subject:Date:From; b=l1aEmjsr1mW9rJ8ejF5lEb1MPSfWRSEqQwr56iHcsMHkXmvqYQc9IqETVMQi3B9VZ Psnp0olqgZs+sPiB36AOLABJSXtnb/3EvDRfi8vIDzsm+Cxn61Pbfm3YF7nEE1Xror M6oCxHnIqiqfNZWFGcb+niWtUjxUEKjspWmSh8mq2nFuL9dVG5MfoZKbCbKfXQzR/d WZOWHJluP2kzmFNYVmNqpo1HmGno4KDZyQUOAipSzh2WraEJTfFMd6D2RN4ZlfytLv VodQfkf/wXUQ+WmeRyoHngxa6446pIKRaR/AbE5+Hk1fFJWP4IDYZAprjpktTEt9Sj +bAPKom+QPFJw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vy8My-000000006QH-0nJW; Thu, 05 Mar 2026 14:04:00 +0100 From: Johan Hovold To: Lee Jones Cc: linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] mfd: dln2: drop redundant device reference Date: Thu, 5 Mar 2026 14:03:58 +0100 Message-ID: <20260305130358.24681-1-johan@kernel.org> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/mfd/dln2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c index d12510e391c8..c810b83ac955 100644 --- a/drivers/mfd/dln2.c +++ b/drivers/mfd/dln2.c @@ -600,7 +600,6 @@ static void dln2_stop_rx_urbs(struct dln2_dev *dln2) static void dln2_free(struct dln2_dev *dln2) { dln2_free_rx_urbs(dln2); - usb_put_dev(dln2->usb_dev); kfree(dln2); } @@ -784,7 +783,7 @@ static int dln2_probe(struct usb_interface *interface, dln2->ep_out = epout->bEndpointAddress; dln2->ep_in = epin->bEndpointAddress; - dln2->usb_dev = usb_get_dev(interface_to_usbdev(interface)); + dln2->usb_dev = interface_to_usbdev(interface); dln2->interface = interface; usb_set_intfdata(interface, dln2); init_waitqueue_head(&dln2->disconnect_wq); -- 2.52.0