[PATCH 0/2] lp5680: compile fixes and cleanup

[PATCH 0/2] lp5680: compile fixes and cleanup

[Steffen Trumtrar]

This fixes a compilation error that the kernel test robot found in the
lp5860 driver when it is compiled as a module.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
Steffen Trumtrar (2):
      leds: lp5860: Fix compilation as module
      leds: lp5860: Remove useless select

 drivers/leds/rgb/Kconfig            | 2 --
 drivers/leds/rgb/leds-lp5860-core.c | 6 ++++++
 drivers/leds/rgb/leds-lp5860-spi.c  | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)
---
base-commit: f8d19c87baf1382ff718295c571bc40202be3dd1
change-id: 20260129-v6-19-topic-ti-lp5860-fixes-335c48d65cdb

Best regards,
-- 
Steffen Trumtrar <s.trumtrar@pengutronix.de>

[PATCH 1/2] leds: lp5860: Fix compilation as module

[Steffen Trumtrar]

When the lp5860 is compiled as module, the lp5860_device_init/remove
functions must be exported or the spi-specific module can not use these
functions and the compilation will fail.

Add the needed EXPORT_SYMBOL_GPL calls and while at it the
MODULE_LICENSE and _DESCRIPTION for the lp5860-core module.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601230708.wwFMOXZp-lkp@intel.com/
---
 drivers/leds/rgb/leds-lp5860-core.c | 6 ++++++
 drivers/leds/rgb/leds-lp5860-spi.c  | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/rgb/leds-lp5860-core.c b/drivers/leds/rgb/leds-lp5860-core.c
index 977741a070d19..28b4d86e11f1a 100644
--- a/drivers/leds/rgb/leds-lp5860-core.c
+++ b/drivers/leds/rgb/leds-lp5860-core.c
@@ -185,6 +185,7 @@ int lp5860_device_init(struct device *dev)
 
 	return lp5860_init_dt(lp);
 }
+EXPORT_SYMBOL_GPL(lp5860_device_init);
 
 void lp5860_device_remove(struct device *dev)
 {
@@ -192,3 +193,8 @@ void lp5860_device_remove(struct device *dev)
 
 	lp5860_chip_enable_toggle(lp, LP5860_CHIP_DISABLE);
 }
+EXPORT_SYMBOL_GPL(lp5860_device_remove);
+
+MODULE_AUTHOR("Steffen Trumtrar <kernel@pengutronix.de>");
+MODULE_DESCRIPTION("TI LP5860 RGB LED core driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/leds/rgb/leds-lp5860-spi.c b/drivers/leds/rgb/leds-lp5860-spi.c
index d6b8d93c09978..1a35a18f50fde 100644
--- a/drivers/leds/rgb/leds-lp5860-spi.c
+++ b/drivers/leds/rgb/leds-lp5860-spi.c
@@ -85,5 +85,5 @@ static struct spi_driver lp5860_driver = {
 module_spi_driver(lp5860_driver);
 
 MODULE_AUTHOR("Steffen Trumtrar <kernel@pengutronix.de>");
-MODULE_DESCRIPTION("TI LP5860 RGB LED driver");
+MODULE_DESCRIPTION("TI LP5860 RGB LED spi driver");
 MODULE_LICENSE("GPL");

-- 
2.51.0

Re: [PATCH 1/2] leds: lp5860: Fix compilation as module

[Lee Jones]

On Thu, 29 Jan 2026, Steffen Trumtrar wrote:

> When the lp5860 is compiled as module, the lp5860_device_init/remove
> functions must be exported or the spi-specific module can not use these
> functions and the compilation will fail.
> 
> Add the needed EXPORT_SYMBOL_GPL calls and while at it the
> MODULE_LICENSE and _DESCRIPTION for the lp5860-core module.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601230708.wwFMOXZp-lkp@intel.com/
> ---
>  drivers/leds/rgb/leds-lp5860-core.c | 6 ++++++
>  drivers/leds/rgb/leds-lp5860-spi.c  | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/rgb/leds-lp5860-core.c b/drivers/leds/rgb/leds-lp5860-core.c
> index 977741a070d19..28b4d86e11f1a 100644
> --- a/drivers/leds/rgb/leds-lp5860-core.c
> +++ b/drivers/leds/rgb/leds-lp5860-core.c
> @@ -185,6 +185,7 @@ int lp5860_device_init(struct device *dev)
>  
>  	return lp5860_init_dt(lp);
>  }
> +EXPORT_SYMBOL_GPL(lp5860_device_init);
>  
>  void lp5860_device_remove(struct device *dev)
>  {
> @@ -192,3 +193,8 @@ void lp5860_device_remove(struct device *dev)
>  
>  	lp5860_chip_enable_toggle(lp, LP5860_CHIP_DISABLE);
>  }
> +EXPORT_SYMBOL_GPL(lp5860_device_remove);
> +
> +MODULE_AUTHOR("Steffen Trumtrar <kernel@pengutronix.de>");
> +MODULE_DESCRIPTION("TI LP5860 RGB LED core driver");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/leds/rgb/leds-lp5860-spi.c b/drivers/leds/rgb/leds-lp5860-spi.c
> index d6b8d93c09978..1a35a18f50fde 100644
> --- a/drivers/leds/rgb/leds-lp5860-spi.c
> +++ b/drivers/leds/rgb/leds-lp5860-spi.c
> @@ -85,5 +85,5 @@ static struct spi_driver lp5860_driver = {
>  module_spi_driver(lp5860_driver);
>  
>  MODULE_AUTHOR("Steffen Trumtrar <kernel@pengutronix.de>");
> -MODULE_DESCRIPTION("TI LP5860 RGB LED driver");
> +MODULE_DESCRIPTION("TI LP5860 RGB LED spi driver");

Nit: "SPI"

Also, the set doesn't apply.  Please rebase.

-- 
Lee Jones [李琼斯]

[PATCH 2/2] leds: lp5860: Remove useless select

[Steffen Trumtrar]

The lp5860-core driver selects FW_LOADER and _USER_HELPER.
These are not needed, remove them.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 drivers/leds/rgb/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index d362d15320969..e83f62038be4a 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -30,8 +30,6 @@ config LEDS_LP5860_CORE
 	tristate "Core Driver for TI LP5860"
 	depends on LEDS_CLASS
 	depends on OF
-	select FW_LOADER
-	select FW_LOADER_USER_HELPER
 	select REGMAP
 	help
 	  This option supports common operations for LP5860 devices.

-- 
2.51.0