From: Jakub Kicinski <kuba@kernel.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v2 2/3] bnxt_en: Resize RSS contexts on channel count change
Date: Thu, 5 Mar 2026 19:05:18 -0800 [thread overview]
Message-ID: <20260305190518.4dce9ccc@kernel.org> (raw)
In-Reply-To: <20260304131855.3225539-3-bjorn@kernel.org>
On Wed, 4 Mar 2026 14:18:52 +0100 Björn Töpel wrote:
> + if (netif_is_rxfh_configured(dev) &&
> + ethtool_rxfh_can_resize(bp->rss_indir_tbl,
> + old_tbl_size, new_tbl_size)) {
Doesn't this read a little odd? Shouldn't ethtool_rxfh_can_resize()
return true when ... we can resize? You end up ignoring the real rc
here, and it can only ever be -EINVAL.
> + netdev_warn(dev, "RSS table resize not possible\n");
> + return -EINVAL;
> + }
next prev parent reply other threads:[~2026-03-06 3:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 13:18 [PATCH net-next v2 0/3] ethtool: Dynamic RSS context indirection table resizing Björn Töpel
2026-03-04 13:18 ` [PATCH net-next v2 1/3] ethtool: Add RSS indirection table resize helpers Björn Töpel
2026-03-04 13:18 ` [PATCH net-next v2 2/3] bnxt_en: Resize RSS contexts on channel count change Björn Töpel
2026-03-06 3:05 ` Jakub Kicinski [this message]
2026-03-06 8:13 ` Björn Töpel
2026-03-04 13:18 ` [PATCH net-next v2 3/3] selftests: rss_drv: Add RSS indirection table resize tests Björn Töpel
2026-03-05 9:25 ` [PATCH net-next v2 0/3] ethtool: Dynamic RSS context indirection table resizing Pavan Chebbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305190518.4dce9ccc@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bjorn@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox