[PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Lee Yongjun]

The Broadcom iProc SDHCI controller supports DMA, but its binding
schema does not allow the 'dma-coherent' property.

As a result, dtbs_check reports the following validation errors
on the Northstar2 SoC:

  mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
  are not allowed ('dma-coherent' was unexpected)
  mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
  are not allowed ('dma-coherent' was unexpected)

Allow the 'dma-coherent' property in the schema to fix the validation
errors and accurately reflect the hardware capability.

Signed-off-by: Lee Yongjun <jun85566@gmail.com>
---
 Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
index 2f63f2cdeb71..579e44843404 100644
--- a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
@@ -38,6 +38,8 @@ properties:
     type: boolean
     description: Specifies that controller should use auto CMD12
 
+  dma-coherent: true
+
 required:
   - compatible
   - reg
-- 
2.34.1

Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Ray Jui]

[-- Attachment #1.1: Type: text/plain, Size: 1586 bytes --]

On Thu, Mar 5, 2026 at 3:47 PM Lee Yongjun <jun85566@gmail.com> wrote:

> The Broadcom iProc SDHCI controller supports DMA, but its binding
> schema does not allow the 'dma-coherent' property.
>
> As a result, dtbs_check reports the following validation errors
> on the Northstar2 SoC:
>
>   mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>   are not allowed ('dma-coherent' was unexpected)
>   mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>   are not allowed ('dma-coherent' was unexpected)
>
> Allow the 'dma-coherent' property in the schema to fix the validation
> errors and accurately reflect the hardware capability.
>
> Signed-off-by: Lee Yongjun <jun85566@gmail.com>
> ---
>  Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
> b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
> index 2f63f2cdeb71..579e44843404 100644
> --- a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
> @@ -38,6 +38,8 @@ properties:
>      type: boolean
>      description: Specifies that controller should use auto CMD12
>
> +  dma-coherent: true
> +
>

Yeah for Broadcom iProc SDHCI on ARM64 platforms (including NS2), cache
coherent DMA is supported (as opposed to other 32-bit based ARM platforms).

Change looks good to me. Thanks!


>  required:
>    - compatible
>    - reg
> --
> 2.34.1
>
>

[-- Attachment #1.2: Type: text/html, Size: 2278 bytes --]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5449 bytes --]

Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Krzysztof Kozlowski]

On Thu, Mar 05, 2026 at 04:03:48PM -0800, Ray Jui wrote:
> On Thu, Mar 5, 2026 at 3:47 PM Lee Yongjun <jun85566@gmail.com> wrote:
> 
> > The Broadcom iProc SDHCI controller supports DMA, but its binding
> > schema does not allow the 'dma-coherent' property.
> >
> > As a result, dtbs_check reports the following validation errors
> > on the Northstar2 SoC:
> >
> >   mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
> >   are not allowed ('dma-coherent' was unexpected)
> >   mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
> >   are not allowed ('dma-coherent' was unexpected)
> >
> > Allow the 'dma-coherent' property in the schema to fix the validation
> > errors and accurately reflect the hardware capability.
> >
> > Signed-off-by: Lee Yongjun <jun85566@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
> > b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
> > index 2f63f2cdeb71..579e44843404 100644
> > --- a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
> > @@ -38,6 +38,8 @@ properties:
> >      type: boolean
> >      description: Specifies that controller should use auto CMD12
> >
> > +  dma-coherent: true
> > +
> >
> 
> Yeah for Broadcom iProc SDHCI on ARM64 platforms (including NS2), cache
> coherent DMA is supported (as opposed to other 32-bit based ARM platforms).
> 
> Change looks good to me. Thanks!

Just open the file before giving blanket reviews or how are you exactly
reviewing without knowing what is there? This was already fixed and
this patch is obviously wrong.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Florian Fainelli]

On 3/5/26 15:47, Lee Yongjun wrote:
> The Broadcom iProc SDHCI controller supports DMA, but its binding
> schema does not allow the 'dma-coherent' property.
> 
> As a result, dtbs_check reports the following validation errors
> on the Northstar2 SoC:
> 
>    mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>    are not allowed ('dma-coherent' was unexpected)
>    mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>    are not allowed ('dma-coherent' was unexpected)
> 
> Allow the 'dma-coherent' property in the schema to fix the validation
> errors and accurately reflect the hardware capability.
> 
> Signed-off-by: Lee Yongjun <jun85566@gmail.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Rob Herring (Arm)]

On Fri, 06 Mar 2026 08:47:03 +0900, Lee Yongjun wrote:
> The Broadcom iProc SDHCI controller supports DMA, but its binding
> schema does not allow the 'dma-coherent' property.
> 
> As a result, dtbs_check reports the following validation errors
> on the Northstar2 SoC:
> 
>   mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>   are not allowed ('dma-coherent' was unexpected)
>   mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>   are not allowed ('dma-coherent' was unexpected)
> 
> Allow the 'dma-coherent' property in the schema to fix the validation
> errors and accurately reflect the hardware capability.
> 
> Signed-off-by: Lee Yongjun <jun85566@gmail.com>
> ---
>  Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml:46:3: [error] duplication of key "dma-coherent" in mapping (key-duplicates)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml:46:3: found duplicate key "dma-coherent" with value "True" (original value: "True")
make[2]: *** Deleting file 'Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.example.dts'
Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml:46:3: found duplicate key "dma-coherent" with value "True" (original value: "True")
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1605: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260305234703.38490-1-jun85566@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Krzysztof Kozlowski]

On Fri, Mar 06, 2026 at 08:47:03AM +0900, Lee Yongjun wrote:
> The Broadcom iProc SDHCI controller supports DMA, but its binding
> schema does not allow the 'dma-coherent' property.
> 
> As a result, dtbs_check reports the following validation errors
> on the Northstar2 SoC:
> 
>   mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>   are not allowed ('dma-coherent' was unexpected)
>   mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>   are not allowed ('dma-coherent' was unexpected)
> 
> Allow the 'dma-coherent' property in the schema to fix the validation
> errors and accurately reflect the hardware capability.

So is the hardware capable of coherent DMA or not? Entire commit msg is
silent about this and says how you fix warning without actually telling
us that it is a correct fix.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Krzysztof Kozlowski]

On 06/03/2026 09:42, Krzysztof Kozlowski wrote:
> On Fri, Mar 06, 2026 at 08:47:03AM +0900, Lee Yongjun wrote:
>> The Broadcom iProc SDHCI controller supports DMA, but its binding
>> schema does not allow the 'dma-coherent' property.
>>
>> As a result, dtbs_check reports the following validation errors
>> on the Northstar2 SoC:
>>
>>   mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>>   are not allowed ('dma-coherent' was unexpected)
>>   mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>>   are not allowed ('dma-coherent' was unexpected)
>>
>> Allow the 'dma-coherent' property in the schema to fix the validation
>> errors and accurately reflect the hardware capability.
> 
> So is the hardware capable of coherent DMA or not? Entire commit msg is
> silent about this and says how you fix warning without actually telling
> us that it is a correct fix.
> 

Heh, why am I reviewing it, it's obviously non-tested. Code is already
there!

NAK

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property

[Lee Yongjun]

Dear Krzysztof, Rob, and Ray,

Thank you for the feedback. I've checked the linux-next tree and confirmed 
that Rob Herring's patch (commit acb52756e90c) already addresses this issue.

I apologize for the redundant submission. Please disregard this patch.

Best regards,
Lee Yongjun