From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E753C32ABCA for ; Fri, 6 Mar 2026 22:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772837518; cv=none; b=u+NljCTwMek3YRC8gzXo52A7h5sY9xgaL79IDhyhm9mCpvCKYsDS9pzTVA0AWj/k+qjNY+bZhHqm2YnW7/Ut2UM3Zkl1yyy9H4Th7qCPFIhtY9LIdKiYqFnS3HZ5to65y/7cLW/R7Y1sDQCfkVki+cYzPzknoZN0ykrsqVMv7cY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772837518; c=relaxed/simple; bh=HQx4FZP0hwoFRaYP+yZVzvupoNEj7XezlDV451i1JR4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ip+E62X+hrVeC/srPWhvuFhvwCm4XYb0yQd0Og/YWAAU2ka2q1nPvRqbG/9OyaZn4emiyeAumwUkwTDRcmJZ3mCNBn5YOzxmGLGeHBYcbHI65DTSHeE+EQtfoxPqvtSpeBvuj7AVZgyY7N2bQqpgCylx7fafi4nuk+NziE5pNo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SM5o5VZK; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SM5o5VZK" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso4033315e9.3 for ; Fri, 06 Mar 2026 14:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772837515; x=1773442315; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UItt9/FwrhN7roAlUPWfDla/4L+V2++SjZUd0w1EyJ0=; b=SM5o5VZKVwF2AelxIaFScaioC398hdWs04KQMexdHUEtCKyQ1VOq3MYVakVuVx6n/X N7gPuyklyVdCZ+qO9ddGZQJmln7RkhYLBXkUy3N/6uhnXUC1l6DRf1Z4FGU0o0s8B/pw GuLvsfHgP+tVmh/s9sLbaH6qe0jLHae7pd7o7HkNgnveFhwodM1ho8VYfQsgY0tiBALC JE+ivRXHwmsjY+fAsVw+yCtUNpI7YlAg9jer40ukfCAYdQtmzMeKB9uU4ZhqhIAERm7N b3dKpwddvQDPjtFhh6ifl38Xr2cexaMcwLTZX0RasqFi86T6eMuO4FMoYqWuWP0p3gJr HRvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772837515; x=1773442315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UItt9/FwrhN7roAlUPWfDla/4L+V2++SjZUd0w1EyJ0=; b=NTIDK1lUgpRQuIHHDCPiz9MDL7gunFGDKEXmEZpngDk059OX6j+DdKhRY+bAQn5CGY t9/Wpt1BuqZutGlzr04/+wkUDbfKFLt9Rr5Mb1d8+VJC56cN5kPN+UzugOnEGzeW51Pe rGFHUXexaHRD7V4GafNXIOd29iIW7ofJuU0uQVUq8tYf/O+1gIZZe/SRMk1U9JFn8IBL ELS7AsSf4rcWk18p+TK5682vAe5SXYw+kaH0YurD6AVKQwxbMtQmXDa+M4cE4Zd25ggd anf0vXRm2tefgPE7Ezs+oBX9vA7ZlczwPfsmIIIVjyBoB1dhbhg+8vPxko4XIbRrikm8 ezhA== X-Forwarded-Encrypted: i=1; AJvYcCW+AYVWyRcM+48FUnWYRWcSK9gx8Hjb6vw0b6P6QR94BYOYE1nK1I8cDqbBHRNNudNR+cfWMcNfaFe6KYc=@vger.kernel.org X-Gm-Message-State: AOJu0YyBal9reCJ22AnIPT78LP+YwPbZndHk7tNTM4GcPUhpfmFSk1pP eCQUWCAFUWfcq2QLLcAaRQNiUDxladKayp2z5LQgO3GRRDvOxUQWi40+ X-Gm-Gg: ATEYQzyY+HHpeAI4Hzjww37eAFBDObB1ylAOl5/LaSeg4GtOkZpfZf1brq2RUI1JDij d2v6tjFy0Si+P5A2J3qfWF6OnkI1wfD5pc9UM9FShRzoXY2q0bvgw+ECSM4/RAiHPE8mkZfZ8Qw gv07nIP7u/X0U+CjHKZJM2/JtORESGI8krghu2hd44eppBWwipe4VZCsdbDAY8K9IGxdZTbK1cF 57O14QFFityWGdEgeMAvK4PNDx29bumL6ugS0+ra4jOEzQB7qFtUYKOf1aQJtwnIUZvRb1naoco sQx5i7x+GL4cHX84a8VRtRWlN44qGQC0yRKk3wcNGLw7lFb6qX2kBFMjnhP8u28o8Lv4cR6mH+U MfS6D977OzuKhLqt44eRwsKJuP5sgYdVQR+wtwyvz+QTB5JA5OiRnCflqGSCZs/a651QvssTU1e Tc6xSk7yRKWdVG/Q/cWgaESMaTtC71lLn0wzLq8rxjCKNyLCZ2zZA8BLmqVUFZPl8U5ZB9uqH7y SjSRsp04Fxr X-Received: by 2002:a05:600c:3acf:b0:480:1c10:5633 with SMTP id 5b1f17b1804b1-48526979e65mr61521555e9.26.1772837515220; Fri, 06 Mar 2026 14:51:55 -0800 (PST) Received: from snowdrop.snailnet.com (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae57c05sm6160845f8f.39.2026.03.06.14.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 14:51:54 -0800 (PST) From: david.laight.linux@gmail.com To: Waiman Long , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , linux-kernel@vger.kernel.org, Linus Torvalds , Yafang Shao , Steven Rostedt Cc: David Laight , David Laight Subject: [PATCH v3 next 1/5] Only clear node->locked in the slow osq_lock() path Date: Fri, 6 Mar 2026 22:51:46 +0000 Message-Id: <20260306225150.93178-2-david.laight.linux@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260306225150.93178-1-david.laight.linux@gmail.com> References: <20260306225150.93178-1-david.laight.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Laight node->locked is used to indicate that the owner of the lock has handed it off to the waiting CPU. As such it's value is only relevant in the slow path so it need not be initialised in the fast path. Signed-off-by: David Laight --- kernel/locking/osq_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/osq_lock.c b/kernel/locking/osq_lock.c index b4233dc2c2b0..96c6094157b5 100644 --- a/kernel/locking/osq_lock.c +++ b/kernel/locking/osq_lock.c @@ -97,7 +97,6 @@ bool osq_lock(struct optimistic_spin_queue *lock) int curr = encode_cpu(smp_processor_id()); int old; - node->locked = 0; node->next = NULL; node->cpu = curr; @@ -113,6 +112,7 @@ bool osq_lock(struct optimistic_spin_queue *lock) prev = decode_cpu(old); node->prev = prev; + node->locked = 0; /* * osq_lock() unqueue -- 2.39.5