From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B54292D73B5 for ; Sat, 7 Mar 2026 15:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772896358; cv=none; b=jbp0Q1q+uIck4WjEQxPsjmeUa6PFyxq2JHYNMohj9H5NWVPc9UnryXgIKXg9xbz0/kJn1YGsMj4lBmKY11L+G6VnSdWdjWa1tbkYORwN/SrWf+DDLtasVQzXTeeiWDUEOP9w72o0nDy5RiRboGu5R+SSwMypZuRKQu/o05mJjv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772896358; c=relaxed/simple; bh=e2T+lccA7MjukbLvSBjsowJPbeIBq9EDH3J+RYDvgj4=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=dK06SHNEHBXppSIbUnjQpCbWN91Hek5up1nDIMy9G4JTw5vaslNNrXubGERmOGmHVoNgIr5EjJYHToWPZVLdSM6K3ingFZ9ek6PbXXWDW81DTuSliFX4o3WxhKvlevWKMJuJdZeblUhiUMiSMaGCXXgAhQPrPOi9/V0uXXOG/dQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B1VFekzz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B1VFekzz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9534BC2BC87; Sat, 7 Mar 2026 15:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772896358; bh=e2T+lccA7MjukbLvSBjsowJPbeIBq9EDH3J+RYDvgj4=; h=Date:From:To:Cc:Subject:References:From; b=B1VFekzzUa1QuJxQ7TP2u11Z5w5lsnY+0Rr8rrrLV77NP5fnqHJz04dzYTSSieL4r noslQkaZPe5J6PA9/2H0v+30EgMeFm+Qh8sRek3w6N0GzlMPwTds0Ulb4n/E5jC769 z/eJ+fysXGUBNs12T+CibQ0yy7mv5FpOUze8ungT4cBwJKma3vFQIUz6gqxuOIxTvH 8KoinkJteM3zBomNXsIgJJJ8+2ocPHtKjf9FjgXD92ZRteXetg2WQOzkm+i8f3sqJj RaHFl9nFXv3x5mlrJYsr7tvjEa7Z3ExgZ8sFqBpMU+pIcccD7pW4CWfDFyMQI4py8K 6yNx2hhgRfGLg== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1vytKb-000000010NO-3elN; Sat, 07 Mar 2026 10:12:41 -0500 Message-ID: <20260307151241.729660358@kernel.org> User-Agent: quilt/0.69 Date: Sat, 07 Mar 2026 10:12:25 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Miaoqian Lin , Guenter Roeck Subject: [for-linus][PATCH 1/3] tracing: Add NULL pointer check to trigger_data_free() References: <20260307151224.447677123@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Guenter Roeck If trigger_data_alloc() fails and returns NULL, event_hist_trigger_parse() jumps to the out_free error path. While kfree() safely handles a NULL pointer, trigger_data_free() does not. This causes a NULL pointer dereference in trigger_data_free() when evaluating data->cmd_ops->set_filter. Fix the problem by adding a NULL pointer check to trigger_data_free(). The problem was found by an experimental code review agent based on gemini-3.1-pro while reviewing backports into v6.18.y. Cc: Miaoqian Lin Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: Steven Rostedt (Google) Link: https://patch.msgid.link/20260305193339.2810953-1-linux@roeck-us.net Fixes: 0550069cc25f ("tracing: Properly process error handling in event_hist_trigger_parse()") Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Guenter Roeck Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events_trigger.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_events_trigger.c index fecbd679d432..d5230b759a2d 100644 --- a/kernel/trace/trace_events_trigger.c +++ b/kernel/trace/trace_events_trigger.c @@ -50,6 +50,9 @@ static int trigger_kthread_fn(void *ignore) void trigger_data_free(struct event_trigger_data *data) { + if (!data) + return; + if (data->cmd_ops->set_filter) data->cmd_ops->set_filter(NULL, data, NULL); -- 2.51.0