From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 310BE256C61 for ; Sat, 7 Mar 2026 16:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772902511; cv=none; b=AIH9U7TDojd1i0V0Vj7RGfdrO+TLqShipR/phrCFpvpKzq7luG+Zq5d2GiAiVi4d5bIoMJlH0GrWNRUVAzNohy+32Ea4sKtceKHTIQJZtGwi10rPYJFrpPNKHe407W+TMgZXF/sBL1I9FoomS5IubZx/0T3vUzr8OieBjaefGVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772902511; c=relaxed/simple; bh=xx6klpElkPKYCienaps3X3bhTdVGMS+CXu6bwEG2x8g=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cnJD98hwaCEsuKALpwYap2E72fn+qlfI9Lnev2q98IS/Nrv5zP7KjHb247aeyAnW4Gprx/UYb7cgF4uWKzFEeQC0gFU8X916yRVfJcYukAAjZn6xKF8O25gj5tahb965xF73MeXjRctnLeHkrymRoYgCsp3E/K1Ky/o6MSIWaxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lRPnXlDR; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lRPnXlDR" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4837634de51so44314865e9.1 for ; Sat, 07 Mar 2026 08:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772902508; x=1773507308; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Gak0WWQZi8FzIFPFLF8ZxWn9nNA+K6yaVPN/AbvYjdo=; b=lRPnXlDRSuKTkixCsvZ2HNb9KkiKNe0rgZBI7pnCoRnBzRnt21GiSttuduY2JRXGWt Kv79XSFPLO1arGSlkTbWcpUBeHAZRktp5F3YdYrTJdVzE8s4h27mzTs8nSC+yy3WH36l iQgr6VynuQrMQycBYT+544cT0T7k+XJdrYUmNBPnTD2hvMhfaIzfj0qaDGqIo239iryy SCFV8tEwb3zfOWVe5hfomddYlxVTZ5DUbO+CyeR+9kW37tCb9CDsCP1hMzytsxNS7bwE lyyiNxFb1WctbQVzpGKuR4ETxlPct0GKgHzegv5N69HH6/9Mk35uPCl2e6QykVYo3tBY UOyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772902508; x=1773507308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gak0WWQZi8FzIFPFLF8ZxWn9nNA+K6yaVPN/AbvYjdo=; b=qQTfR5j1qkFw65eGb5UYIhMCE++NoxGek4EVpDNuixWBDRk0Evxtnt1yhKXRoQlNQC u2g1zjfzSokDUOaMR087hRcxpQGhJjW2tZqzvUVoqkwJHskvl+J2U/91zaLtI+V9Pvk4 KgA0RDLroJLOqD4CaPWDTw3oS83Xx15WpLP1UmkjZ7eZC461ZS7uO0pG65QeywLBFxO5 HRMQLZp8RNX4OUyB78O0nepPciNZLp6h38zYZU9LHrBTUPMJJwaQrjS0mNHspB6T+8mN rbVfZ4kVQk+TwxFL9lIEIYma3dExZ3MXX3HcJIluj/fhH1e6fD5lqFHjouE+NdHmaaEt MPOw== X-Forwarded-Encrypted: i=1; AJvYcCUQerQ5GNZJ1RRvZTskM97UF7n62Ty+ZJWqK1IMtQ4kU65uXosVELTEw1yXak8kcUf7re/AwS+EL3AkGTY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl/IEe7gi6QlIQAHk/881UTyxe8w3k0OMJ4IVXs4l+UzMyXYsh f/OxAk+lAwQrCCz58aN22HUq87KRAcNWORjdwrknb5wtmJtqZz00HX6R X-Gm-Gg: ATEYQzxw736oH+KYi4PItjag/lVkYiC0g9+U8L8sEum4BFZMlpNqpfLBT9x01Nw9DBk impsxcCg4Q6rIm14B0OecOnIkvHxDv1ei1Jp4T5z+8sL3ZRl8DoP02eBNIDwQJVDSzjs+iDRDeM ME79QAcbGrKffnwin4K37cTvpvEEaHZyDWApAPPnwFjw6qzT1e9hMFVuQVxfKMWPYFw6Yk1mBGc 0oi7Fcn03e1zFc2gMcRpyycMShPqRiB4xb4Ju5GR0dV83hdt4utQkj2hjr9HMCK4f7n97HedYoT dDQbstj8C5Zm/cMHC6llCKY/ee0IPln6bew9ShYhK+CWooh81l+FgWwrJ1wBCjlGQyLddVaTajW 5imwZwExcVENEh4jwHgIMkjmaIeWhP1oLcWe0iTgIkTt6aAVlrN2qJet6joqbi/kKyxcv6ZfWCj CwI8svVpgmIJOvxmc0CX0Vwjv9QLCy7b2pqeNhK+1XMOOBgRCJ6tUxD17gV66l+imG X-Received: by 2002:a05:600c:828f:b0:485:110f:5b7f with SMTP id 5b1f17b1804b1-4852695815fmr96308365e9.19.1772902508194; Sat, 07 Mar 2026 08:55:08 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4852470c697sm42360555e9.31.2026.03.07.08.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 08:55:07 -0800 (PST) Date: Sat, 7 Mar 2026 16:55:06 +0000 From: David Laight To: Willy Tarreau Cc: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , linux-kernel@vger.kernel.org, Cheng Li Subject: Re: [PATCH v4 next 09/23] tools/nolibc: Implement strerror() in terms of strerror_r() Message-ID: <20260307165506.4fcd86bc@pumpkin> In-Reply-To: References: <20260302101815.3043-1-david.laight.linux@gmail.com> <20260302101815.3043-10-david.laight.linux@gmail.com> <20260307113105.76fb7fe9@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 7 Mar 2026 12:37:35 +0100 Willy Tarreau wrote: ... > > > > +static __attribute__((unused,)) > > > > +int strerror_r(int errnum, char *buf, size_t buflen __attribute__((unused))) > > > > +{ > > > > > > Here I think we can simply do this to comply with the man page: > > > > > > if (buflen < 18) { > > > errno = ERANGE; > > > return -1; > > > > Looks like it should 'return ERANGE' (matching glibc 2.13+). > > Ah you're right, I initially misunderstood the man page as "a positive > number with errno set". But yes, returning ERANGE is fine! Which also means I got the return value wrong when I made it return the length. Might be easiest to apply these patches and then fix it up? David