From: david.laight.linux@gmail.com
To: "Willy Tarreau" <w@1wt.eu>,
"Thomas Weißschuh" <linux@weissschuh.net>,
linux-kernel@vger.kernel.org, "Cheng Li" <lechain@gmail.com>
Cc: David Laight <david.laight.linux@gmail.com>
Subject: [PATCH v5 next 02/17] selftests/nolibc: Rename w to written in expect_vfprintf()
Date: Sun, 8 Mar 2026 11:37:27 +0000 [thread overview]
Message-ID: <20260308113742.12649-3-david.laight.linux@gmail.com> (raw)
In-Reply-To: <20260308113742.12649-1-david.laight.linux@gmail.com>
From: David Laight <david.laight.linux@gmail.com>
Single character variable names don't make code easy to read.
Rename 'w' (used for the return value from snprintf()) 'written'.
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
Unchanged for v5.
V4: Split out from patch 4.
tools/testing/selftests/nolibc/nolibc-test.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index 51390b709af1..9ebebe4ff253 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -1669,7 +1669,7 @@ static int expect_vfprintf(int llen, const char *expected, const char *fmt, ...)
char buf[VFPRINTF_LEN + 80];
unsigned int cmp_len;
va_list args;
- ssize_t w, expected_len;
+ ssize_t written, expected_len;
/* Fill and terminate buf[] to check for overlong/absent writes */
memset(buf, 0xa5, sizeof(buf) - 1);
@@ -1677,7 +1677,7 @@ static int expect_vfprintf(int llen, const char *expected, const char *fmt, ...)
va_start(args, fmt);
/* Limit buffer length to test truncation */
- w = vsnprintf(buf, VFPRINTF_LEN + 1, fmt, args);
+ written = vsnprintf(buf, VFPRINTF_LEN + 1, fmt, args);
va_end(args);
llen += printf(" \"%s\"", buf);
@@ -1700,8 +1700,8 @@ static int expect_vfprintf(int llen, const char *expected, const char *fmt, ...)
return 1;
}
- if (w != expected_len) {
- llen += printf(" written(%d) != %d", (int)w, (int)expected_len);
+ if (written != expected_len) {
+ llen += printf(" written(%d) != %d", (int)written, (int)expected_len);
result(llen, FAIL);
return 1;
}
--
2.39.5
next prev parent reply other threads:[~2026-03-08 11:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 11:37 [PATCH v5 next 00/17] Enhance printf() david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 01/17] tools/nolibc: Add _NOLIBC_OPTIMIZER_HIDE_VAR() to compiler.h david.laight.linux
2026-03-08 11:37 ` david.laight.linux [this message]
2026-03-08 11:37 ` [PATCH v5 next 03/17] tools/nolibc: Implement strerror() in terms of strerror_r() david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 04/17] tools/nolibc: Rename the 'errnum' parameter to strerror() david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 05/17] tools/nolibc/printf: Output pad characters in 16 byte chunks david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 06/17] tools/nolibc/printf: Simplify __nolibc_printf() david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 07/17] tools/nolibc/printf: Use goto and reduce indentation david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 08/17] tools/nolibc/printf: Use bit-masks to hold requested flag, length and conversion chars david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 09/17] tools/nolibc/printf: Add support for length modifiers tzqL and formats iX david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 10/17] tools/nolibc/printf: Handle "%s" with the numeric formats david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 11/17] tools/nolibc/printf: Prepend sign to converted number david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 12/17] tools/nolibc/printf: Add support for conversion flags space and plus david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 13/17] tools/nolibc/printf: Special case 0 and add support for %#x david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 14/17] tools/nolibc/printf: Add support for left aligning fields david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 15/17] tools/nolibc/printf: Add support for zero padding and field precision david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 16/17] tools/nolibc/printf: Add support for octal output david.laight.linux
2026-03-08 11:37 ` [PATCH v5 next 17/17] selftests/nolibc: Use printf variable field widths and precisions david.laight.linux
2026-03-08 11:58 ` [PATCH v5 next 00/17] Enhance printf() Willy Tarreau
2026-03-08 21:01 ` Thomas Weißschuh
2026-03-08 22:41 ` David Laight
2026-03-09 6:55 ` Willy Tarreau
2026-03-09 9:20 ` David Laight
2026-03-13 20:07 ` Thomas Weißschuh
2026-03-13 22:40 ` David Laight
2026-03-14 4:48 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308113742.12649-3-david.laight.linux@gmail.com \
--to=david.laight.linux@gmail.com \
--cc=lechain@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox