From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B38D531B828 for ; Sun, 8 Mar 2026 11:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772969876; cv=none; b=cQXl1+n2c7LBhzD+P0L0mAhNmznfZ7MbH5ngGJ2CPoPNhuprBU1Aq+Ffm/rzPG0WXwof8Zbd7WeuklDeSjJRlWP8DLmW04sUd8ARDRQzX137L/aOr7lmudjBF1LaK5rrWF+PRkqwbf7mEEMD96wsko62m7/pOPtBd/fClrrQC8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772969876; c=relaxed/simple; bh=irKcCVblMfGu+H4cwX8KZpR06oUo3CuLBPkFM1t3lZo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ETRHuX6W2/O07q9LElBLlYWb3ZNaXiXyUiFWYWnzUSKoZV+ZNqwzfK2j1THw97Yw8vw07+C5ji7wsTAKjUxCAkiVxb4DpeadzVKkcLS6o2mfP7Q0sJV/+lUApdxomTOXIdzrr9R9GIiabaVnP/uEYtr0Hienyb/5l4AfbPbRuiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GH+1nVY/; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GH+1nVY/" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-483abed83b6so87920505e9.0 for ; Sun, 08 Mar 2026 04:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772969873; x=1773574673; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z98FnCAQC9fQD/5hj8Ds3y0k291Y2chEyf8+4YWZ+i4=; b=GH+1nVY/nRfVAgeh/FYUatAj6q+5mtEN0bKoHOw01vCcynf9EmJmPoWnUcp/QZIMYn eTyUJJvpIt/xlzpGOQeq4O+r7GYKBQeFJ9VJ8piSrZgkdbS907AJd+yaZHf/+a5kdTP5 0DxTdlBXmsoBrs/WmGYi8LqwBE5GsQO1fMNsbz57JAp4tAb+XaZCg+bwuKDLwFDIRShZ xKmEgJ0eWH9+FEl+/CF1CLo80Am+0mYCXKpwT4DH8GRODWf20CCIpmNCJWfzCmzGq1dP QtPujcOpOOObzl4M6NBMLF/1LOWmSI4ewtkbTCu0R6gGP7Lr5f+FxTzT9evHQU3Jbd9U TFTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772969873; x=1773574673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z98FnCAQC9fQD/5hj8Ds3y0k291Y2chEyf8+4YWZ+i4=; b=GtpW1ZsebcA+QWEUlZ1eQvEu5PHxE1V0fXyBdrpQH5ysoiSSUISTO9BfQkT+/l+mCZ c1r1UR3ChEXda67mPy4rejJYmghZEXflVQTZcQfuPCLyKoiy4/GXQCafYqvgDzLE0B/2 aj1IKivL/XsCwU6iLDWrFnoULFR7Oy26FwNYOG+9GLkaZA8UZSQ5/gROFY+qE8gWbTM/ GK7J8n9zHp3TSRhfnIuCaHTQhZsJhKm2//OdvOL6MBRXKW8mXUHsnr6iT0uDaf5yNOn4 NtBPgAUoRxPdhkA3O9LhLUWaB6XQQZMW+rIX0LdiRlQfjBxEpLk2RjaQyyfoZVLElVX/ ZPXw== X-Forwarded-Encrypted: i=1; AJvYcCXxL+NWnFmK459kgydXqWGWuM7P2vnV5teRvSKHphThsz7h4jHgLLhnUK6pqsubmGmfz212TlPHw+4RC1Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwXpfqTTr46rMbFZlxuhKbuGdjWOEvzwzBZW3Pom9Zynmqkren0 +TSnyOQ/q01Bdnj54NknhOgj2KXXcIzk3gjqKwgSYYNIJHFoXxW3j3R8aokPdr24 X-Gm-Gg: ATEYQzzqcoCqZvrgFxkhCXa4Sj4ByulwVVVEStnvrZsB5mYoOr6bAjY6AHG3XfQusst dXzD4bQzfprwdsc/65FwdRDn5RypA5tvs7c14toV/vNj+iXWTkfVhidpkzg07FDOGSW24mb0a+Z xcWGKTLgWqk4v7RJeRI40n15li+wn1ELCoLUCgFCEsSels7molSMUlqMAQip3eSfqFaz2n6VoWg W/+Do7QpATxXXIrsUlD+VUzdd6Tkti074nqZ4A3hB+xLDsP2TJcz9fSw5W/kRrwmMGPR1XbAXps CSAM/xZnqYmO11QSWZamVmxXXZMkAwrcZfunk8DsX93zRf37jgDJEMNlBQKK6j0PjtVHsQC6rWx 0kJLQdN31GIgLeEPkDv8SfO5VYqKEfA+/RoG1/3ECiQhIYLmCcXupWY6vF0DzyBoHFkPFBDKgMM Z2CfjFqAbREJqT/LbiaSt4CwagpXm6i3nfnhjVLgUhWyo1LECErrQIdrABQaAAZ8khuy0rIH7tH mdrmZMjRjEN X-Received: by 2002:a05:600c:37c9:b0:483:612d:7a9a with SMTP id 5b1f17b1804b1-485268bf171mr127719145e9.0.1772969873094; Sun, 08 Mar 2026 04:37:53 -0700 (PDT) Received: from snowdrop.snailnet.com (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485237dd017sm63621855e9.2.2026.03.08.04.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 04:37:52 -0700 (PDT) From: david.laight.linux@gmail.com To: Willy Tarreau , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , linux-kernel@vger.kernel.org, Cheng Li Cc: David Laight Subject: [PATCH v5 next 05/17] tools/nolibc/printf: Output pad characters in 16 byte chunks Date: Sun, 8 Mar 2026 11:37:30 +0000 Message-Id: <20260308113742.12649-6-david.laight.linux@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260308113742.12649-1-david.laight.linux@gmail.com> References: <20260308113742.12649-1-david.laight.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Laight Simple to do and saves calls to the callback function. Change variables written, width and len to 'signed int' to get better code. Acked-by: Willy Tarreau Signed-off-by: David Laight --- Unchanged for v4 and v5. For v3: - Change to signed variables here rather than a later patch. tools/include/nolibc/stdio.h | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h index 17ca206f77fe..c6d5d075f012 100644 --- a/tools/include/nolibc/stdio.h +++ b/tools/include/nolibc/stdio.h @@ -312,8 +312,8 @@ int __nolibc_printf(__nolibc_printf_cb cb, void *state, const char *fmt, va_list { char escape, lpref, ch; unsigned long long v; - unsigned int written, width; - size_t len, ofs; + int written, width, len; + size_t ofs; char outbuf[21]; const char *outstr; @@ -415,10 +415,14 @@ int __nolibc_printf(__nolibc_printf_cb cb, void *state, const char *fmt, va_list outstr = fmt; len = ofs - 1; flush_str: - while (width-- > len) { - if (cb(state, " ", 1) != 0) + width -= len; + while (width > 0) { + /* Output pad in 16 byte blocks with the small block first. */ + int pad_len = ((width - 1) & 15) + 1; + width -= pad_len; + written += pad_len; + if (cb(state, " ", pad_len) != 0) return -1; - written += 1; } if (cb(state, outstr, len) != 0) return -1; -- 2.39.5