From: Josh Law <hlcj1234567@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Josh Law <objecting@objecting.org>
Subject: [PATCH 1/2] lib/ts_bm: fix integer overflow in pattern length calculation
Date: Sun, 8 Mar 2026 18:04:52 +0000 [thread overview]
Message-ID: <20260308180453.2883890-1-objecting@objecting.org> (raw)
The ts_bm algorithm computes the required allocation size by
multiplying the pattern length by the size of an integer. If the
pattern length is sufficiently large, this can overflow the 32-bit
unsigned int before it is widened to size_t. This could result in an
undersized allocation and a subsequent heap buffer overflow when
copying the pattern.
Fix this by explicitly checking that the length does not exceed
the maximum safe threshold before calculating the buffer sizes.
Signed-off-by: Josh Law <objecting@objecting.org>
---
lib/ts_bm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/ts_bm.c b/lib/ts_bm.c
index eed5967238c5..01ea0a93cf6e 100644
--- a/lib/ts_bm.c
+++ b/lib/ts_bm.c
@@ -166,6 +166,9 @@ static struct ts_config *bm_init(const void *pattern, unsigned int len,
unsigned int prefix_tbl_len = len * sizeof(unsigned int);
size_t priv_size = sizeof(*bm) + len + prefix_tbl_len;
+ if (unlikely(len == 0 || len > (UINT_MAX - sizeof(*bm)) / (sizeof(unsigned int) + 1)))
+ return ERR_PTR(-EINVAL);
+
conf = alloc_ts_config(priv_size, gfp_mask);
if (IS_ERR(conf))
return conf;
--
2.43.0
next reply other threads:[~2026-03-08 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 18:04 Josh Law [this message]
2026-03-08 18:04 ` [PATCH 2/2] lib/ts_kmp: fix integer overflow in pattern length calculation Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308180453.2883890-1-objecting@objecting.org \
--to=hlcj1234567@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=objecting@objecting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox