From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84DF8394488 for ; Mon, 9 Mar 2026 11:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773054081; cv=none; b=CfoWCafsu0MtIrMo5V28o7b5zml94cbqmGTpXAUUkc8MF3jw1gvIepMSOI5SwSU7KMlyTYTuX9TP7+icaBqYervOaYzLBG7sbVB+8lcMKoIj991U8/TBOdOo97kGzw8SZtE3KZLVFNMGTC61zAqHbWy6MO+5b+kKgu7dt2IlDLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773054081; c=relaxed/simple; bh=M4dFRmrmPmhqXhKhFaGDOffAf2JzsWF1o/D8Jy2z8eM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=flXzYkEDjjMA3rzfPV9q6cYwOJVvdioig1EmZjrUWykXBiHUE5vfAXy6msR22i1M4yhe5RvCSyC4Ch/ePfLgWC9XRZwnHDPzRo0wEnEDFjnYf7itNmH2QExDfw/XAww5wPDjQRS7WRY0LsgX2mOWRX0ViSlFVQS/1UfarBDbi14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z8LdREfO; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z8LdREfO" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3598df39444so5004736a91.2 for ; Mon, 09 Mar 2026 04:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773054079; x=1773658879; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nrsLA8b8vlkhz1DvrsNbbbbTjquCC3GRn0AkHrSsHTM=; b=Z8LdREfOIQ7Zk9G2Z2hCU1DMEfz0JH9wIu4bWu7USPc8NAeDUiZ0loQBN+aWCVmfH9 Sx9KSS6Y6gDWjMaVKkXTuHI7Vpt/51CEqcb/VByD5DvDMC5AXTu/sOqisKyRraPqYhMq InyE+fxwYCD5ORBmt7lP7n40ZrypjL0mtnSGiNe47hf5BlX3I1lSXhV1z5aN8AfymWi8 8c5191PYvkVaoT65+raydbVsMZacXLon4fxHvSjUQSCPNvW8eJQRdELk5AF0yVMd2caV JVYNh1uCjNeIeHrrCPE9PiuO5Zo77gkoP4ZeWWxW2c8Mg1OebJLxiqPoRAUnqRe3+QbU bQ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773054079; x=1773658879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nrsLA8b8vlkhz1DvrsNbbbbTjquCC3GRn0AkHrSsHTM=; b=gqiVrUwHwSspS7+DO8s9epGaAZe8eccdkrUObW5sfOOlXIoAhtxKUeX7ogXy1lWHqv uDB3i2yoNur/tVSq7mGvX73v96J2BhgErnb3vJ4SVmidLtAW6s8Z971zFTyZxu2Bd8H8 b9JhcOFjcbQSbVwNn4cxEhhsrDE8eHw4sXm9mvm97dgq1i7l7XU1Q+igAfra4pXOPqEr xDkSrCfivk9KRx21GrI0uvmyRkAiv8FZiTSU86s3Kv+BRKZcKXNKk7cDkziHMX4nsLnl sTAuEw3aRHnmOLC1STChNg9+v3VHvNccQDwXBWUIk14/Lh31SsJrwZmiwR9yVjkSEdMR FDAg== X-Forwarded-Encrypted: i=1; AJvYcCXL0axepH+6qfockbLJ/Ex3DZPwVfuh57O/YulyCQSIBVFPiS1jZclmc9426OhrAVqQLsUxmegti++iGUA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3/sGvy70cZ3Yj1oZaZ3XW9HSPMrHVPJqOWdtQippFo1DrV8ch tLUR51bY2M96GMBI20pqy4ZpBFZH4Ov7JEOYXl2NQdZ8aH1yVVkdFwSk X-Gm-Gg: ATEYQzwq9L7cFdDPRw6k4wZDGYDZHVqBV3t+zOdDGXLZHBUG9FlP+1o3ofC8/XCmRVh UOyOqetB97xYvwipsa17kpwJMgw1mbGaKev9rlHJ9jYVVd4o+xw1sSzzAzOi+gpWJE1/JYSyxhC W4FoNrcpWf5l6XTotVy0AF9QSWmtQCQuj2xLdkiWAggUqB4eWSID7UYRWJu3KEdGfep7IBNXLbw lGgeHxsCCaI72Ti7wtbkymDfUyTxJKs6hTQJBxTKLIK0mN4V7X/ySvhNLJGXu8x/kmbSYWXsLTH WS5RN4WWUG6BygIxtCen4dTt9AbYNYC8fXmhT8SEHQvX8TzBwTzZGF2rzynkMC8kV5ArEOKSHTp 97BzUQkoYn/q+7PouIqdHLgSw30vW4BWyIH+cmKNkCyyCeI3vDN/V0ljA3VhvDjDiPKxZZWcwQH Ni7xrVXGE4jcixmwxSdO9aaPAoWxD3esh2jOBKmrnMC1uVj3rxeoMfyXWWrQ== X-Received: by 2002:a17:90b:2884:b0:359:87ff:f352 with SMTP id 98e67ed59e1d1-359be250d8emr9942768a91.8.1773054076002; Mon, 09 Mar 2026 04:01:16 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359bff279f4sm13268296a91.0.2026.03.09.04.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 04:01:15 -0700 (PDT) From: phucduc.bui@gmail.com To: Dmitry Torokhov , Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , Ingo Molnar , Thomas Gleixner , Marek Vasut , Michael Welling , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phucduc.bui@gmail.com Subject: [PATCH 2/2] Input: Touchscreen: tsc200x - delegate wakeup IRQ management to I2C core Date: Mon, 9 Mar 2026 18:00:44 +0700 Message-ID: <20260309110045.108209-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309110045.108209-1-phucduc.bui@gmail.com> References: <20260309110045.108209-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The tsc200x driver supports both I2C (tsc2004) and SPI (tsc2005) interfaces. Currently, the driver attempts to manually manage the wakeup interrupt by calling enable_irq_wake() and disable_irq_wake() during suspend and resume. However, for I2C devices, the I2C core already automatically handles the wakeup source initialization and IRQ management if the "wakeup-source" property is present in the device tree. Manually managing it again in the driver is redundant and can lead to unbalanced IRQ wake reference counts. Clean up the wakeup IRQ handling by checking the bus type: - For I2C (BUS_I2C): Rely entirely on the I2C core for wakeup management. - For SPI (BUS_SPI): Explicitly call device_init_wakeup() in probe and manually manage enable/disable_irq_wake() during suspend/resume. The ts->wake_irq_enabled flag is also updated accordingly to ensure the driver accurately tracks the wakeup state across both buses. Note: This patch is based on code analysis of the I2C subsystem and has not been verified on actual hardware yet. Signed-off-by: bui duc phuc --- drivers/input/touchscreen/tsc200x-core.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/tsc200x-core.c b/drivers/input/touchscreen/tsc200x-core.c index eba53613b005..d14d967845c8 100644 --- a/drivers/input/touchscreen/tsc200x-core.c +++ b/drivers/input/touchscreen/tsc200x-core.c @@ -465,6 +465,7 @@ int tsc200x_probe(struct device *dev, int irq, const struct input_id *tsc_id, ts->idev = input_dev; ts->regmap = regmap; ts->tsc200x_cmd = tsc200x_cmd; + ts->bustype = tsc_id->bustype; error = device_property_read_u32(dev, "ti,x-plate-ohms", &x_plate_ohm); ts->x_plate_ohm = error ? TSC200X_DEF_RESISTOR : x_plate_ohm; @@ -547,8 +548,9 @@ int tsc200x_probe(struct device *dev, int irq, const struct input_id *tsc_id, return error; } - device_init_wakeup(dev, - device_property_read_bool(dev, "wakeup-source")); + if (ts->bustype == BUS_SPI) + device_init_wakeup(dev, + device_property_read_bool(dev, "wakeup-source")); return 0; } @@ -565,8 +567,13 @@ static int tsc200x_suspend(struct device *dev) ts->suspended = true; - if (device_may_wakeup(dev)) - ts->wake_irq_enabled = enable_irq_wake(ts->irq) == 0; + if (device_may_wakeup(dev)) { + if (ts->bustype == BUS_SPI) + ts->wake_irq_enabled = enable_irq_wake(ts->irq) == 0; + else + ts->wake_irq_enabled = true; + } else + ts->wake_irq_enabled = false; return 0; } @@ -578,7 +585,8 @@ static int tsc200x_resume(struct device *dev) guard(mutex)(&ts->mutex); if (ts->wake_irq_enabled) { - disable_irq_wake(ts->irq); + if (ts->bustype == BUS_SPI) + disable_irq_wake(ts->irq); ts->wake_irq_enabled = false; } -- 2.43.0