From: Leon Romanovsky <leonro@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>, <linux-kernel@vger.kernel.org>,
<linux-next@vger.kernel.org>
Subject: Re: Missing signoff in the rdma tree
Date: Mon, 9 Mar 2026 13:52:26 +0200 [thread overview]
Message-ID: <20260309115226.GV12611@unreal> (raw)
In-Reply-To: <f41b2391-d202-4d2b-96d0-4f9040003a35@sirena.org.uk>
On Mon, Mar 09, 2026 at 11:46:07AM +0000, Mark Brown wrote:
> On Mon, Mar 09, 2026 at 01:40:20PM +0200, Leon Romanovsky wrote:
> > On Mon, Mar 09, 2026 at 11:10:34AM +0000, Mark Brown wrote:
>
> > > eb15cffa15201 ("RDMA/bnxt_re: Support application specific CQs")
>
> > ➜ kernel git:(wip/leon-for-next) git show eb15cffa15201
> > commit eb15cffa15201bd53d1ac296645aa2bc5f726841 (rdma/for-next, rdma/HEAD)
> > Author: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> > Date: Mon Mar 2 16:30:36 2026 +0530
>
> but also, more relevantly:
>
> Commit: Leon Romanovsky <leon@kernel.org>
> CommitDate: Sun Mar 8 06:20:25 2026 -0400
>
> > RDMA/bnxt_re: Support application specific CQs
> >
> > <...>
> >
> > Link: https://patch.msgid.link/r/20260302110036.36387-7-sriharsha.basavapatna@broadcom.com
> > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> > Reviewed-by: Selvin Xavier <selvin.xavier@broadcom.com>
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
>
> > <...>
>
> > > are missing a Signed-off-by from their committers
>
> > Signed-off-by exists.
>
> No, I see signoffs from Sriharsha and Jason but not you and it's you who
> actually did the commit (see above, git show --pretty=fuller). Did you
> by any chance rebase a branch where you'd pulled something from Jason
> (or which Jason had pushed to)?
Jason applied, but I rebased that branch to drop patch which was taken
by mistake.
Thanks
next prev parent reply other threads:[~2026-03-09 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 11:10 Missing signoff in the rdma tree Mark Brown
2026-03-09 11:40 ` Leon Romanovsky
2026-03-09 11:46 ` Mark Brown
2026-03-09 11:52 ` Leon Romanovsky [this message]
2026-03-09 12:43 ` Mark Brown
2026-03-09 12:48 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2026-03-23 13:25 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309115226.GV12611@unreal \
--to=leonro@nvidia.com \
--cc=broonie@kernel.org \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox