Missing signoff in the rdma tree

Missing signoff in the rdma tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

Commits

  eb15cffa15201 ("RDMA/bnxt_re: Support application specific CQs")
  485a21c14b413 ("RDMA/bnxt_re: Separate kernel and user CQ creation paths")
  9ed273bbe6637 ("RDMA/bnxt_re: Refactor bnxt_re_create_cq()")
  0edac801a2693 ("RDMA/bnxt_re: Support doorbell extensions")
  4e99362444a2f ("RDMA/bnxt_re: Refactor bnxt_qplib_create_qp() function")
  f0579e330b773 ("RDMA/bnxt_re: Move the UAPI methods to a dedicated file")
  9db6a217ba5dd ("RDMA: Add IB_UVERBS_CORE_SUPPORT_ROBUST_UDATA")
  ce150a8376e1e ("RDMA/bnxt_re: Use ib_respond_empty_udata()")
  d59f007207b39 ("RDMA/bnxt_re: Use ib_respond_udata()")
  ac4bb15208d1f ("RDMA/bnxt_re: Add missing comp_mask validation")
  12c73bee53133 ("RDMA/bnxt_re: Add compatibility checks to the uapi path for no data")
  ac593f5b66c9d ("RDMA/bnxt_re: Add compatibility checks to the uapi path")
  6df3a6414d736 ("RDMA: Provide documentation about the uABI compatibility rules")
  42d2a291ef474 ("RDMA: Add ib_is_udata_in_empty()")
  f1cac281b4245 ("RDMA: Add ib_respond_udata()")
  4ac738c6a7b90 ("RDMA: Add ib_copy_validate_udata_in_cm()")
  715eccd4798ec ("RDMA: Add ib_copy_validate_udata_in()")
  ea08d8cb8b520 ("RDMA/core: Add rdma_udata_to_dev()")
  8e886928a19d7 ("RDMA: Use copy_struct_from_user() instead of open coding")

are missing a Signed-off-by from their committers

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the rdma tree

[Leon Romanovsky]

On Mon, Mar 09, 2026 at 11:10:34AM +0000, Mark Brown wrote:
> Commits
> 
>   eb15cffa15201 ("RDMA/bnxt_re: Support application specific CQs")

➜  kernel git:(wip/leon-for-next) git show eb15cffa15201
commit eb15cffa15201bd53d1ac296645aa2bc5f726841 (rdma/for-next, rdma/HEAD)
Author: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Date:   Mon Mar 2 16:30:36 2026 +0530

    RDMA/bnxt_re: Support application specific CQs

<...>

    Link: https://patch.msgid.link/r/20260302110036.36387-7-sriharsha.basavapatna@broadcom.com
    Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
    Reviewed-by: Selvin Xavier <selvin.xavier@broadcom.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

<...>

> are missing a Signed-off-by from their committers

Signed-off-by exists.

Thanks

Re: Missing signoff in the rdma tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

On Mon, Mar 09, 2026 at 01:40:20PM +0200, Leon Romanovsky wrote:
> On Mon, Mar 09, 2026 at 11:10:34AM +0000, Mark Brown wrote:

> >   eb15cffa15201 ("RDMA/bnxt_re: Support application specific CQs")

> ➜  kernel git:(wip/leon-for-next) git show eb15cffa15201
> commit eb15cffa15201bd53d1ac296645aa2bc5f726841 (rdma/for-next, rdma/HEAD)
> Author: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> Date:   Mon Mar 2 16:30:36 2026 +0530

but also, more relevantly:

  Commit:     Leon Romanovsky <leon@kernel.org>
  CommitDate: Sun Mar 8 06:20:25 2026 -0400

>     RDMA/bnxt_re: Support application specific CQs
> 
> <...>
> 
>     Link: https://patch.msgid.link/r/20260302110036.36387-7-sriharsha.basavapatna@broadcom.com
>     Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
>     Reviewed-by: Selvin Xavier <selvin.xavier@broadcom.com>
>     Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

> <...>

> > are missing a Signed-off-by from their committers

> Signed-off-by exists.

No, I see signoffs from Sriharsha and Jason but not you and it's you who
actually did the commit (see above, git show --pretty=fuller).  Did you
by any chance rebase a branch where you'd pulled something from Jason
(or which Jason had pushed to)?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the rdma tree

[Leon Romanovsky]

On Mon, Mar 09, 2026 at 11:46:07AM +0000, Mark Brown wrote:
> On Mon, Mar 09, 2026 at 01:40:20PM +0200, Leon Romanovsky wrote:
> > On Mon, Mar 09, 2026 at 11:10:34AM +0000, Mark Brown wrote:
> 
> > >   eb15cffa15201 ("RDMA/bnxt_re: Support application specific CQs")
> 
> > ➜  kernel git:(wip/leon-for-next) git show eb15cffa15201
> > commit eb15cffa15201bd53d1ac296645aa2bc5f726841 (rdma/for-next, rdma/HEAD)
> > Author: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> > Date:   Mon Mar 2 16:30:36 2026 +0530
> 
> but also, more relevantly:
> 
>   Commit:     Leon Romanovsky <leon@kernel.org>
>   CommitDate: Sun Mar 8 06:20:25 2026 -0400
> 
> >     RDMA/bnxt_re: Support application specific CQs
> > 
> > <...>
> > 
> >     Link: https://patch.msgid.link/r/20260302110036.36387-7-sriharsha.basavapatna@broadcom.com
> >     Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> >     Reviewed-by: Selvin Xavier <selvin.xavier@broadcom.com>
> >     Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> 
> > <...>
> 
> > > are missing a Signed-off-by from their committers
> 
> > Signed-off-by exists.
> 
> No, I see signoffs from Sriharsha and Jason but not you and it's you who
> actually did the commit (see above, git show --pretty=fuller).  Did you
> by any chance rebase a branch where you'd pulled something from Jason
> (or which Jason had pushed to)?

Jason applied, but I rebased that branch to drop patch which was taken
by mistake.

Thanks

Re: Missing signoff in the rdma tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 724 bytes --]

On Mon, Mar 09, 2026 at 01:52:26PM +0200, Leon Romanovsky wrote:
> On Mon, Mar 09, 2026 at 11:46:07AM +0000, Mark Brown wrote:

> > No, I see signoffs from Sriharsha and Jason but not you and it's you who
> > actually did the commit (see above, git show --pretty=fuller).  Did you
> > by any chance rebase a branch where you'd pulled something from Jason
> > (or which Jason had pushed to)?

> Jason applied, but I rebased that branch to drop patch which was taken
> by mistake.

Right, if you do that you need to add your signoff to the rebased
commits since they get rewritten during the rebase making you the
committer.  Nothing looking at history can tell a rebase happened.  git
rebase has a --signoff option for this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the rdma tree

[Jason Gunthorpe]

On Mon, Mar 09, 2026 at 12:43:16PM +0000, Mark Brown wrote:
> On Mon, Mar 09, 2026 at 01:52:26PM +0200, Leon Romanovsky wrote:
> > On Mon, Mar 09, 2026 at 11:46:07AM +0000, Mark Brown wrote:
> 
> > > No, I see signoffs from Sriharsha and Jason but not you and it's you who
> > > actually did the commit (see above, git show --pretty=fuller).  Did you
> > > by any chance rebase a branch where you'd pulled something from Jason
> > > (or which Jason had pushed to)?
> 
> > Jason applied, but I rebased that branch to drop patch which was taken
> > by mistake.
> 
> Right, if you do that you need to add your signoff to the rebased
> commits since they get rewritten during the rebase making you the
> committer.  Nothing looking at history can tell a rebase happened.  git
> rebase has a --signoff option for this.

I have to say we have tripped on this issue alot over the years :(

Jason

Missing signoff in the rdma tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

Commits

  c50be61e277e1 ("RDMA/irdma: Add support for GEN4 hardware")
  333ad1665dbc4 ("RDMA/irdma: Provide scratch buffers to firmware for internal use")

are missing a Signed-off-by from their committers

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]