From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 049AB354AF2 for ; Mon, 9 Mar 2026 20:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773087175; cv=none; b=pG6nRFO5z1FiGutrjeGpvrrUEuSr9mAtK66f5odDmse4bqlCCPxfIHQxk4TxQDtJHTzgZg83vKOiEWxPzwJroG9Q/WS/N5435uB6HzJBckAdjL5NdTA9zl69HPJn6HULp9JIkKchmdWsv//wCsMEoXuIMlOfHi6WFC/uqf21Ouw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773087175; c=relaxed/simple; bh=KKjEqW3R9tTDO1aT3CWGT7lLNuFrcQ8gXDzZqGe/FFI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lHnleEzEdtLu4UE3/8vOK6cIaFypmbtjPDHjH4T83FgGTgWFrdOr1DcbMpPjRWEVz58Os3Idp18f/3h/uvwCbzkI6tOj6RW8pCyu061LYyrIdKkMxXT9SJyy7+YkKcZ8ckotUJ32w6pEoo63CbNsBdCZPD1JyWQF3T0Uc5gE/4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UndQx1dk; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UndQx1dk" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso6511835e9.0 for ; Mon, 09 Mar 2026 13:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773087171; x=1773691971; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=L7H4kYocdbxhXcIo1nTTG3WKzkoNhMzO+lmo+XKrpuo=; b=UndQx1dko0ftZt4KeUkUAN9F2j1in6+yUR3KHdXHsJN9NoMoVH2ERpLvfzgBdLyKTp rQJVBMgDFrMizu1K5I9++47WUfKZom9wdeAOHsoJXc6zBxlHLIOpdqmbJcLH8qpUamtV awec29jTMFErItKgILWiijnv+GsQz4yXjj3uf4WWotZoq4puC25ihAGUZqb6lQJSt0uk oRF8msYTKzq+24fcM7fQ1AFImDJwTWGOY3GsYTfTdfe5kxNhElHnL1fU5gdOqotYnVjo RLiN2ja/Gcbn0BO+6lCTlH2cp43e1lACl9hk8qTVxHkS92D15ohBBYqK9mjFJoN11PoD xQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773087171; x=1773691971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=L7H4kYocdbxhXcIo1nTTG3WKzkoNhMzO+lmo+XKrpuo=; b=D8KrYXe1gt2HX6SZPfAouPJvubzRkyWpq6j70l0q/g/UbxalRiCHU1BHRLVyeTpNJC wJF/Rg1WmGjC07sbbUWY3fV8tS+HU6kQjDvVpANYseRbNk9RCBT89CB4usZiV3qz5rpf 5OhcdWPEXf/952qDEr7SlhENdAsRTpZxPa/2pbUb75Nb0o9vphyEyhgJHRlQCIrWr/bN 48jqktVg45ZlhLA8sFhtNPx2m2m4X66sKfmM0JlmX7tFXHu64TWL4r1u8pESgaR/x0vZ XmVDTYo8V8a/9M66ugr18XxsA+eFqK6XvUGO0eI7ekUrnhsNSFuNNnrc2FzaLUBbju1O klQg== X-Forwarded-Encrypted: i=1; AJvYcCVLmVpspT4rdMunY8iuNmCb72NqHANtfpgNDFinmnYAJBM6+D4J0lFggBCyH0utGRLst51NKwO5DqEouq0=@vger.kernel.org X-Gm-Message-State: AOJu0YwmIJJm1HZGnZpOgu8FzcUMuQfG0ZcYLrFHR5zT40VS8NFrt3BH Y36z6pm33mFD8acoUvqRb7ktqGsa/4J8e0xqEmEjnMVJCEJUW2MWyA/x X-Gm-Gg: ATEYQzzbQC5RZM+8yquYuGBWfE6wYZGFUlMoUO/SCOMDiAAKI3ZtLuYzpqnl8gixXWM o5WL7vbHBBPLyEDrdkNCrTclf9EAJnKBI77N5nBjiNtUJB/9SaTPHZHtBVvs+WzJB4qaWJU9iJj nVKH1LtBpiT9uTtY4KecfObnLksxtBMlJ/t+EtCBdbpsU98NdNRj+0t4BTkrEG+vfBxZ319mkCk 468ZJOuFQyyaKVKqfTTwFiFlDcBytsdOC4lCzudh2eu2ApB9uMvCTApJOkSbJL5ONwmL40eTRJ7 QV3Nl3If0hkRVQswkRnuMPUKEHLTi1wo6Yt0HCTh2ep+wF3Qatzem5ssxQf76TiOR+q/tTd22Y9 9LCCxq99ZQaa2yUoNSVZrBNNVX98D8J+QBGk+4NfbrJ/Glm2Wie3fsypZqN+g2DJsMhcSbuA1VJ 6jkVbwqXzK8CTp9qc8PmvkVZ3YXA1JvmiHoW3I571bQZla1F7uSABukiAcsLkqdlEb X-Received: by 2002:a05:600c:a00f:b0:485:358b:e80c with SMTP id 5b1f17b1804b1-485358bea63mr122750265e9.0.1773087171219; Mon, 09 Mar 2026 13:12:51 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485358cd26bsm94471685e9.8.2026.03.09.13.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 13:12:50 -0700 (PDT) Date: Mon, 9 Mar 2026 20:12:49 +0000 From: David Laight To: Greg KH Cc: Mark Adamenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: octeon: replace BUG() with WARN_ON_ONCE() in cvn_oct_xmit() Message-ID: <20260309201249.4672ca61@pumpkin> In-Reply-To: <2026030949-banner-rematch-db18@gregkh> References: <20260305005316.49848-1-marusik.adamenko@gmail.com> <2026030949-banner-rematch-db18@gregkh> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 9 Mar 2026 17:41:14 +0100 Greg KH wrote: > On Wed, Mar 04, 2026 at 04:53:16PM -0800, Mark Adamenko wrote: > > All three values of queue_type are handled in the switch case, making > > the default case unreachable. Replace BUG() with WARN_ON_ONCE() to avoid > > an unnecessary kernel crash if reached. > > > > Signed-off-by: Mark Adamenko > > --- > > drivers/staging/octeon/ethernet-tx.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c > > index f5bbedac6a65..f34d82a433e3 100644 > > --- a/drivers/staging/octeon/ethernet-tx.c > > +++ b/drivers/staging/octeon/ethernet-tx.c > > @@ -450,7 +450,8 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev) > > __skb_queue_tail(&priv->tx_free_list[qos], skb); > > break; > > default: > > - BUG(); > > + WARN_ON_ONCE(1); > > + break; > > If this is impossible to ever hit, then nothing changed here, right? So > why is this even needed? Jeepers, that code is horrid.... But it is trivially impossible to get there. The compiler might even optimise it away! David > > thanks, > > greg k-h >