From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F4EF23BCF7 for ; Mon, 9 Mar 2026 05:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773033642; cv=none; b=nOhpz1HO7TgpZbf6pSjr++AsppBmCClpOL39cJs8ZJ1yW6ErOG4737x+JR0Qyi57NBapKtQI3rp9XpSTsIx4oJSEl9aX9WkaNXgal8LcmTH/mBwE3H+TRJ9M75s/VXx3bCuDGqNDpHVLXAJKRe7RYy189dsd4qXZRqCfS5+Xh2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773033642; c=relaxed/simple; bh=FS2i29kMamMTD50UjT5XoJKxEGOFFM6i/0fwpn6znmc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lhX4Wv4bPdFL0QrCcNwOnpdAGTOKp0eQyP7Qj6uR+DnhorEJQrtNtwADb7hrVKqFiUiLzpe0S4EpZUW3pRm9nc7SPoB96LKnztefj8D7ALpkVcDl6oDx3n0qAkquzpI5eklVtuc4wjO8ovo/dYLtnwYZ0XEVdhoI43tj2SMc25g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Mlc7EsE4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Mlc7EsE4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14901C4CEF7; Mon, 9 Mar 2026 05:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773033641; bh=FS2i29kMamMTD50UjT5XoJKxEGOFFM6i/0fwpn6znmc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mlc7EsE4X+wfssChkP8CkIXLdXZzl6+V/Galgzpkz2mQ4D5ArZfb7/h2GQY29FMZP 1eaBjJtv3Zgj5LxMPhVPBCbOlTFvOZ3T7ygrMDR4osGl1dIv4ykS3EOKMDC04keDhk tbz4danL/fWORo/SJQj7It7/IwTZ2Cwfoq5GGv/U= Date: Mon, 9 Mar 2026 06:20:26 +0100 From: Greg KH To: Jori Koolstra Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Srikar Dronamraju , Shrikanth Hegde , Kees Cook , Haren Myneni , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , open list Subject: Re: [PATCH] powerpc: vas-api: constify dynamic struct class in coproc api register Message-ID: <2026030945-varied-spouse-861c@gregkh> References: <20260308123917.1013607-1-jkoolstra@xs4all.nl> <2026030846-wince-recess-c338@gregkh> <1567347751.876335.1773008140595@kpc.webmail.kpnmail.nl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567347751.876335.1773008140595@kpc.webmail.kpnmail.nl> On Sun, Mar 08, 2026 at 11:15:40PM +0100, Jori Koolstra wrote: > > > Op 08-03-2026 17:19 CET schreef Greg KH : > > > > > > On Sun, Mar 08, 2026 at 01:39:12PM +0100, Jori Koolstra wrote: > > > diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c > > > index 9f093176b8db..34403582c895 100644 > > > --- a/arch/powerpc/platforms/powernv/vas-window.c > > > +++ b/arch/powerpc/platforms/powernv/vas-window.c > > > @@ -1459,7 +1459,6 @@ static const struct vas_user_win_ops vops = { > > > int vas_register_api_powernv(struct module *mod, enum vas_cop_type cop_type, > > > const char *name) > > > { > > > - > > > return vas_register_coproc_api(mod, cop_type, name, &vops); > > > } > > > EXPORT_SYMBOL_GPL(vas_register_api_powernv); > > > > > > > This change wasn't needed here :( > > > > thanks, > > > > greg k-h > > My bad, I meant to copy this here instead of at the top of me last email: > > Now checkpatch complains that: > > CHECK: Blank lines aren't necessary after an open brace '{' That's true, but don't mix patches together, and usually, for code outside of drivers/staging/ don't worry about checkpatch issues. > So the rule is: don't touch white space unless you absolutely have to? > > That is good to know to prevent silly v2's. I know that non-functional > changes are frowned upon; but you also shouldn't sneak in a white space > fixes? Exactly, don't sneak in anything :) thanks, greg k-h