From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: gaohan@iscas.ac.cn, alex@ghiti.fr, aou@eecs.berkeley.edu,
conor+dt@kernel.org, devicetree@vger.kernel.org, dlan@gentoo.org,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
pjw@kernel.org, rabenda.cn@gmail.com, robh@kernel.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH 7/7] riscv: dts: spacemit: PCIe and PHY-related updates for OrangePi RV2
Date: Tue, 10 Mar 2026 17:03:59 +0800 [thread overview]
Message-ID: <20260310090359-GKF302167@kernel.org> (raw)
In-Reply-To: <20260204140619.47536-1-amadeus@jmu.edu.cn>
Hi Chukun,
On 22:06 Wed 04 Feb , Chukun Pan wrote:
> Hi,
>
> > +&combo_phy {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pcie0_3_cfg>;
> > +};
>
> This pinctrl is clearly incorrect (including BPI-F3).
> Checking the schematic reveals that these pins are for CAM_I2C.
I agree, if the phy is used for USB, the pinctrl info can be dropped
Do you want to submit a patch for this?
> By the way, combo_phy connects to USB3, so it should be enabled
> in the USB3 patch.
>
I think this is already done, check usb_dwc3 node in k1.dtsi?
https://github.com/torvalds/linux/blob/v7.0-rc3/arch/riscv/boot/dts/spacemit/k1.dtsi#L1180
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-03-10 9:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 21:38 [PATCH 0/7] riscv: dts: spacemit: Add PMIC regulators usb pcie Han Gao
2026-01-31 21:38 ` [PATCH 1/7] riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2 Han Gao
2026-01-31 21:38 ` [PATCH 2/7] riscv: dts: spacemit: Define fixed regulators " Han Gao
2026-02-01 11:31 ` Yixun Lan
2026-01-31 21:38 ` [PATCH 3/7] riscv: dts: spacemit: Define the P1 PMIC " Han Gao
2026-02-01 5:18 ` Konstantin Ryabitsev
2026-01-31 21:38 ` [PATCH 4/7] riscv: dts: spacemit: Enable USB3.0 on " Han Gao
2026-01-31 21:38 ` [PATCH 5/7] riscv: dts: spacemit: Update PMIC supply properties for " Han Gao
2026-02-01 5:18 ` Konstantin Ryabitsev
2026-01-31 21:38 ` [PATCH 6/7] riscv: dts: spacemit: Add a PCIe regulator " Han Gao
2026-02-04 13:50 ` Chukun Pan
2026-01-31 21:38 ` [PATCH 7/7] riscv: dts: spacemit: PCIe and PHY-related updates " Han Gao
2026-02-04 14:06 ` Chukun Pan
2026-03-10 9:03 ` Yixun Lan [this message]
2026-03-14 7:50 ` Chukun Pan
2026-02-01 5:18 ` [PATCH 0/7] riscv: dts: spacemit: Add PMIC regulators usb pcie Konstantin Ryabitsev
2026-02-01 7:54 ` Vivian Wang
2026-02-01 15:10 ` Konstantin Ryabitsev
2026-02-01 11:26 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310090359-GKF302167@kernel.org \
--to=dlan@kernel.org \
--cc=alex@ghiti.fr \
--cc=amadeus@jmu.edu.cn \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=gaohan@iscas.ac.cn \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rabenda.cn@gmail.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox