* [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
@ 2026-03-10 10:25 Thorsten Blum
2026-03-10 11:33 ` Daniel Lezcano
0 siblings, 1 reply; 7+ messages in thread
From: Thorsten Blum @ 2026-03-10 10:25 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: Thorsten Blum, linux-pm, linux-kernel
Clamping 'val' to itself is unnecessary and the expression can be
simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32
is also redundant and can be removed.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/thermal/sprd_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
index e546067c9621..511f1e7959b6 100644
--- a/drivers/thermal/sprd_thermal.c
+++ b/drivers/thermal/sprd_thermal.c
@@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
*/
val = (temp + sen->cal_offset) / sen->cal_slope;
- return clamp(val, val, (u32)(SPRD_THM_RAW_DATA_HIGH - 1));
+ return min(val, SPRD_THM_RAW_DATA_HIGH - 1);
}
static int sprd_thm_read_temp(struct thermal_zone_device *tz, int *temp)
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
2026-03-10 10:25 [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata Thorsten Blum
@ 2026-03-10 11:33 ` Daniel Lezcano
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Lezcano @ 2026-03-10 11:33 UTC (permalink / raw)
To: Thorsten Blum, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: linux-pm, linux-kernel
On 3/10/26 11:25, Thorsten Blum wrote:
> Clamping 'val' to itself is unnecessary and the expression can be
> simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32
> is also redundant and can be removed.
>
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
Applied, thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
@ 2026-03-14 1:13 Thorsten Blum
2026-03-14 10:48 ` Daniel Lezcano
0 siblings, 1 reply; 7+ messages in thread
From: Thorsten Blum @ 2026-03-14 1:13 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: Thorsten Blum, linux-pm, linux-kernel
Clamping 'val' to itself is unnecessary and the expression can be
simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32
is also redundant and can be removed.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/thermal/sprd_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
index e546067c9621..511f1e7959b6 100644
--- a/drivers/thermal/sprd_thermal.c
+++ b/drivers/thermal/sprd_thermal.c
@@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
*/
val = (temp + sen->cal_offset) / sen->cal_slope;
- return clamp(val, val, (u32)(SPRD_THM_RAW_DATA_HIGH - 1));
+ return min(val, SPRD_THM_RAW_DATA_HIGH - 1);
}
static int sprd_thm_read_temp(struct thermal_zone_device *tz, int *temp)
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
2026-03-14 1:13 Thorsten Blum
@ 2026-03-14 10:48 ` Daniel Lezcano
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Lezcano @ 2026-03-14 10:48 UTC (permalink / raw)
To: Thorsten Blum, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: linux-pm, linux-kernel
On 3/14/26 02:13, Thorsten Blum wrote:
> Clamping 'val' to itself is unnecessary and the expression can be
> simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32
> is also redundant and can be removed.
>
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
You can stop resending, it is already applied :)
https://lore.kernel.org/all/75b4dbdd-6fb4-4dc9-a791-8c8a0e8ef9cf@oss.qualcomm.com/
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
@ 2026-02-24 14:51 Thorsten Blum
2026-03-06 14:15 ` Lukasz Luba
0 siblings, 1 reply; 7+ messages in thread
From: Thorsten Blum @ 2026-02-24 14:51 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: Thorsten Blum, linux-pm, linux-kernel
Clamping 'val' to itself is unnecessary and the expression can be
simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32
is also redundant and can be removed.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/thermal/sprd_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
index e546067c9621..511f1e7959b6 100644
--- a/drivers/thermal/sprd_thermal.c
+++ b/drivers/thermal/sprd_thermal.c
@@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
*/
val = (temp + sen->cal_offset) / sen->cal_slope;
- return clamp(val, val, (u32)(SPRD_THM_RAW_DATA_HIGH - 1));
+ return min(val, SPRD_THM_RAW_DATA_HIGH - 1);
}
static int sprd_thm_read_temp(struct thermal_zone_device *tz, int *temp)
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
2026-02-24 14:51 Thorsten Blum
@ 2026-03-06 14:15 ` Lukasz Luba
0 siblings, 0 replies; 7+ messages in thread
From: Lukasz Luba @ 2026-03-06 14:15 UTC (permalink / raw)
To: Thorsten Blum
Cc: linux-pm, linux-kernel, Chunyan Zhang, Baolin Wang, Orson Zhai,
Daniel Lezcano, Rafael J. Wysocki, Zhang Rui
On 2/24/26 14:51, Thorsten Blum wrote:
> Clamping 'val' to itself is unnecessary and the expression can be
> simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32
> is also redundant and can be removed.
>
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/thermal/sprd_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index e546067c9621..511f1e7959b6 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
> */
> val = (temp + sen->cal_offset) / sen->cal_slope;
>
> - return clamp(val, val, (u32)(SPRD_THM_RAW_DATA_HIGH - 1));
> + return min(val, SPRD_THM_RAW_DATA_HIGH - 1);
> }
>
> static int sprd_thm_read_temp(struct thermal_zone_device *tz, int *temp)
LGTM, please send the next version with the tag
so it's on top of the queue for merging
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
@ 2026-01-26 7:51 Thorsten Blum
0 siblings, 0 replies; 7+ messages in thread
From: Thorsten Blum @ 2026-01-26 7:51 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: Thorsten Blum, linux-pm, linux-kernel
Clamping 'val' to itself is unnecessary and the expression can be
simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32
is also redundant and can be removed.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/thermal/sprd_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
index e546067c9621..511f1e7959b6 100644
--- a/drivers/thermal/sprd_thermal.c
+++ b/drivers/thermal/sprd_thermal.c
@@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
*/
val = (temp + sen->cal_offset) / sen->cal_slope;
- return clamp(val, val, (u32)(SPRD_THM_RAW_DATA_HIGH - 1));
+ return min(val, SPRD_THM_RAW_DATA_HIGH - 1);
}
static int sprd_thm_read_temp(struct thermal_zone_device *tz, int *temp)
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-03-14 10:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-10 10:25 [PATCH RESEND] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata Thorsten Blum
2026-03-10 11:33 ` Daniel Lezcano
-- strict thread matches above, loose matches on Subject: below --
2026-03-14 1:13 Thorsten Blum
2026-03-14 10:48 ` Daniel Lezcano
2026-02-24 14:51 Thorsten Blum
2026-03-06 14:15 ` Lukasz Luba
2026-01-26 7:51 Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox