From: "Björn Töpel" <bjorn@kernel.org>
To: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Donald Hunter <donald.hunter@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Naveen Mamindlapalli <naveenm@marvell.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: "Björn Töpel" <bjorn@kernel.org>,
"Danielle Ratson" <danieller@nvidia.com>,
"Hariprasad Kelam" <hkelam@marvell.com>,
"Ido Schimmel" <idosch@nvidia.com>,
"Kory Maincent" <kory.maincent@bootlin.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Michael Chan" <michael.chan@broadcom.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Pavan Chebbi" <pavan.chebbi@broadcom.com>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Shuah Khan" <shuah@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Willem de Bruijn" <willemb@google.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: [PATCH net-next 08/11] selftests: drv-net: Add MAC loopback netdevsim test
Date: Tue, 10 Mar 2026 11:47:38 +0100 [thread overview]
Message-ID: <20260310104743.907818-9-bjorn@kernel.org> (raw)
In-Reply-To: <20260310104743.907818-1-bjorn@kernel.org>
Add loopback_nsim.py with netdevsim-specific tests for MAC
loopback via the new ethtool_ops loopback callbacks:
- test_get_mac_entry: verify MAC entry appears in dump with correct
component, name, and supported directions
- test_set_mac_near_end: SET near-end, verify via GET and debugfs
- test_set_mac_disable: enable then disable
- test_set_mac_unknown_name: SET with wrong name, expect EOPNOTSUPP
Signed-off-by: Björn Töpel <bjorn@kernel.org>
---
.../testing/selftests/drivers/net/hw/Makefile | 1 +
.../selftests/drivers/net/hw/loopback_nsim.py | 135 ++++++++++++++++++
2 files changed, 136 insertions(+)
create mode 100755 tools/testing/selftests/drivers/net/hw/loopback_nsim.py
diff --git a/tools/testing/selftests/drivers/net/hw/Makefile b/tools/testing/selftests/drivers/net/hw/Makefile
index 1c341aaa88c6..d7041b9d7461 100644
--- a/tools/testing/selftests/drivers/net/hw/Makefile
+++ b/tools/testing/selftests/drivers/net/hw/Makefile
@@ -32,6 +32,7 @@ TEST_PROGS = \
irq.py \
loopback.sh \
loopback_drv.py \
+ loopback_nsim.py \
nic_timestamp.py \
nk_netns.py \
pp_alloc_fail.py \
diff --git a/tools/testing/selftests/drivers/net/hw/loopback_nsim.py b/tools/testing/selftests/drivers/net/hw/loopback_nsim.py
new file mode 100755
index 000000000000..5edc999d920b
--- /dev/null
+++ b/tools/testing/selftests/drivers/net/hw/loopback_nsim.py
@@ -0,0 +1,135 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: GPL-2.0
+
+"""Netdevsim-specific tests for MAC loopback via ethtool_ops.
+
+Verifies that MAC loopback entries appear in dumps, that SET
+operations update state correctly (both via GET and debugfs).
+"""
+
+import errno
+import os
+
+from lib.py import ksft_run, ksft_exit, ksft_eq
+from lib.py import KsftSkipEx, KsftFailEx, ksft_disruptive
+from lib.py import EthtoolFamily, NlError
+from lib.py import NetDrvEnv, ip, defer
+
+# Direction flags as YNL returns them
+DIR_NONE = set()
+DIR_NEAR_END = {'near-end'}
+DIR_FAR_END = {'far-end'}
+
+
+def _nsim_dfs_path(cfg):
+ return cfg._ns.nsims[0].dfs_dir
+
+
+def _dfs_read_u32(cfg, path):
+ with open(os.path.join(_nsim_dfs_path(cfg), path)) as f:
+ return int(f.read().strip())
+
+
+def _dfs_write_u32(cfg, path, val):
+ with open(os.path.join(_nsim_dfs_path(cfg), path), "w") as f:
+ f.write(str(val))
+
+
+def _get_loopback(cfg):
+ results = cfg.ethnl.loopback_get({
+ 'header': {'dev-index': cfg.ifindex}
+ }, dump=True)
+ entries = []
+ for msg in results:
+ if 'entry' in msg:
+ entries.extend(msg['entry'])
+ return entries
+
+
+def _set_loopback(cfg, component, name, direction):
+ cfg.ethnl.loopback_set({
+ 'header': {'dev-index': cfg.ifindex},
+ 'entry': [{
+ 'component': component,
+ 'name': name,
+ 'direction': direction,
+ }]
+ })
+
+
+def test_get_mac_entry(cfg):
+ """GET should return the MAC loopback entry with correct attributes."""
+ entries = _get_loopback(cfg)
+ mac_entries = [e for e in entries if e['component'] == 'mac']
+
+ ksft_eq(len(mac_entries), 1, "Expected 1 MAC loopback entry")
+ ksft_eq(mac_entries[0]['name'], 'mac')
+ ksft_eq(mac_entries[0]['supported'], DIR_NEAR_END | DIR_FAR_END)
+ ksft_eq(mac_entries[0]['direction'], DIR_NONE)
+
+
+@ksft_disruptive
+def test_set_mac_near_end(cfg):
+ """SET MAC near-end and verify via GET and debugfs."""
+ ip(f"link set dev {cfg.ifname} down")
+ defer(ip, f"link set dev {cfg.ifname} up")
+
+ _set_loopback(cfg, 'mac', 'mac', 'near-end')
+ defer(_set_loopback, cfg, 'mac', 'mac', 0)
+
+ entries = _get_loopback(cfg)
+ mac = [e for e in entries if e['component'] == 'mac']
+ ksft_eq(mac[0]['direction'], DIR_NEAR_END)
+
+ dfs_dir = _dfs_read_u32(cfg, "ethtool/mac_lb/direction")
+ ksft_eq(dfs_dir, 1, "debugfs direction should be 1 (NEAR_END)")
+
+
+@ksft_disruptive
+def test_set_mac_disable(cfg):
+ """Enable then disable MAC loopback."""
+ ip(f"link set dev {cfg.ifname} down")
+ defer(ip, f"link set dev {cfg.ifname} up")
+
+ _set_loopback(cfg, 'mac', 'mac', 'near-end')
+ defer(_set_loopback, cfg, 'mac', 'mac', 0)
+
+ _set_loopback(cfg, 'mac', 'mac', 0)
+
+ entries = _get_loopback(cfg)
+ mac = [e for e in entries if e['component'] == 'mac']
+ ksft_eq(mac[0]['direction'], DIR_NONE, "Direction should be off")
+
+ dfs_dir = _dfs_read_u32(cfg, "ethtool/mac_lb/direction")
+ ksft_eq(dfs_dir, 0, "debugfs direction should be 0")
+
+
+@ksft_disruptive
+def test_set_mac_unknown_name(cfg):
+ """SET with unknown name should fail with EOPNOTSUPP."""
+ ip(f"link set dev {cfg.ifname} down")
+ defer(ip, f"link set dev {cfg.ifname} up")
+
+ try:
+ _set_loopback(cfg, 'mac', 'bogus', 'near-end')
+ raise KsftFailEx("Should have rejected unknown name")
+ except NlError as e:
+ ksft_eq(e.error, errno.EOPNOTSUPP,
+ "Expected EOPNOTSUPP for unknown name")
+
+
+def main() -> None:
+ with NetDrvEnv(__file__) as cfg:
+ cfg.ethnl = EthtoolFamily()
+
+ ksft_run([
+ test_get_mac_entry,
+ test_set_mac_near_end,
+ test_set_mac_disable,
+ test_set_mac_unknown_name,
+ ], args=(cfg, ))
+ ksft_exit()
+
+
+if __name__ == "__main__":
+ main()
--
2.53.0
next prev parent reply other threads:[~2026-03-10 10:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 10:47 [PATCH net-next 00/11] ethtool: Generic loopback support Björn Töpel
2026-03-10 10:47 ` [PATCH net-next 01/11] ethtool: Add dump_one_dev callback for per-device sub-iteration Björn Töpel
2026-03-12 2:32 ` Jakub Kicinski
2026-03-13 16:36 ` Björn Töpel
2026-03-10 10:47 ` [PATCH net-next 02/11] ethtool: Add loopback netlink UAPI definitions Björn Töpel
2026-03-11 7:33 ` Maxime Chevallier
2026-03-11 10:39 ` Björn Töpel
2026-03-11 15:30 ` Andrew Lunn
2026-03-11 15:42 ` Maxime Chevallier
2026-03-11 19:37 ` Andrew Lunn
2026-03-12 2:47 ` Jakub Kicinski
2026-03-12 13:46 ` Andrew Lunn
2026-03-13 0:21 ` Jakub Kicinski
2026-03-11 10:50 ` Oleksij Rempel
2026-03-12 2:49 ` Jakub Kicinski
2026-03-11 15:22 ` Andrew Lunn
2026-03-11 15:35 ` Maxime Chevallier
2026-03-11 19:26 ` Andrew Lunn
2026-03-12 2:50 ` Jakub Kicinski
2026-03-12 5:04 ` Oleksij Rempel
2026-03-12 7:49 ` Maxime Chevallier
2026-03-12 8:46 ` Oleksij Rempel
2026-03-12 13:34 ` Andrew Lunn
2026-03-12 13:51 ` Oleksij Rempel
2026-03-12 16:39 ` Maxime Chevallier
2026-03-13 19:11 ` Björn Töpel
2026-03-15 15:09 ` Oleksij Rempel
2026-03-15 16:20 ` Björn Töpel
2026-03-18 15:59 ` Andrew Lunn
2026-03-10 10:47 ` [PATCH net-next 03/11] ethtool: Add loopback GET/SET netlink implementation Björn Töpel
2026-03-12 2:51 ` [net-next,03/11] " Jakub Kicinski
2026-03-10 10:47 ` [PATCH net-next 04/11] ethtool: Add CMIS loopback helpers for module loopback control Björn Töpel
2026-03-10 10:47 ` [PATCH net-next 05/11] selftests: drv-net: Add loopback driver test Björn Töpel
2026-03-10 10:47 ` [PATCH net-next 06/11] ethtool: Add MAC loopback support via ethtool_ops Björn Töpel
2026-03-11 6:04 ` [PATCH 6/11] " Naveen Mamindlapalli
2026-03-10 10:47 ` [PATCH net-next 07/11] netdevsim: Add MAC loopback simulation Björn Töpel
2026-03-10 10:47 ` Björn Töpel [this message]
2026-03-10 10:47 ` [PATCH net-next 09/11] MAINTAINERS: Add entry for ethtool loopback Björn Töpel
2026-03-10 10:47 ` [PATCH net-next 10/11] netdevsim: Add module EEPROM simulation via debugfs Björn Töpel
2026-03-12 2:52 ` [net-next,10/11] " Jakub Kicinski
2026-03-10 10:47 ` [PATCH net-next 11/11] selftests: drv-net: Add CMIS loopback netdevsim test Björn Töpel
2026-03-11 6:18 ` [PATCH net-next 00/11] ethtool: Generic loopback support Naveen Mamindlapalli
2026-03-11 10:24 ` Björn Töpel
2026-03-12 2:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310104743.907818-9-bjorn@kernel.org \
--to=bjorn@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=saeedm@nvidia.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox