From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A71AF36C580; Tue, 10 Mar 2026 11:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773143306; cv=none; b=B+mGjW1gjG0ICoMIKFoY1J9f0w1uQNzBlSCmmxx7FzN7XD0sFUmeYMYUqA91WjzMee+nnRDTFdVZFOuqCqx2ZGN/6MRzJz5loHP9J/NdXMxM9Wgyl3muN5dykiOyaDyvJ1iybpc/omS8w5Knyjf83FOzD6S4GGm7L/qnQQMsay0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773143306; c=relaxed/simple; bh=Jw1AY1K8BFMsal2DolsFjTPgtVzy1zFVvuxb6CRg0ic=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lK4OY+zNE7w5z9TFP2UcOfzZcuoEWkJum+oNGVmPz5muYdMlBit5t/MM5M3xN5Sn/smbA91nwqj5OqygtH4NHq1hEHdfVlHl3ESy4omylA0hkH1VLMt4aUNGSoFbawl4S74auaujJdREXjEYpZN4NO3b0lZV5zUH+r3FGVoO37U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=drUKp5gv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="drUKp5gv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1B78C19423; Tue, 10 Mar 2026 11:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773143306; bh=Jw1AY1K8BFMsal2DolsFjTPgtVzy1zFVvuxb6CRg0ic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=drUKp5gvDcHM19RZKc/JI6zt4irMrEHhGoN+jsboPIuOqJiCksIvNNwfeXkXPr/jj La2tZIaup9uR6CX/MIKuavcDaayxZHkXrYdijqbmfB8cQORShoih28qKr8/fYJyNJv Ergmf28yTaiWZqmIL74TXJcnXa3wMppoDCsyOMFuXyP6lVk4TeJW9G6c5qUhmMssbw wlL/DpRPvWE0M0o8x/Zzsu9zOt1mZBG3RD1uQACN5qmAbJ2NCYmwH7fk1lUNxGf0JO qtJe8ixu7eTeQaBU9u7n7XPJ5B/5lwvuRrZyWsJica2N30+EyOtAY9XhK0gm4hpfjK 43ovpvQU6+Oaw== Date: Tue, 10 Mar 2026 11:48:18 +0000 From: Lee Jones To: Kaustabh Chakraborty Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?iso-8859-1?Q?Andr=E9?= Draszik , Alexandre Belloni , Jonathan Corbet , Shuah Khan , Nam Tran , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 10/13] leds: rgb: add support for Samsung S2M series PMIC RGB LED device Message-ID: <20260310114818.GH183676@google.com> References: <20260225-s2mu005-pmic-v3-0-b4afee947603@disroot.org> <20260225-s2mu005-pmic-v3-10-b4afee947603@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260225-s2mu005-pmic-v3-10-b4afee947603@disroot.org> On Wed, 25 Feb 2026, Kaustabh Chakraborty wrote: > Add support for the RGB LEDs found in certain Samsung S2M series PMICs. > The device has three LED channels, controlled as a single device. These > LEDs are typically used as status indicators in mobile phones. > > The driver includes initial support for the S2MU005 PMIC RGB LEDs. > > Signed-off-by: Kaustabh Chakraborty > --- > drivers/leds/rgb/Kconfig | 11 + > drivers/leds/rgb/Makefile | 1 + > drivers/leds/rgb/leds-s2m-rgb.c | 458 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 470 insertions(+) Start by applying all of the comments I made on the 'flash' device. I'll take a more in-depth look at this one on the next version. -- Lee Jones [李琼斯]