* [PATCH] nvme: Annotate struct nvme_dhchap_key with __counted_by
@ 2026-03-03 21:31 Thorsten Blum
2026-03-10 14:20 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Thorsten Blum @ 2026-03-03 21:31 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Hannes Reinecke, Kees Cook, Gustavo A. R. Silva
Cc: Thorsten Blum, linux-nvme, linux-kernel, linux-hardening
Add the __counted_by() compiler attribute to the flexible array member
'key' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
CONFIG_FORTIFY_SOURCE.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
include/linux/nvme-auth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/nvme-auth.h b/include/linux/nvme-auth.h
index 60e069a6757f..e75c29c51464 100644
--- a/include/linux/nvme-auth.h
+++ b/include/linux/nvme-auth.h
@@ -11,7 +11,7 @@
struct nvme_dhchap_key {
size_t len;
u8 hash;
- u8 key[];
+ u8 key[] __counted_by(len);
};
u32 nvme_auth_get_seqnum(void);
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: Annotate struct nvme_dhchap_key with __counted_by
2026-03-03 21:31 [PATCH] nvme: Annotate struct nvme_dhchap_key with __counted_by Thorsten Blum
@ 2026-03-10 14:20 ` Christoph Hellwig
2026-03-10 14:48 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2026-03-10 14:20 UTC (permalink / raw)
To: Thorsten Blum
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Hannes Reinecke, Kees Cook, Gustavo A. R. Silva, linux-nvme,
linux-kernel, linux-hardening
On Tue, Mar 03, 2026 at 10:31:01PM +0100, Thorsten Blum wrote:
> Add the __counted_by() compiler attribute to the flexible array member
> 'key' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: Annotate struct nvme_dhchap_key with __counted_by
2026-03-10 14:20 ` Christoph Hellwig
@ 2026-03-10 14:48 ` Keith Busch
0 siblings, 0 replies; 3+ messages in thread
From: Keith Busch @ 2026-03-10 14:48 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Thorsten Blum, Jens Axboe, Sagi Grimberg, Hannes Reinecke,
Kees Cook, Gustavo A. R. Silva, linux-nvme, linux-kernel,
linux-hardening
On Tue, Mar 10, 2026 at 03:20:49PM +0100, Christoph Hellwig wrote:
> On Tue, Mar 03, 2026 at 10:31:01PM +0100, Thorsten Blum wrote:
> > Add the __counted_by() compiler attribute to the flexible array member
> > 'key' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> > CONFIG_FORTIFY_SOURCE.
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-10 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-03 21:31 [PATCH] nvme: Annotate struct nvme_dhchap_key with __counted_by Thorsten Blum
2026-03-10 14:20 ` Christoph Hellwig
2026-03-10 14:48 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox