From: Taha Ed-Dafili <0rayn.dev@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
skhan@linuxfoundation.org, me@brighamcampbell.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Taha Ed-Dafili <0rayn.dev@gmail.com>
Subject: [PATCH v2 5/5] iio: dac: ad5504: add optional GPIO control for CLR and LDAC
Date: Tue, 10 Mar 2026 17:48:35 +0000 [thread overview]
Message-ID: <20260310174835.24209-6-0rayn.dev@gmail.com> (raw)
In-Reply-To: <20260310174835.24209-1-0rayn.dev@gmail.com>
Add support for the optional 'clear-gpios' and 'ldac-gpios' properties
defined in the device tree bindings.
Use devm_gpiod_get_optional() with GPIOD_OUT_LOW to ensure the pins are
initialized to their inactive state.
Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com>
---
drivers/iio/dac/ad5504.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
index cd563460fc0a..58538f5263fc 100644
--- a/drivers/iio/dac/ad5504.c
+++ b/drivers/iio/dac/ad5504.c
@@ -7,7 +7,9 @@
#include <linux/bits.h>
#include <linux/device.h>
+#include <linux/err.h>
#include <linux/errno.h>
+#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/mod_devicetable.h>
@@ -48,6 +50,8 @@
* @vref_mv: actual reference voltage used
* @pwr_down_mask: power down mask
* @pwr_down_mode: current power down mode
+ * @gpio_clear: GPIO descriptor for the /CLR pin
+ * @gpio_ldac: GPIO descriptor for the /LDAC pin
* @data: transfer buffer
*/
struct ad5504_state {
@@ -56,6 +60,8 @@ struct ad5504_state {
unsigned short vref_mv;
unsigned pwr_down_mask;
unsigned pwr_down_mode;
+ struct gpio_desc *gpio_clear;
+ struct gpio_desc *gpio_ldac;
__be16 data[2] __aligned(IIO_DMA_MINALIGN);
};
@@ -299,6 +305,14 @@ static int ad5504_probe(struct spi_device *spi)
if (pdata && pdata->vref_mv)
st->vref_mv = pdata->vref_mv;
+ st->gpio_clear = devm_gpiod_get_optional(dev, "clear", GPIOD_OUT_LOW);
+ if (IS_ERR(st->gpio_clear))
+ return PTR_ERR(st->gpio_clear);
+
+ st->gpio_ldac = devm_gpiod_get_optional(dev, "ldac", GPIOD_OUT_LOW);
+ if (IS_ERR(st->gpio_ldac))
+ return PTR_ERR(st->gpio_ldac);
+
st->spi = spi;
indio_dev->name = spi_get_device_id(st->spi)->name;
indio_dev->info = &ad5504_info;
--
2.47.3
next prev parent reply other threads:[~2026-03-10 17:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 17:48 [PATCH v2 0/5] iio: dac: ad5504: fix voltage scaling and add missing bindings Taha Ed-Dafili
2026-03-10 17:48 ` [PATCH v2 1/5] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Taha Ed-Dafili
2026-03-10 20:11 ` Krzysztof Kozlowski
2026-03-11 9:49 ` Taha Ed-Dafili
2026-03-15 12:42 ` Jonathan Cameron
2026-03-11 11:57 ` Nuno Sá
2026-03-10 17:48 ` [PATCH v2 2/5] iio: dac: ad5504: sort headers alphabetically Taha Ed-Dafili
2026-03-10 18:20 ` Andy Shevchenko
2026-03-10 20:15 ` Krzysztof Kozlowski
2026-03-15 12:47 ` Jonathan Cameron
2026-03-10 17:48 ` [PATCH v2 3/5] iio: dac: ad5504: Align headers with IWYU principle Taha Ed-Dafili
2026-03-10 18:32 ` Andy Shevchenko
2026-03-10 17:48 ` [PATCH v2 4/5] iio: dac: ad5504: fix scale via output-range-microvolt Taha Ed-Dafili
2026-03-10 19:16 ` Andy Shevchenko
2026-03-11 9:54 ` [PATCH v2 3/5] iio: dac: ad5504: Align headers with IWYU principle Taha Ed-Dafili
2026-03-11 12:05 ` [PATCH v2 4/5] iio: dac: ad5504: fix scale via output-range-microvolt Nuno Sá
2026-03-10 20:16 ` Krzysztof Kozlowski
2026-03-10 17:48 ` Taha Ed-Dafili [this message]
2026-03-11 11:59 ` [PATCH v2 5/5] iio: dac: ad5504: add optional GPIO control for CLR and LDAC Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310174835.24209-6-0rayn.dev@gmail.com \
--to=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox